Gnus development mailing list
 help / color / mirror / Atom feed
* [PATCH] mml2015-epg-encrypt do not use from header to sign.
@ 2009-01-28 12:00 Daniel Dehennin
  2010-08-29 22:44 ` Lars Magne Ingebrigtsen
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Dehennin @ 2009-01-28 12:00 UTC (permalink / raw)
  To: ding

[-- Attachment #1: Type: text/plain, Size: 417 bytes --]



------------------------------------------------------------
revno: 114
committer: Daniel Dehennin <daniel.dehennin@baby-gnu.org>
branch nick: gnus.mml2015
timestamp: Tue 2009-01-27 20:19:24 +0100
message:
  mml2015-epg-encrypt do not use from header to sign.
  
  * lisp/mml2015.el (mml2015-epg-encrypt): New variable 'sender'
    is (message-options-get 'message-sender). Use it in place of
    mml2015-signers.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Gnus114.patch --]
[-- Type: text/x-patch, Size: 2642 bytes --]

# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: daniel.dehennin@baby-gnu.org-20090127191924-\
#   xrtiwg7rjz2olu7y
# target_branch: ../../gnus.head
# testament_sha1: 62dd1afb29c7b53edee25d53506df79de095c9a7
# timestamp: 2009-01-28 12:59:33 +0100
# source_branch: .
# base_revision_id: daniel.dehennin@baby-gnu.org-20090126152327-\
#   ccpvwbbxys1zto9f
# 
# Begin patch
=== modified file 'lisp/mml2015.el'
--- lisp/mml2015.el	2009-01-22 07:02:15 +0000
+++ lisp/mml2015.el	2009-01-27 19:19:24 +0000
@@ -1182,6 +1182,7 @@
   (let* ((inhibit-redisplay t)
 	 (context (epg-make-context))
 	 (boundary (mml-compute-boundary cont))
+	 (sender (message-options-get 'message-sender))
 	 signer-key
 	 (signers
 	  (or (message-options-get 'mml2015-epg-signers)
@@ -1191,8 +1192,8 @@
 		   (epa-select-keys context "\
 Select keys for signing.
 If no one is selected, default secret key is used.  "
-				    mml2015-signers t)
-		 (if mml2015-signers
+				    sender t)
+		 (if sender
 		     (delq nil
 			   (mapcar
 			    (lambda (signer)
@@ -1206,7 +1207,7 @@
 					    signer)))
 				(error "No secret key for %s" signer))
 			      signer-key)
-			    mml2015-signers)))))))
+			    (list sender))))))))
 	 signature micalg)
     (epg-context-set-armor context t)
     (epg-context-set-textmode context t)
@@ -1249,6 +1250,7 @@
   (let ((inhibit-redisplay t)
 	(context (epg-make-context))
 	(config (epg-configuration))
+	(sender (message-options-get 'message-sender))
 	(recipients (message-options-get 'mml2015-epg-recipients))
 	cipher signers
 	(boundary (mml-compute-boundary cont))
@@ -1266,9 +1268,9 @@
 					      (read-string "Recipients: ")))
 		     "[ \f\t\n\r\v,]+"))))
       (when mml2015-encrypt-to-self
-	(unless mml2015-signers
-	  (error "mml2015-signers not set"))
-	(setq recipients (nconc recipients mml2015-signers)))
+	(unless sender
+	  (error "Message sender not set"))
+	(setq recipients (nconc recipients (list sender))))
       (if mml2015-verbose
 	  (setq recipients
 		(epa-select-keys context "\
@@ -1301,8 +1303,8 @@
 		     (epa-select-keys context "\
 Select keys for signing.
 If no one is selected, default secret key is used.  "
-				      mml2015-signers t)
-		   (if mml2015-signers
+				      sender t)
+		   (if sender
 		       (delq nil
 			     (mapcar
 			      (lambda (signer)
@@ -1316,7 +1318,7 @@
 					      signer)))
 				  (error "No secret key for %s" signer))
 				signer-key)
-			      mml2015-signers)))))))
+			      (list sender))))))))
       (epg-context-set-signers context signers))
     (epg-context-set-armor context t)
     (epg-context-set-textmode context t)


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mml2015-epg-encrypt do not use from header to sign.
  2009-01-28 12:00 [PATCH] mml2015-epg-encrypt do not use from header to sign Daniel Dehennin
@ 2010-08-29 22:44 ` Lars Magne Ingebrigtsen
  0 siblings, 0 replies; 3+ messages in thread
From: Lars Magne Ingebrigtsen @ 2010-08-29 22:44 UTC (permalink / raw)
  To: ding

Daniel Dehennin <daniel.dehennin@baby-gnu.org> writes:

>   * lisp/mml2015.el (mml2015-epg-encrypt): New variable 'sender'
>     is (message-options-get 'message-sender). Use it in place of
>     mml2015-signers.

This doesn't seem to be applied?  But I know nothing about epg, so I'm
not really competent to say whether it should have been or not...

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] mml2015-epg-encrypt do not use from header to sign.
  2009-01-28 11:59 [PATCH] mml2015-epg-sign does not use from header Daniel Dehennin
@ 2009-04-13 20:32 ` Daniel Dehennin
  0 siblings, 0 replies; 3+ messages in thread
From: Daniel Dehennin @ 2009-04-13 20:32 UTC (permalink / raw)
  To: ding

[-- Attachment #1: Type: text/plain, Size: 415 bytes --]



------------------------------------------------------------
revno: 135
committer: Daniel Dehennin <daniel.dehennin@baby-gnu.org>
branch nick: mml2015
timestamp: Mon 2009-04-13 20:06:53 +0200
message:
  mml2015-epg-encrypt do not use from header to sign.
  
  * lisp/mml2015.el (mml2015-epg-encrypt): New variable 'sender'
    is (message-options-get 'message-sender). Use it in addition to
    mml2015-signers.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Gnus-mm2015-135.patch --]
[-- Type: text/x-patch, Size: 2819 bytes --]

# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: daniel.dehennin@baby-gnu.org-20090413180653-\
#   v67k5z5akqbiffsa
# target_branch: ../../gnus.head
# testament_sha1: 2297afa76761151c604ef7a0985fb033bdc209dc
# timestamp: 2009-04-13 20:57:26 +0200
# source_branch: .
# base_revision_id: daniel.dehennin@baby-gnu.org-20090412231027-\
#   rhtvglq3r87nljez
# 
# Begin patch
=== modified file 'lisp/mml2015.el'
--- lisp/mml2015.el	2009-01-22 07:02:15 +0000
+++ lisp/mml2015.el	2009-04-13 18:06:53 +0000
@@ -1182,6 +1182,7 @@
   (let* ((inhibit-redisplay t)
 	 (context (epg-make-context))
 	 (boundary (mml-compute-boundary cont))
+	 (sender (message-options-get 'message-sender))
 	 signer-key
 	 (signers
 	  (or (message-options-get 'mml2015-epg-signers)
@@ -1191,8 +1192,8 @@
 		   (epa-select-keys context "\
 Select keys for signing.
 If no one is selected, default secret key is used.  "
-				    mml2015-signers t)
-		 (if mml2015-signers
+				    (cons sender mml2015-signers) t)
+		 (if (or sender mml2015-signers)
 		     (delq nil
 			   (mapcar
 			    (lambda (signer)
@@ -1206,7 +1207,7 @@
 					    signer)))
 				(error "No secret key for %s" signer))
 			      signer-key)
-			    mml2015-signers)))))))
+			    (cons sender mml2015-signers))))))))
 	 signature micalg)
     (epg-context-set-armor context t)
     (epg-context-set-textmode context t)
@@ -1249,6 +1250,7 @@
   (let ((inhibit-redisplay t)
 	(context (epg-make-context))
 	(config (epg-configuration))
+	(sender (message-options-get 'message-sender))
 	(recipients (message-options-get 'mml2015-epg-recipients))
 	cipher signers
 	(boundary (mml-compute-boundary cont))
@@ -1266,9 +1268,9 @@
 					      (read-string "Recipients: ")))
 		     "[ \f\t\n\r\v,]+"))))
       (when mml2015-encrypt-to-self
-	(unless mml2015-signers
-	  (error "mml2015-signers not set"))
-	(setq recipients (nconc recipients mml2015-signers)))
+	(unless (or sender mml2015-signers)
+	  (error "Message sender and mml2015-signers not set"))
+	(setq recipients (nconc recipients (cons sender mml2015-signers))))
       (if mml2015-verbose
 	  (setq recipients
 		(epa-select-keys context "\
@@ -1301,8 +1303,8 @@
 		     (epa-select-keys context "\
 Select keys for signing.
 If no one is selected, default secret key is used.  "
-				      mml2015-signers t)
-		   (if mml2015-signers
+				      (cons sender mml2015-signers) t)
+		   (if (or sender mml2015-signers)
 		       (delq nil
 			     (mapcar
 			      (lambda (signer)
@@ -1316,7 +1318,7 @@
 					      signer)))
 				  (error "No secret key for %s" signer))
 				signer-key)
-			      mml2015-signers)))))))
+			      (cons sender mml2015-signers))))))))
       (epg-context-set-signers context signers))
     (epg-context-set-armor context t)
     (epg-context-set-textmode context t)


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-08-29 22:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-01-28 12:00 [PATCH] mml2015-epg-encrypt do not use from header to sign Daniel Dehennin
2010-08-29 22:44 ` Lars Magne Ingebrigtsen
  -- strict thread matches above, loose matches on Subject: below --
2009-01-28 11:59 [PATCH] mml2015-epg-sign does not use from header Daniel Dehennin
2009-04-13 20:32 ` [PATCH] mml2015-epg-encrypt do not use from header to sign Daniel Dehennin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).