Re: fix for time-date.el

[Reiner Steib <reinersteib+gmane@imap.cc>]

On Mon, Dec 29 2008, Dave Love wrote:

> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>> Did you test with Emacs 21?
>
> Yes.  I thought it was supposed still to be supported -- that's what the
> gnus-coding Info file says.

Yes, it is supposed to be supported.  I don't test with Emacs 21 (nor
XEmacs) though.

BTW, the major reason not to drop support for Emacs 21 is that we
won't gain much because often the same code is necessary for XEmacs
21.4 (and 21.5).

>> In Emacs 22 and up, declare is a Lisp macro in `subr.el',
>> assoc-string is a built-in function in `src/minibuf.c'.
>
> *Sigh*.  It's been in CL for a very long time...  There's a distressing
> amount of that sort of thing in 22.

IIRC, several useful functions have been moved from CL to Emacs core.
(Maybe after this discussion:
<http://thread.gmane.org/gmane.emacs.devel/78898/focus=78981>)

>> `format-seconds' (where `assoc-string' is used) is not used anywhere
>> in Gnus so it's not a real problem, AFAICS.
>
> Fortunately the function where it's used seems to be new; otherwise it
> would be a problem.  It seems to me to merit a comment at least.

I've added a comment in `format-seconds' and (eval-when-compile
(require 'cl)) along with a comment.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/