message-header-xheader unused, maybe

message-header-xheader unused, maybe

[Kevin Ryde]

[-- Attachment #1: Type: text/plain, Size: 782 bytes --]

In message.el, the message-header-xheader face seems to be unused.
Is that accidental, or deliberate?


Incidentally, some of the colours in message mode with "dark background"
seem a bit dark to me, like DarkGreen for message-header-name.  Do dark
users find them ok?  I use dark, but only on the console, where in fact
"blue3" in message-separator comes out pretty much unreadable -- but
perhaps that's the fault of "tty-color"s mapping.


2007-05-17  Kevin Ryde  <user42@zip.com.au>

	* message.el (message-font-lock-keywords): Use message-header-xheader
	face for "X-Foo", its apparent intended purpose.  Move "X-" pattern
	ahead of the anything pattern, to get it recognised.

(Note the diff is a bit zany, it's actually a swap of the two forms, not
changes to the patterns.)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: message.el.xheader-face.diff --]
[-- Type: text/x-diff, Size: 881 bytes --]

--- message.el	14 May 2007 08:08:50 +1000	7.212
+++ message.el	17 May 2007 15:18:13 +1000	
@@ -1444,13 +1444,13 @@
        (1 'message-header-name)
        (2 'message-header-newsgroups nil t))
       (,(message-font-lock-make-header-matcher
-	 (concat "^\\([A-Z][^: \n\t]+:\\)" content))
+	 (concat "^\\(X-[A-Za-z0-9-]+:\\|In-Reply-To:\\)" content))
        (1 'message-header-name)
-       (2 'message-header-other nil t))
+       (2 'message-header-xheader))
       (,(message-font-lock-make-header-matcher
-	 (concat "^\\(X-[A-Za-z0-9-]+:\\|In-Reply-To:\\)" content))
+	 (concat "^\\([A-Z][^: \n\t]+:\\)" content))
        (1 'message-header-name)
-       (2 'message-header-name))
+       (2 'message-header-other nil t))
       ,@(if (and mail-header-separator
 		 (not (equal mail-header-separator "")))
 	    `((,(concat "^\\(" (regexp-quote mail-header-separator) "\\)$")

Re: message-header-xheader unused, maybe

[Katsumi Yamaoka]

>>>>> In <87r6perki0.fsf@zip.com.au> Kevin Ryde wrote:
> In message.el, the message-header-xheader face seems to be unused.
> Is that accidental, or deliberate?

> Incidentally, some of the colours in message mode with "dark background"
> seem a bit dark to me, like DarkGreen for message-header-name.  Do dark
> users find them ok?  I use dark, but only on the console, where in fact
> "blue3" in message-separator comes out pretty much unreadable -- but
> perhaps that's the fault of "tty-color"s mapping.

I use light.  But I tried the white-on-black Emacs today and
realized I can do nothing in the message header unless I turn
the brightness of the display up to practically the maximum.  It
is similar also in the article buffer.  (It might be because I
usually dim the display too much, though.)  OTOH, emacs-w3m does
not cause me inconvenience.

> 2007-05-17  Kevin Ryde  <user42@zip.com.au>

> 	* message.el (message-font-lock-keywords): Use message-header-xheader
> 	face for "X-Foo", its apparent intended purpose.  Move "X-" pattern
> 	ahead of the anything pattern, to get it recognised.

> (Note the diff is a bit zany, it's actually a swap of the two forms, not
> changes to the patterns.)

I like it.  I've installed it in the trunk.

Regards,

Re: message-header-xheader unused, maybe

[Greg Troxel]

  I use light.  But I tried the white-on-black Emacs today and
  realized I can do nothing in the message header unless I turn
  the brightness of the display up to practically the maximum.  It
  is similar also in the article buffer.  (It might be because I
  usually dim the display too much, though.)  OTOH, emacs-w3m does
  not cause me inconvenience.

I have long used white text on black background, and used to use green
text on black background to avoid fuzz from convergence issues.
I have in .Xresources:

*Background:	black
*Foreground:	white

In a X11 emacs, the colors have not been too annoying, but they are
still darker than I would like.  With emacs running in an xterm, I find
the colors, particularly for quoted text in article display, to be very
dark, to the point where I turn off font-lock-mode to be able to read.

Part of the issue may be the values reported by tty-color-alist in
xterm (NetBSD, XFree86).

(("black" 0 0 0 0)
 ("red" 1 65535 0 0)
 ("green" 2 0 65535 0)
 ("yellow" 3 65535 65535 0)
 ("blue" 4 0 0 65535)
 ("magenta" 5 65535 0 65535)
 ("cyan" 6 0 65535 65535)
 ("white" 7 65535 65535 65535))

In my view the right colors would have high luminances and therefore not
be that saturated.  I mean a light blue like c0c0ff rather than 0000ff.

I don't know that the right fix is.  Perhaps not using color should be
chosen if the palette is inadequate.  Perhaps I should get a spiffier
xterm.

Re: message-header-xheader unused, maybe

[Katsumi Yamaoka]

>>>>> In <smud50t586a.fsf@linuxpal.mit.edu> Greg Troxel wrote:

>   I use light.  But I tried the white-on-black Emacs today and
>   realized I can do nothing in the message header unless I turn
>   the brightness of the display up to practically the maximum.

[...]

> I have long used white text on black background, and used to use green
> text on black background to avoid fuzz from convergence issues.

[...]

> In a X11 emacs, the colors have not been too annoying, but they are
> still darker than I would like.  With emacs running in an xterm, I find
> the colors, particularly for quoted text in article display, to be very
> dark, to the point where I turn off font-lock-mode to be able to read.

I've lightened the default dark colors of some faces, in the Gnus
CVS trunk.  Here's a comparison of old ones and new ones:

http://www.jpl.org/gnus-dark-old-new-colors.png

They look nice at least to my brown eyes.  However, I have neither
a convergence problem (because of LCD ;-) nor an 8 colors xterm.
If you think some colors should be changed, don't hesitate to say.
(Please write the color names or the values of the rgb components
exactly.)

> Part of the issue may be the values reported by tty-color-alist in
> xterm (NetBSD, XFree86).

> (("black" 0 0 0 0)
>  ("red" 1 65535 0 0)
>  ("green" 2 0 65535 0)
>  ("yellow" 3 65535 65535 0)
>  ("blue" 4 0 0 65535)
>  ("magenta" 5 65535 0 65535)
>  ("cyan" 6 0 65535 65535)
>  ("white" 7 65535 65535 65535))

> In my view the right colors would have high luminances and therefore not
> be that saturated.  I mean a light blue like c0c0ff rather than 0000ff.

> I don't know that the right fix is.  Perhaps not using color should be
> chosen if the palette is inadequate.  Perhaps I should get a spiffier
> xterm.

Re: message-header-xheader unused, maybe

[Kevin Ryde]

Greg Troxel <gdt@work.lexort.com> writes:
>
> Part of the issue may be the values reported by tty-color-alist in
> xterm (NetBSD, XFree86).

Does that merely reflect (or is supposed to reflect) the xterm widget
settings (*VT100*color0 etc), rather than controlling it?

> In my view the right colors would have high luminances and therefore not
> be that saturated.  I mean a light blue like c0c0ff rather than 0000ff.

app-defaults/XTerm-color looks like it's got 5c/5c/ff for the light blue
but 0,0,238 for dark blue.  I wouldn't be surprised if some of that
either emulates vt100 or ibm pc, or is an unsophisticated colour model
(or both).

Katsumi Yamaoka <yamaoka@jpl.org> writes:
>
> I've lightened the default dark colors of some faces,

Yep, that helps.