Gnus development mailing list
 help / color / mirror / Atom feed
From: Andreas Seltenreich <andreas+ding@gate450.dyndns.org>
Cc: Oliver Heins <olli@sopos.org>
Subject: Broken display of clearsigned PGP message
Date: Thu, 28 Sep 2006 07:31:50 +0200	[thread overview]
Message-ID: <87u02sr1yx.fsf@gate450.dyndns.org> (raw)

There is a report in de.comm.software.gnus about a clearsigned PGP
message being displayed incorrectly (<URL:news:874putv834.fsf@sopos.org>).
It turned out mm-uu-pgp-signed-extract-1 stumbled across whitespace
contained in the line following the Hash header of the message:

--8<---------------cut here---------------start------------->8---
\-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
 
[signed text]
--8<---------------cut here---------------end--------------->8---

I'm not sure if this message is legal according to RFC 2440.  In 6.2
it states that Armor Headers are followed by a blank line, which is
defined as "zero-length, or containing only whitespace", however in
7. it uses the term "empty line" when describing Armor Headers in
cleartext signatures.

IMHO we should follow "be liberal in what you accept" here, especially
since GnuPG considers the message legal.  Should I apply the attached
patch to v5-10 and HEAD?  Can anyone imagine regressions?

diff -u -r6.29.2.24 mm-uu.el
--- mm-uu.el	28 Apr 2006 05:17:32 -0000	6.29.2.24
+++ mm-uu.el	27 Sep 2006 16:28:24 -0000
@@ -373,7 +373,7 @@
 	   mm-security-handle 'gnus-details
 	   (format "Clear verification not supported by `%s'.\n" mml2015-use))))
       (goto-char (point-min))
-      (if (search-forward "\n\n" nil t)
+      (if (re-search-forward "\n[\t ]*\n" nil t)
 	  (delete-region (point-min) (point)))
       (if (re-search-forward mm-uu-pgp-beginning-signature nil t)
 	  (delete-region (match-beginning 0) (point-max)))



             reply	other threads:[~2006-09-28  5:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-28  5:31 Andreas Seltenreich [this message]
2006-10-13 14:31 ` Andreas Seltenreich
2006-10-13 15:31   ` Reiner Steib
2006-11-18  3:40     ` Andreas Seltenreich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87u02sr1yx.fsf@gate450.dyndns.org \
    --to=andreas+ding@gate450.dyndns.org \
    --cc=olli@sopos.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).