From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/44671 Path: main.gmane.org!not-for-mail From: Matt Armstrong Newsgroups: gmane.emacs.gnus.general Subject: Topic parameters are broken. Date: Sat, 04 May 2002 21:15:37 -0600 Sender: owner-ding@hpc.uh.edu Message-ID: <87u1pnwahy.fsf@squeaker.lickey.com> NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1020568638 8002 127.0.0.1 (5 May 2002 03:17:18 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 5 May 2002 03:17:18 +0000 (UTC) Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 174CWU-00024x-00 for ; Sun, 05 May 2002 05:17:18 +0200 Original-Received: from sina.hpc.uh.edu ([129.7.128.10] ident=lists) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 174CVD-0003Pt-00; Sat, 04 May 2002 22:15:59 -0500 Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Sat, 04 May 2002 22:16:12 -0500 (CDT) Original-Received: from sclp3.sclp.com (qmailr@sclp3.sclp.com [209.196.61.66]) by sina.hpc.uh.edu (8.9.3/8.9.3) with SMTP id WAA27484 for ; Sat, 4 May 2002 22:16:02 -0500 (CDT) Original-Received: (qmail 4531 invoked by alias); 5 May 2002 03:15:43 -0000 Original-Received: (qmail 4526 invoked from network); 5 May 2002 03:15:42 -0000 Original-Received: from hank.lickey.com (ident-is-dumb@64.81.100.235) by gnus.org with SMTP; 5 May 2002 03:15:42 -0000 Original-Received: from squeaker.lickey.com (squeaker.lickey.com [192.168.100.10]) by hank.lickey.com (Postfix) with ESMTP id C5B2DEE3F for ; Sat, 4 May 2002 21:15:41 -0600 (MDT) Original-Received: by squeaker.lickey.com (Postfix, from userid 1000) id C1645BFDD; Sat, 4 May 2002 21:15:37 -0600 (MDT) Original-To: ding@gnus.org Original-Lines: 47 User-Agent: Gnus/5.090007 (Oort Gnus v0.07) Emacs/21.2 (i386-debian-linux-gnu) Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:44671 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:44671 I've been working on a patch to gnus that introduces a new group parameter. In testing, I found that topic parameters are broken. Per Abrahamsen made the following change to gnus-group-find-parameter back in October to help make "mail-followup-to" generation faster. (this is in revision 6.60 of gnus.el). The original version always called the gnus-group-get-parameter-function function, which in topic mode grabs the topic mode parameters and concatenates them together before searching for the group parameter value. The new version skips this, so topic parameters will always be ignored when using gnus-group-find-parameter to look for a specific parameter. Should this change be backed out? (defun gnus-group-find-parameter (group &optional symbol allow-list) "Return the group parameters for GROUP. -If SYMBOL, return the value of that symbol in the group parameters." +If SYMBOL, return the value of that symbol in the group parameters. + +If you call this function inside a loop, consider using the faster +`gnus-group-fast-parameter' instead." (save-excursion (set-buffer gnus-group-buffer) - (let ((parameters - (nconc - (copy-sequence - (funcall gnus-group-get-parameter-function group)) - (gnus-parameters-get-parameter group)))) - (if symbol - (gnus-group-parameter-value parameters symbol allow-list) + (if symbol + (gnus-group-fast-parameter group symbol allow-list) + (let ((parameters + (nconc + (copy-sequence + (funcall gnus-group-get-parameter-function group)) + (gnus-parameters-get-parameter group)))) parameters)))) -- Don't send mail to Jesse.Holm@hole.lickey.com The address is there for spammers to harvest.