From: Matt Armstrong <matt@lickey.com>
Cc: ding@gnus.org
Subject: Re: Bug fix for B c and B m
Date: Sat, 20 Oct 2001 17:24:19 -0600 [thread overview]
Message-ID: <87u1wt3nfg.fsf@squeaker.lickey.com> (raw)
In-Reply-To: <iluofn263p2.fsf@barbar.josefsson.org>
Simon Josefsson <jas@extundo.com> writes:
> Does your patch work with new groups? Compare with:
>
> 2000-03-01 Simon Josefsson <jas@pdc.kth.se>
>
> * gnus-sum.el (gnus-read-move-group-name):
> (gnus-summary-move-article): Use `gnus-group-method' to find out
> what method the manually entered group belong to.
> `gnus-group-name-to-method' doesn't return any method parameters
> and `gnus-find-method-for-group' uses `gnus-group-name-to-method'
> for new groups so they wouldn't work.
Hmm...
> Looking at `gnus-group-method' it looks it should do the right thing
> for new groups, and it seem to work when I run it interactively as
> well. Can you edebug it for some example that gives the wrong
> answer and post it here?
Sure, I did this last night.
The problem is gnus-group-method's behavior when there is no exact
match for the method. In this case, gnus-group-method will use the
last server it saw that had the same back end. It seems that when
this happens, things break.
For example, I have no "nnfolder" method. I have an nnfolder+archive
and nnfolder+save (the latter I just created for testing purposes).
(insert (pp (gnus-group-method "nnfolder+foo:bar")))
(nnfolder "save"
(nnfolder-directory "~/g/nnfolder+save")
(nnfolder-active-file "~/g/nnfolder+save/active")
(nnfolder-newsgroups-file "~/g/nnfolder+save/newsgroups")
(nnfolder-get-new-mail nil))
(insert (pp (gnus-find-method-for-group "nnfolder+foo:bar")))
(nnfolder "foo")
I think the second one is more correct.
But I do see what you mean with gnus-find-method-for-group not
returning method parameters:
(insert (pp (gnus-group-method "nnfolder+save:bar")))
(nnfolder "save"
(nnfolder-directory "~/g/nnfolder+save")
(nnfolder-active-file "~/g/nnfolder+save/active")
(nnfolder-newsgroups-file "~/g/nnfolder+save/newsgroups")
(nnfolder-get-new-mail nil))
(insert (pp (gnus-find-method-for-group "nnfolder+save:bar")))
(nnfolder "save")
With current CVS (no local patches), I do a "B c nnfolder+foo:bar" and
Gnus prompts me if I want to create the group, I say yes. But
problems are not far off because some code (namely, that code using
gnus-find-method-for-group) thinks the group's method is (nnfolder
"foo") and other code thinks it is (nnfolder "save" ...).
--
matt
prev parent reply other threads:[~2001-10-20 23:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-20 7:08 Matt Armstrong
2001-10-20 9:50 ` Simon Josefsson
2001-10-20 23:24 ` Matt Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87u1wt3nfg.fsf@squeaker.lickey.com \
--to=matt@lickey.com \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).