Re: Help testing gnus-search fixups

[Thomas Alexander Gerds <tag@biostat.ku.dk>]

I see 2 issues:

1. you may need 

(setq group (gnus-group-full-name group server))

before

(setq article (file-name-nondirectory f-name) ...

2. with the patch 

 (member group groups)

is nil when I use search-group-spec to '("nnml:" . ("nnml:")) to match
all nnml groups.

cheers

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Adam Sjøgren <asjo@koldfront.dk> writes:
>
>> Eric writes:
>>
>>> if you're using notmuch or namazu, please help me give this a whirl!
>>
>> Which version of Emacs is your patch against? I just tried applying it
>> to master@2a33fc8d19 and got:
>
> It applies to up-to-date master -- there's one other change that went
> into this function since your current revision. The changes are confined
> to the one function, so you could also just eval this definition:
>
> (cl-defmethod gnus-search-indexed-parse-output ((engine gnus-search-indexed)
> 						server query &optional groups)
>   (let ((prefix (or (slot-value engine 'remove-prefix)
>                     ""))
> 	artlist article group)
>     (goto-char (point-min))
>     ;; Prep prefix, we want to at least be removing the root
>     ;; filesystem separator.
>     (when (stringp prefix)
>       (setq prefix (file-name-as-directory
>                     (expand-file-name prefix "/"))))
>     (while (not (or (eobp)
>                     (looking-at-p
>                      "\\(?:[[:space:]\n]+\\)?Process .+ finished")))
>       (pcase-let ((`(,f-name ,score) (gnus-search-indexed-extract engine)))
> 	(when (and f-name
>                    (file-readable-p f-name)
> 		   (null (file-directory-p f-name)))
>           (setq group
>                 (replace-regexp-in-string
> 	         "[/\\]" "."
> 	         (replace-regexp-in-string
> 	          "/?\\(cur\\|new\\|tmp\\)?/\\'" ""
> 	          (replace-regexp-in-string
> 	           "\\`\\." ""
> 	           (string-remove-prefix
>                     prefix (file-name-directory f-name))
>                    nil t)
> 	          nil t)
> 	         nil t))
>           (setq article (file-name-nondirectory f-name)
>                 article
>                 ;; TODO: Provide a cleaner way of producing final
>                 ;; article numbers for the various backends.
>                 (if (string-match-p "\\`[[:digit:]]+\\'" article)
> 		    (string-to-number article)
> 		  (nnmaildir-base-name-to-article-number
> 		   (substring article 0 (string-match ":" article))
> 		   group (string-remove-prefix "nnmaildir:" server))))
>           (when (and (numberp article)
>                      (or (null groups)
>                          (member group groups)))
> 	    (push (list f-name article group score)
>                   artlist)))))
>     ;; Are we running an additional grep query?
>     (when-let ((grep-reg (alist-get 'grep query)))
>       (setq artlist (gnus-search-grep-search engine artlist grep-reg)))
>     ;; Munge into the list of vectors expected by nnselect.
>     (mapcar (pcase-lambda (`(,_ ,article ,group ,score))
>               (vector group article
>                       (if (numberp score)
> 			  score
> 		        (string-to-number score))))
>             artlist)))
>
>
>

-- 
7LL-1 Make peace with your past so it doesn’t spoil your present.