Gnus development mailing list
 help / color / mirror / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: ding@gnus.org
Subject: Re: gnus uses a cache?  And how it affects mairix searches...
Date: Wed, 12 Nov 2014 11:08:29 +0800	[thread overview]
Message-ID: <87vbmlm7yq.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <878ujhnqco.fsf@ericabrahamsen.net>

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Andreas Schwab <schwab@linux-m68k.org> writes:
>
>> Dan Christensen <jdc@uwo.ca> writes:
>>
>>> In gnus.el, it doesn't list nnmairix at all, but somehow when using
>>> nnmairix, an entry for nnmairix gets added to this list, without the
>>> virtual keyword (see below).
>>
>> diff --git a/lisp/nnmairix.el b/lisp/nnmairix.el
>> index 0cef699..b2f74e3 100644
>> --- a/lisp/nnmairix.el
>> +++ b/lisp/nnmairix.el
>> @@ -417,7 +417,7 @@ Other back ends might or might not work.")
>>  
>>  (nnoo-define-basics nnmairix)
>>  
>> -(gnus-declare-backend "nnmairix" 'mail 'address)
>> +(gnus-declare-backend "nnmairix" 'mail 'address 'virtual)
>>  
>>  (deffoo nnmairix-open-server (server &optional definitions)
>>    ;; just set server variables
>>
>> Andreas.
>
> After look at this for a while, I do think this is the right solution --
> what do you all think? Can someone apply this change?

Oh never mind, I guess I didn't look long enough. For any backend
declared as virtual, `gnus-cache-possibly-enter-article' will use
`nnvirtual-find-group-art' to get the real group name.

That means that if a backend is declared 'virtual but isn't actually
nnvirtual, the caching mechanism will use the wrong lookup function.

nnir should use `nnir-article-group'

nnmairix could probably do it with a little massaging of
`nnmairix-determine-original-group-from-path'.

What we'd really want is a properly-abstracted nnoo function that
virtual backends would use to locate the real article.

In the meantime, it would probably be enough to make
`gnus-uncacheable-groups' match nnmairix and nnir groups.

Eric




  reply	other threads:[~2014-11-12  3:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-06 22:36 gnus uses a cache? Sharon Kimble
2014-09-07 11:40 ` Adam Sjøgren
2014-09-07 14:22 ` James Cloos
2014-09-08  1:26   ` gnus uses a cache? And how it affects mairix searches Dan Christensen
2014-10-20 22:51     ` Dan Christensen
2014-10-20 23:57       ` Eric Abrahamsen
2014-10-22  7:47         ` Eric Abrahamsen
2014-10-22  8:30           ` Eric Abrahamsen
2014-10-23  6:59             ` Alan Schmitt
2014-10-24 15:13       ` Eric Abrahamsen
2014-10-28 14:32         ` Dan Christensen
2014-10-28 17:52           ` Andreas Schwab
2014-11-12  1:45             ` Eric Abrahamsen
2014-11-12  3:08               ` Eric Abrahamsen [this message]
2014-11-12 21:28                 ` Dan Christensen
2014-11-13  0:26                   ` Eric Abrahamsen
2014-11-16  1:00                     ` Dan Christensen
2014-11-16  3:36                       ` Eric Abrahamsen
2015-01-27  5:03                         ` Lars Ingebrigtsen
2014-09-24 15:35 ` gnus uses a cache? Ted Zlatanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vbmlm7yq.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).