Updates to sieve-manage.el

Updates to sieve-manage.el

[Albert Krewinkel]

Hi all,

I tried to get sieve-manage working with my dovecot/pigeonhole server.
It didn't quite work out of the box, so I made a few adjustments to the
code.  The result is in my github-repo at
git://github.com/tarleb/gnus.git (in the "sieve" branch).

Most noticable changes:
 - Added support for starttls
 - Allowing multibyte-process buffers (couldn't get
   string-parsing/encoding working without it)
 - Slightly nicer looking code (IMHO of course)
 - An ugly workaround which I intend to fix by the end of
   next week.

Any feedback on the code or advice on how to get this upstream would be
highly appreciated.

Thanks,

Albert

Re: Updates to sieve-manage.el

[Julien Danjou]

[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]

On Sat, May 04 2013, Albert Krewinkel wrote:

Hi Albert,

> I tried to get sieve-manage working with my dovecot/pigeonhole server.
> It didn't quite work out of the box, so I made a few adjustments to the
> code.  The result is in my github-repo at
> git://github.com/tarleb/gnus.git (in the "sieve" branch).
>
> Most noticable changes:
>  - Added support for starttls
>  - Allowing multibyte-process buffers (couldn't get
>    string-parsing/encoding working without it)
>  - Slightly nicer looking code (IMHO of course)
>  - An ugly workaround which I intend to fix by the end of
>    next week.
>
> Any feedback on the code or advice on how to get this upstream would be
> highly appreciated.

This is on a my TODO for years, thanks for your awesome job.
I'd be happy to merge this upstream. Did you sign the FSF copyright
assignment yet? Considering the amount of patches, I think you'll need
that first.


-- 
Julien Danjou
/* Free Software hacker * freelance consultant
   http://julien.danjou.info */

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

Re: Updates to sieve-manage.el

[Albert Krewinkel]

[-- Attachment #1: Type: text/plain, Size: 755 bytes --]

Julien Danjou <julien@danjou.info> writes:

> On Sat, May 04 2013, Albert Krewinkel wrote:
>> [...] made a few adjustments to the code. [...]

> This is on a my TODO for years, thanks for your awesome job.

Thank you for the uplifting words; I'm glad I can give something back
to the awesomeness that is gnus and emacs.

> I'd be happy to merge this upstream. Did you sign the FSF copyright
> assignment yet? Considering the amount of patches, I think you'll need
> that first.

The patches by themself are rather small, I tried to make it easy to
follow my changes.  Totally forgot about the copyright-assignment, sent
out the email today.  I hope for the paperwork to be here soonish and
will let you know when the process is finished.

Cheers,

Albert

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]