From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/72125 Path: news.gmane.org!not-for-mail From: Dan Christensen Newsgroups: gmane.emacs.gnus.general Subject: Re: [PATCH] Introduce gnus-completing-read Date: Tue, 28 Sep 2010 11:55:36 -0400 Message-ID: <87vd5phngn.fsf@uwo.ca> References: <1285688153-19680-1-git-send-email-julien@danjou.info> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1285689360 8428 80.91.229.12 (28 Sep 2010 15:56:00 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 28 Sep 2010 15:56:00 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M20498@lists.math.uh.edu Tue Sep 28 17:55:58 2010 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P0cX4-0004eH-BO for ding-account@gmane.org; Tue, 28 Sep 2010 17:55:54 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1P0cX0-0003uo-SX; Tue, 28 Sep 2010 10:55:50 -0500 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1P0cWz-0003uX-2J for ding@lists.math.uh.edu; Tue, 28 Sep 2010 10:55:49 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtp (Exim 4.72) (envelope-from ) id 1P0cWy-0000K8-7s for ding@lists.math.uh.edu; Tue, 28 Sep 2010 10:55:48 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]) by quimby.gnus.org with esmtp (Exim 3.36 #1 (Debian)) id 1P0cWx-0000Nb-00 for ; Tue, 28 Sep 2010 17:55:47 +0200 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1P0cWu-0004ab-45 for ding@gnus.org; Tue, 28 Sep 2010 17:55:44 +0200 Original-Received: from bas3-london14-1096779890.dsl.bell.ca ([65.95.136.114]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 28 Sep 2010 17:55:44 +0200 Original-Received: from jdc by bas3-london14-1096779890.dsl.bell.ca with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 28 Sep 2010 17:55:44 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 27 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: bas3-london14-1096779890.dsl.bell.ca User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1.50 (gnu/linux) Cancel-Lock: sha1:I1+xHYq66qxzqcLRlOczDlLbu/g= X-Spam-Score: -0.4 (/) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:72125 Archived-At: Julien Danjou writes: > It adds `gnus-completion-styles' which set `completion-styles' when calling > `completing-read'. I haven't tried it, but noticed one minor thing: > diff --git a/lisp/gnus-agent.el b/lisp/gnus-agent.el > index 4788deb..1cb3637 100644 > --- a/lisp/gnus-agent.el > +++ b/lisp/gnus-agent.el > @@ -459,10 +459,7 @@ manipulated as follows: > (let ((def (or (gnus-group-group-name) gnus-newsgroup-name))) > (when def > (setq def (gnus-group-decoded-name def))) > - (gnus-group-completing-read (if def > - (concat "Group Name (" def "): ") > - "Group Name: ") > - nil nil t nil nil def))) > + (gnus-group-completing-read nil t nil nil def))) Should the new code have "Group Name" as the first argument? I also like the way you check completion-styles-alist to see if substring support is available. Dan