Re: [PATCH] Use replace-match in posting-style.

[Daniel Dehennin <daniel.dehennin@baby-gnu.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1827 bytes --]

Andreas Schwab <schwab@linux-m68k.org> writes:

>> => ((name . "Daniel Dehennin") (address . "foo@mydomain.com"))
>
> I find this pretty confusing.  I would have expected "foo@mydomain" as
> the address value (assuming it was "\\1@mydomain" originally).

Erf, I notices the replacement in the name but not the trailing ".com"
in the address.

The problem comes from the match, it should match the entire group like
this:

    (match "mydomain\\.\\(foo\\|bar\\).*")

I don't know if it's possible to replace the positionnal parameter
directly in the value, i.e. expanding the positional parameter in value
and not using it as a replacement against group.

For now we can limit the replacement to the matching part of the group:

  (let ((group "mydomain.foo.com")
        (match "mydomain\\.\\(foo\\|bar\\)")
        (values '((name "Daniel Dehennin")
                  (address "\\1@mydomain")))
        value element)
    (and (string-match match group)
         (mapcar (lambda (x)
                   (setq element (car x)
                         value (cadr x))
                   (cons element

                         (cond ((stringp value)
                                (if (and (stringp match)
                                         ;; The FIX
					 (string-match-p "\\\\[&[:digit:]]" value)
                                         (match-beginning 1))
                                    (replace-match value nil nil 
                                                   (substring group (match-beginning 0) (match-end 0)))
                                  value)))))
                 values)))

 => ((name . "Daniel Dehennin") (address . "foo@mydomain"))

Regards.
-- 
Daniel Dehennin
Récupérer ma clef GPG:
gpg --keyserver pgp.mit.edu --recv-keys 0x6A2540D1


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: Use replacement in posting-style --]
[-- Type: text/x-diff, Size: 546 bytes --]

=== modified file 'lisp/gnus-msg.el'
--- lisp/gnus-msg.el	2009-01-22 07:02:15 +0000
+++ lisp/gnus-msg.el	2010-04-11 14:02:03 +0000
@@ -1890,7 +1890,12 @@
 	    (setq v
 		  (cond
 		   ((stringp value)
-		    value)
+		    (if (and (stringp match)
+			     (string-match-p "\\\\[&[:digit:]]" value)
+			     (match-beginning 1))
+			(replace-match value nil nil 
+				       (substring group (match-beginning 0) (match-end 0)))
+		      value))
 		   ((or (symbolp value)
 			(functionp value))
 		    (cond ((functionp value)


[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]