From: Reiner Steib <reinersteib+gmane@imap.cc>
To: Dave Love <fx@gnu.org>
Cc: Simon Josefsson <simon@josefsson.org>, ding@gnus.org, bugs@gnus.org
Subject: Re: bogus function names in sieve-manage
Date: Tue, 23 Dec 2008 17:48:33 +0100 [thread overview]
Message-ID: <87vdtaltwe.fsf@marauder.physik.uni-ulm.de> (raw)
In-Reply-To: <8763la994h.fsf@liv.ac.uk> (Dave Love's message of "Tue, 23 Dec 2008 15:58:06 +0000")
On Tue, Dec 23 2008, Dave Love wrote:
> This looks like a simple cut-and-paste-o. sieve-manage definitely
> shouldn't be defining imap- functions.
Agreed. Installed. Does anyone see a problem with the change?
Are the functions necessary at all? I can't see anything using them.
Simon?
> 2008-12-23 Dave Love <fx@gnu.org>
>
> * sieve-manage.el (sieve-manage-starttls-p): Renamed from
> imap-starttls-p.
> (sieve-manage-starttls-open): Renamed from imap-starttls-open.
>
> Index: sieve-manage.el
> ===================================================================
> RCS file: /usr/local/cvsroot/gnus/lisp/sieve-manage.el,v
> retrieving revision 7.25
> diff -u -F^( -r7.25 sieve-manage.el
> --- sieve-manage.el 17 Sep 2008 11:06:34 -0000 7.25
> +++ sieve-manage.el 23 Dec 2008 15:54:34 -0000
> @@ -304,15 +298,14 @@ (defun sieve-manage-network-open (name b
> (when (memq (process-status process) '(open run))
> process))))
>
> -(defun imap-starttls-p (buffer)
> - ;; (and (imap-capability 'STARTTLS buffer)
> +(defun sieve-manage-starttls-p (buffer)
> (condition-case ()
> (progn
> (require 'starttls)
> (call-process "starttls"))
> (error nil)))
>
> -(defun imap-starttls-open (name buffer server port)
> +(defun sieve-manage-starttls-open (name buffer server port)
> (let* ((port (or port sieve-manage-default-port))
> (coding-system-for-read sieve-manage-coding-system-for-read)
> (coding-system-for-write sieve-manage-coding-system-for-write)
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
next parent reply other threads:[~2008-12-23 16:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8763la994h.fsf@liv.ac.uk>
2008-12-23 16:48 ` Reiner Steib [this message]
2008-12-29 21:13 ` Dave Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vdtaltwe.fsf@marauder.physik.uni-ulm.de \
--to=reinersteib+gmane@imap.cc \
--cc=Reiner.Steib@gmx.de \
--cc=bugs@gnus.org \
--cc=ding@gnus.org \
--cc=fx@gnu.org \
--cc=simon@josefsson.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).