* Re: bogus function names in sieve-manage
[not found] <8763la994h.fsf@liv.ac.uk>
@ 2008-12-23 16:48 ` Reiner Steib
2008-12-29 21:13 ` Dave Love
0 siblings, 1 reply; 2+ messages in thread
From: Reiner Steib @ 2008-12-23 16:48 UTC (permalink / raw)
To: Dave Love; +Cc: Simon Josefsson, ding, bugs
On Tue, Dec 23 2008, Dave Love wrote:
> This looks like a simple cut-and-paste-o. sieve-manage definitely
> shouldn't be defining imap- functions.
Agreed. Installed. Does anyone see a problem with the change?
Are the functions necessary at all? I can't see anything using them.
Simon?
> 2008-12-23 Dave Love <fx@gnu.org>
>
> * sieve-manage.el (sieve-manage-starttls-p): Renamed from
> imap-starttls-p.
> (sieve-manage-starttls-open): Renamed from imap-starttls-open.
>
> Index: sieve-manage.el
> ===================================================================
> RCS file: /usr/local/cvsroot/gnus/lisp/sieve-manage.el,v
> retrieving revision 7.25
> diff -u -F^( -r7.25 sieve-manage.el
> --- sieve-manage.el 17 Sep 2008 11:06:34 -0000 7.25
> +++ sieve-manage.el 23 Dec 2008 15:54:34 -0000
> @@ -304,15 +298,14 @@ (defun sieve-manage-network-open (name b
> (when (memq (process-status process) '(open run))
> process))))
>
> -(defun imap-starttls-p (buffer)
> - ;; (and (imap-capability 'STARTTLS buffer)
> +(defun sieve-manage-starttls-p (buffer)
> (condition-case ()
> (progn
> (require 'starttls)
> (call-process "starttls"))
> (error nil)))
>
> -(defun imap-starttls-open (name buffer server port)
> +(defun sieve-manage-starttls-open (name buffer server port)
> (let* ((port (or port sieve-manage-default-port))
> (coding-system-for-read sieve-manage-coding-system-for-read)
> (coding-system-for-write sieve-manage-coding-system-for-write)
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: bogus function names in sieve-manage
2008-12-23 16:48 ` bogus function names in sieve-manage Reiner Steib
@ 2008-12-29 21:13 ` Dave Love
0 siblings, 0 replies; 2+ messages in thread
From: Dave Love @ 2008-12-29 21:13 UTC (permalink / raw)
To: Simon Josefsson; +Cc: ding
Reiner Steib <reinersteib+gmane@imap.cc> writes:
> Are the functions necessary at all? I can't see anything using them.
> Simon?
`sieve-manage-open' can use them, can't it? (I don't know anything
about sieve-manage, though.)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-29 21:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <8763la994h.fsf@liv.ac.uk>
2008-12-23 16:48 ` bogus function names in sieve-manage Reiner Steib
2008-12-29 21:13 ` Dave Love
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).