From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/67972 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.gnus.general Subject: Re: bogus function names in sieve-manage Date: Tue, 23 Dec 2008 17:48:33 +0100 Message-ID: <87vdtaltwe.fsf@marauder.physik.uni-ulm.de> References: <8763la994h.fsf@liv.ac.uk> Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1230050945 17349 80.91.229.12 (23 Dec 2008 16:49:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 23 Dec 2008 16:49:05 +0000 (UTC) Cc: Simon Josefsson , ding@gnus.org, bugs@gnus.org To: Dave Love Original-X-From: ding-owner+M16418@lists.math.uh.edu Tue Dec 23 17:50:11 2008 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1LFASP-0008AW-Fv for ding-account@gmane.org; Tue, 23 Dec 2008 17:50:09 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1LFAR5-0008OR-Oq; Tue, 23 Dec 2008 10:48:47 -0600 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1LFAR4-0008O3-9s for ding@lists.math.uh.edu; Tue, 23 Dec 2008 10:48:46 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.69) (envelope-from ) id 1LFAR0-0002RJ-OL for ding@lists.math.uh.edu; Tue, 23 Dec 2008 10:48:45 -0600 Original-Received: from mail.uni-ulm.de ([134.60.1.11]) by quimby.gnus.org with esmtp (Exim 3.36 #1 (Debian)) id 1LFARE-0001Hf-00; Tue, 23 Dec 2008 17:48:56 +0100 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.10.175]) by mail.uni-ulm.de (8.14.2/8.14.2) with ESMTP id mBNGmclM027394; Tue, 23 Dec 2008 17:48:38 +0100 (MET) Original-Received: from localhost (localhost [127.0.0.1]) by bridgekeeper.physik.uni-ulm.de (Postfix) with ESMTP id 0C0601C921; Tue, 23 Dec 2008 17:48:38 +0100 (CET) X-Face: 'bg&jY[8V'W&:=~6w"|>}#4/T;w~36ei4NNMyKRR.a$n=$|sWFPF1y]a\>6kc\*#GN]UDM| Ywv,vbL^XF1nIp\:F=$Ei2o&mEe:%N~,:3]vtQ~s9u$9izmX$IF@VgGl7/,^dbuM<3|AO2}.%|%?kZ 2Y=@\U!~cll^=8Z9ihKq%wmUe1Ky(#kl3T'>Qk0Ia3mCBsTk?E(,X Mail-Followup-To: Dave Love , Simon Josefsson , ding@gnus.org In-Reply-To: <8763la994h.fsf@liv.ac.uk> (Dave Love's message of "Tue, 23 Dec 2008 15:58:06 +0000") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/22.1 (gnu/linux) X-DCC-CTc-dcc1-Metrics: poseidon 1030; Body=4 Fuz1=4 Fuz2=4 X-Virus-Scanned: by amavisd-new X-Spam-Score: -2.6 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:67972 Archived-At: On Tue, Dec 23 2008, Dave Love wrote: > This looks like a simple cut-and-paste-o. sieve-manage definitely > shouldn't be defining imap- functions. Agreed. Installed. Does anyone see a problem with the change? Are the functions necessary at all? I can't see anything using them. Simon? > 2008-12-23 Dave Love > > * sieve-manage.el (sieve-manage-starttls-p): Renamed from > imap-starttls-p. > (sieve-manage-starttls-open): Renamed from imap-starttls-open. > > Index: sieve-manage.el > =================================================================== > RCS file: /usr/local/cvsroot/gnus/lisp/sieve-manage.el,v > retrieving revision 7.25 > diff -u -F^( -r7.25 sieve-manage.el > --- sieve-manage.el 17 Sep 2008 11:06:34 -0000 7.25 > +++ sieve-manage.el 23 Dec 2008 15:54:34 -0000 > @@ -304,15 +298,14 @@ (defun sieve-manage-network-open (name b > (when (memq (process-status process) '(open run)) > process)))) > > -(defun imap-starttls-p (buffer) > - ;; (and (imap-capability 'STARTTLS buffer) > +(defun sieve-manage-starttls-p (buffer) > (condition-case () > (progn > (require 'starttls) > (call-process "starttls")) > (error nil))) > > -(defun imap-starttls-open (name buffer server port) > +(defun sieve-manage-starttls-open (name buffer server port) > (let* ((port (or port sieve-manage-default-port)) > (coding-system-for-read sieve-manage-coding-system-for-read) > (coding-system-for-write sieve-manage-coding-system-for-write) Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/