Re: Integration of nnmairix.el

[David <de_bb@arcor.de>]

[-- Attachment #1: Type: text/plain, Size: 1417 bytes --]

Reiner Steib <reinersteib+gmane@imap.cc> writes:
> Could you please send the current version of `nnmairix.el' to the list
> for review?  

It's attached to this mail.

> I didn't look into it in detail, but at least the
> following items need to be addressed:
>
> - Documentation.  Minimally the content from
>   <http://www.emacswiki.org/cgi-bin/wiki/GnusMairix> should be
>   converted to texinfo to fit into `texi/gnus.texi'.

OK, I'll do that.

> - Key bindings:
>
>   · Some of the summary mode bindings (`S ...') are already taken
>     (S t, S f, S m).  Or are these only active in nnmairix groups?

No. Since these are commands which create search commands based on the
current article they should work in every group. I somehow overlooked
that these bindings are already taken. 

>   · The Group mode prefix `G b' is available.  But maybe there's a
>     better one (I don't know).  Maybe we should arrange that the group
>     mode bindings are only done if the user wants to use nnmairix?

Yes, I guess that's reasonable since those bindings are useless without
a working mairix installation, so maybe users should have to explicitly
put (require 'nnmairix) into their .gnus for activating them.

> - Doc strings:
>
>   Some of the doc strings don't follow the Emacs conventions.  See
>   `M-x checkdoc RET'.
>
> - The defcustoms need a :version tag:
>   :version "23.0" ;; No Gnus

I fixed that.

-David


[-- Attachment #2: nnmairix.el --]
[-- Type: application/emacs-lisp, Size: 51105 bytes --]