Re: CRM114 Mailfilter and spam.el

[asjo@koldfront.dk (Adam Sjøgren)]

On 20 May 2004 14:39:25 -0400, Ted wrote:

> Adam, I comitted your patch, assuming your papers are on file (it's
> been a while since we discussed this).

Alas, they're not, yet. I've done almost nothing in elisp before, and
only sent an email to FSF a couple of days ago when Lars posted the
procedure publicly.

(I think the FSF is hiding how to do this quite aptly; I did go and
look for it at their website a while back without finding any
instructions. Maybe I was just being stupid.)

> The two spam.el hunks below didn't belong in the patch, I think, and
> I didn't consider them carefully so let me know if I should.

Please do consider them - or just say why you think they shouldn't go
in.

The first patch changes the behaviour as the comment change says -
instead of only moving ham articles out of spam-groups, it moves ham
articles out of non-ham-groups.

This makes sense in my setup, because I do not want to declare my
nnml:spam-group as spam (I do not want spam marked as expired
automatically), so I leave it as unclassified (so it's non-ham, but
not spam).

(Oh, the following call to gnus-message should be modified as well, to
reflect the change, if you deem it acceptable).

Would it break anyone elses setup?

When I mark an article as ham in an unclassified group, what would I
be trying to tell Gnus/spam.el if not "please move it to a/the
ham-group"?

(This is not a retorical question; I know people have very different
ideas of how they want to handle their mix of ham'n'spam.)

@@ -776,8 +838,8 @@
       (spam-ham-copy-routine
        (gnus-parameter-ham-process-destination gnus-newsgroup-name)))
 
-    ;; now move all ham articles out of spam groups
-    (when (spam-group-spam-contents-p gnus-newsgroup-name)
+    ;; now move all ham articles out of non-ham groups
+    (when (not (spam-group-ham-contents-p gnus-newsgroup-name))
       (gnus-message 5 "Moving ham messages from spam group")
       (spam-ham-move-routine
        (gnus-parameter-ham-process-destination gnus-newsgroup-name))))

spam.el doesn't work for me without the second, following, patch,
which I basically thought was a typo-correction; alas I'm only
starting to learn elisp, so I may very well be wrong.

@@ -859,7 +921,7 @@
 	 (gnus-check-backend-function
 	  'request-move-article gnus-newsgroup-name))
 	(respool-method (gnus-find-method-for-group gnus-newsgroup-name))
-	article mark todo deletep respool)
+	article mark deletep respool)
 
     (when (member 'respool groups)
       (setq respool t)			; boolean for later

> Also, I added a scoring function for CRM114 to spam-generic-score
> and fixed a few small problems.

Cool!


  Best regards,

-- 
 "Some people like cupcakes better.                           Adam Sjøgren
  I for one care less for them!"                         asjo@koldfront.dk