From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/57598 Path: main.gmane.org!not-for-mail From: asjo@koldfront.dk (=?iso-8859-1?q?Adam_Sj=F8gren?=) Newsgroups: gmane.emacs.gnus.general Subject: Re: CRM114 Mailfilter and spam.el Date: Thu, 20 May 2004 21:19:14 +0200 Organization: koldfront - analysis & revolution, Copenhagen, Denmark Sender: ding-owner@lists.math.uh.edu Message-ID: <87vfiq6h59.fsf@koldfront.dk> References: <87isgjpggh.fsf@virgil.koldfront.dk> <877jwwfwa6.fsf@virgil.koldfront.dk> <87ptangacp.fsf@virgil.koldfront.dk> <87brm4ss95.fsf@virgil.koldfront.dk> <4ny8nn0wpu.fsf@lifelogs.com> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1085081029 26365 80.91.224.253 (20 May 2004 19:23:49 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 20 May 2004 19:23:49 +0000 (UTC) Original-X-From: ding-owner+M6138@lists.math.uh.edu Thu May 20 21:23:38 2004 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BQt8k-0000ff-00 for ; Thu, 20 May 2004 21:23:38 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1BQt8b-0000ZT-00; Thu, 20 May 2004 14:23:29 -0500 Original-Received: from util2.math.uh.edu ([129.7.128.23]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1BQt4a-0000YJ-00 for ding@lists.math.uh.edu; Thu, 20 May 2004 14:19:20 -0500 Original-Received: from justine.libertine.org ([66.139.78.221] ident=postfix) by util2.math.uh.edu with esmtp (Exim 4.30) id 1BQt4Z-000277-K6 for ding@lists.math.uh.edu; Thu, 20 May 2004 14:19:19 -0500 Original-Received: from main.gmane.org (main.gmane.org [80.91.224.249]) by justine.libertine.org (Postfix) with ESMTP id B101A3A0035 for ; Thu, 20 May 2004 14:19:18 -0500 (CDT) Original-Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 1BQt4Y-0007Io-00 for ; Thu, 20 May 2004 21:19:18 +0200 Original-Received: from finn.gmane.org ([80.91.224.251]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 20 May 2004 21:19:18 +0200 Original-Received: from asjo by finn.gmane.org with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 20 May 2004 21:19:18 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-To: ding@gnus.org Original-Lines: 77 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: finn.gmane.org X-Face: &DfBw60^ZxI8hd?J%t&_8wW?SLF%BBx<2XQ+sXYpX!?{=0C?9D{Nc`;Eq<0d=-L User-Agent: Gnus/5.110003 (No Gnus v0.3) XEmacs/21.4 (Security Through Obscurity, linux) Cancel-Lock: sha1:UkNCNOgRckuL2vX/C+Vr3cZjuKY= Precedence: bulk Xref: main.gmane.org gmane.emacs.gnus.general:57598 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:57598 On 20 May 2004 14:39:25 -0400, Ted wrote: > Adam, I comitted your patch, assuming your papers are on file (it's > been a while since we discussed this). Alas, they're not, yet. I've done almost nothing in elisp before, and only sent an email to FSF a couple of days ago when Lars posted the procedure publicly. (I think the FSF is hiding how to do this quite aptly; I did go and look for it at their website a while back without finding any instructions. Maybe I was just being stupid.) > The two spam.el hunks below didn't belong in the patch, I think, and > I didn't consider them carefully so let me know if I should. Please do consider them - or just say why you think they shouldn't go in. The first patch changes the behaviour as the comment change says - instead of only moving ham articles out of spam-groups, it moves ham articles out of non-ham-groups. This makes sense in my setup, because I do not want to declare my nnml:spam-group as spam (I do not want spam marked as expired automatically), so I leave it as unclassified (so it's non-ham, but not spam). (Oh, the following call to gnus-message should be modified as well, to reflect the change, if you deem it acceptable). Would it break anyone elses setup? When I mark an article as ham in an unclassified group, what would I be trying to tell Gnus/spam.el if not "please move it to a/the ham-group"? (This is not a retorical question; I know people have very different ideas of how they want to handle their mix of ham'n'spam.) @@ -776,8 +838,8 @@ (spam-ham-copy-routine (gnus-parameter-ham-process-destination gnus-newsgroup-name))) =20 - ;; now move all ham articles out of spam groups - (when (spam-group-spam-contents-p gnus-newsgroup-name) + ;; now move all ham articles out of non-ham groups + (when (not (spam-group-ham-contents-p gnus-newsgroup-name)) (gnus-message 5 "Moving ham messages from spam group") (spam-ham-move-routine (gnus-parameter-ham-process-destination gnus-newsgroup-name)))) spam.el doesn't work for me without the second, following, patch, which I basically thought was a typo-correction; alas I'm only starting to learn elisp, so I may very well be wrong. @@ -859,7 +921,7 @@ (gnus-check-backend-function 'request-move-article gnus-newsgroup-name)) (respool-method (gnus-find-method-for-group gnus-newsgroup-name)) - article mark todo deletep respool) + article mark deletep respool) =20 (when (member 'respool groups) (setq respool t) ; boolean for later > Also, I added a scoring function for CRM114 to spam-generic-score > and fixed a few small problems. Cool! Best regards, --=20 "Some people like cupcakes better. Adam Sj=F8gren I for one care less for them!" asjo@koldfront.dk