Gnus development mailing list
 help / color / mirror / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: ding@gnus.org
Subject: Re: [PATCH 0/2] two minor fixes for new/empty nnimap group handling
Date: Mon, 06 Jul 2015 23:11:43 +0800	[thread overview]
Message-ID: <87wpydfhhs.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <76F67510-C040-48FB-8CBD-2391F8C1FFB1@mork.no>

Bjørn Mork <bjorn@mork.no> writes:

> On July 6, 2015 4:45:46 AM CEST, Eric Abrahamsen <eric@ericabrahamsen.net> wrote:
>>Bjørn Mork <bjorn@mork.no> writes:
>>
>>> The recent nnimap speedups introduced a couple of regressions wrt
>>> new and empty nnimap groups. This prevents Gnus from creating new
>>> IMAP groups.
>>>
>>> These two patches fix the problems for me, but are created in the
>>> way I usually do lisp: by mindless trial and error until emacs
>>> stops complaining. I.e., there might be much better ways to fix
>>> this...
>>>
>>> Anyway: Works For Me (tm)
>>>
>>>
>>> Bjørn Mork (2):
>>>   nnimap.el (nnimap-request-group): don't make nil into a list
>>>   nnimap.el (nnimap-request-group): group could be empty
>>>
>>>  lisp/nnimap.el | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>>Hi Bjørn,
>>
>>I'm guessing you only see this when you move a message from one group
>>into a non-existent group, and you're prompted to create the new group,
>>and it gives you an error. Is that right?
>>
>>The group actually is created, it just gives an error when it's
>>re-selected. That's because the move/copy process doesn't automatically
>>subscribe to the group and register it with Gnus: if you go into the
>>*Server* buffer and open the group list for the server in question,
>>you'll see the new group there, unsubscribed.
>
> Yes, that's the typical situation where I see this. I didn't realise that the group isn't immediately subscribed to.
>
> Btw, does this mean that copying to any unsubscribed group will fail,
> or am I misunderstanding? If not, then that doesn't seem right. I do
> have a couple of use cases where it makes sense to move or copy into
> groups which I'm not interested in subscribing to.

I wasn't quite clear about the difference between subscribed and
"registered". You can copy into unsubscribed groups without any trouble.
"Registered" is a term I made up just to say that Gnus knows about the
group and is keeping track of attributes for it -- this ought to be the
case no matter what. My proposed solution would both register the group,
and subscribe it. An alternative would be to register the group and
*not* subscribe it, but given that it's got to be one or the other, I'd
lean towards subscribing.

What do you think?

>>My feeling is that groups which are created as part of the article
>>move/copy process should be automatically subscribed to, and registered
>>with Gnus (ie entered into gnus-newsrc-hashtb). That would solve this
>>problem, and also seems like the Right Thing to Do.
>>
>>Does anyone have any opinions on this? I'll work up a patch, if not.
>
> Sounds perfect to me. Thanks
>
>
> Bjørn




  reply	other threads:[~2015-07-06 15:11 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-01 11:37 Bjørn Mork
2015-07-01 11:37 ` [PATCH 1/2] nnimap.el (nnimap-request-group): don't make nil into a list Bjørn Mork
2015-07-01 11:37 ` [PATCH 2/2] nnimap.el (nnimap-request-group): group could be empty Bjørn Mork
2015-07-01 11:50 ` [PATCH 0/2] two minor fixes for new/empty nnimap group handling Alan Schmitt
2015-07-01 12:23   ` Bjørn Mork
2015-07-01 13:49     ` Alan Schmitt
2015-07-02  2:18 ` Nikolaus Rath
2015-07-06  2:45 ` Eric Abrahamsen
2015-07-06  8:40   ` Bjørn Mork
2015-07-06 15:11     ` Eric Abrahamsen [this message]
2015-07-06 15:32 ` Dan Christensen
2015-07-07  2:48   ` Eric Abrahamsen
2015-07-07 23:12     ` Dan Christensen
2015-07-08  4:20       ` Eric Abrahamsen
2015-07-08 21:45         ` Dan Christensen
2015-07-09  1:53           ` Eric Abrahamsen
2015-07-09  2:52             ` Dan Christensen
2015-07-09 13:47               ` Dan Christensen
2015-07-10  2:41                 ` Eric Abrahamsen
2015-07-10 12:42                   ` Dan Christensen
2015-07-12  4:11               ` Eric Abrahamsen
2015-07-12  4:27                 ` Eric Abrahamsen
2015-07-12 17:01                   ` Dan Christensen
2015-07-13  5:36                     ` Eric Abrahamsen
2015-07-08 12:41       ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wpydfhhs.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).