Buildbot + registry errors

Buildbot + registry errors

[Lars Magne Ingebrigtsen]

Whenever somebody checks something in, they get a message about the
failed build, and it's because of:

---
Ran 6 tests, 5 results as expected, 1 unexpected (2011-04-24 21:19:54+0200)

1 unexpected results:
   FAILED  gnus-registry-usage-test
---

Ted, could you fix the test, or remove it?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Re: Buildbot + registry errors

[David Engster]

Lars Magne Ingebrigtsen writes:
> Whenever somebody checks something in, they get a message about the
> failed build,

It's going to the gnus-buildbot mailing list. I'd recommend to just read
it via Gmane, otherwise it will get annoying soon. You will only get a
mail directly if there's a *new* failing build and you are on the
'blamelist' (meaning you have committed since the last build).

-David

Re: Buildbot + registry errors

[Ted Zlatanov]

On Sun, 24 Apr 2011 21:29:47 +0200 Lars Magne Ingebrigtsen <larsi@gnus.org> wrote: 

LMI> Whenever somebody checks something in, they get a message about the
LMI> failed build

That seems like something BuildBot should not be doing.  It should CC
everyone involved since the LAST failure, not just the last committer.
But my problem was that I forgot to subscribe to the buildbot mailing
list.  "It's so quiet around here..."

LMI> and it's because of:

LMI> ---
LMI> Ran 6 tests, 5 results as expected, 1 unexpected (2011-04-24 21:19:54+0200)

LMI> 1 unexpected results:
LMI>    FAILED  gnus-registry-usage-test
LMI> ---

LMI> Ted, could you fix the test, or remove it?

It's a problem with `gnus-parameter-registry-ignore': it fails if the
*Group* (`gnus-group-buffer') buffer doesn't exist.  But this is a
problem deeper in Gnus.

I put a workaround for it, but I think `gnus-group-find-parameter'
should be fixed instead, see below (simply added a `when get-buffer'
around).  Do you agree?

Ted

diff --git a/lisp/gnus.el b/lisp/gnus.el
index c30eaba..f12d5f4 100644
--- a/lisp/gnus.el
+++ b/lisp/gnus.el
@@ -3873,13 +3873,14 @@ If SYMBOL, return the value of that symbol in the group parameters.
 
 If you call this function inside a loop, consider using the faster
 `gnus-group-fast-parameter' instead."
-  (with-current-buffer gnus-group-buffer
-    (if symbol
-	(gnus-group-fast-parameter group symbol allow-list)
-      (nconc
-       (copy-sequence
-	(funcall gnus-group-get-parameter-function group))
-       (gnus-parameters-get-parameter group)))))
+  (when (get-buffer gnus-group-buffer)
+    (with-current-buffer gnus-group-buffer
+      (if symbol
+          (gnus-group-fast-parameter group symbol allow-list)
+        (nconc
+         (copy-sequence
+          (funcall gnus-group-get-parameter-function group))
+         (gnus-parameters-get-parameter group))))))
 
 (defun gnus-group-get-parameter (group &optional symbol allow-list)
   "Return the group parameters for GROUP.

Re: Buildbot + registry errors

[David Engster]

Ted Zlatanov writes:
> On Sun, 24 Apr 2011 21:29:47 +0200 Lars Magne Ingebrigtsen <larsi@gnus.org> wrote: 
>
> LMI> Whenever somebody checks something in, they get a message about the
> LMI> failed build
>
> That seems like something BuildBot should not be doing.  It should CC
> everyone involved since the LAST failure, not just the last committer.

Here's the current (since Apr 21st) setup:

- The buildbot checks the git repo about 10x per hour.

- If it finds a new HEAD, it pulls and runs the builders.

- If a build was OK previously but now fails, it will send a mail
  - to the buildbot mailinglist
  - to every committer who was part in generating the new HEAD (the so
    called "blamelist").

- If a build failed again (meaning it also failed in the previous
  build), a mail will *only* be sent to the buildbot mailinglist.

> But my problem was that I forgot to subscribe to the buildbot mailing
> list.  "It's so quiet around here..."

The buildbot did send a mails directly to you when the build initially
broke:

2011-04-20 23:11:13 1QCeQL-0001Jb-JT => tzz@lifelogs.com ...
2011-04-20 23:11:13 1QCeQL-0001Jb-JT Completed
2011-04-20 23:11:14 1QCeRS-0001ZZ-FM => tzz@lifelogs.com ...
2011-04-20 23:11:14 1QCeRS-0001ZZ-FM Completed

Didn't those came through? The domain has proper DKIM signing, SPF and
all that.

-David

Re: Buildbot + registry errors

[Ted Zlatanov]

On Mon, 25 Apr 2011 10:04:06 +0200 David Engster <deng@randomsample.de> wrote: 

DE> Here's the current (since Apr 21st) setup:

DE> - The buildbot checks the git repo about 10x per hour.

DE> - If it finds a new HEAD, it pulls and runs the builders.

DE> - If a build was OK previously but now fails, it will send a mail
DE>   - to the buildbot mailinglist
DE>   - to every committer who was part in generating the new HEAD (the so
DE>     called "blamelist").

DE> - If a build failed again (meaning it also failed in the previous
DE>   build), a mail will *only* be sent to the buildbot mailinglist.

This is great, exactly what we need.  I thought it might be sending
alerts unnecessarily, but I shouldn't have doubted ;)

>> But my problem was that I forgot to subscribe to the buildbot mailing
>> list.  "It's so quiet around here..."

DE> The buildbot did send a mails directly to you when the build initially
DE> broke:

DE> 2011-04-20 23:11:13 1QCeQL-0001Jb-JT => tzz@lifelogs.com ...
DE> 2011-04-20 23:11:13 1QCeQL-0001Jb-JT Completed
DE> 2011-04-20 23:11:14 1QCeRS-0001ZZ-FM => tzz@lifelogs.com ...
DE> 2011-04-20 23:11:14 1QCeRS-0001ZZ-FM Completed

DE> Didn't those came through? The domain has proper DKIM signing, SPF and
DE> all that.

They did, I put them on my TODO list, then life interfered as usual and
I forgot all about it.  The mighty BuildBot did nothing wrong.

Ted