Secrets API "login" session is now "Login"?

Secrets API "login" session is now "Login"?

[Ted Zlatanov]

This morning I noticed that while seahorse told me the login collection
was "login", the Secrets API listed it as "Login".  I'm 100% sure that
it used to be "login".

I've adjusted auth-source.el and auth.texi accordingly.  If that's
wrong, please let me know.

Ted

Re: Secrets API "login" session is now "Login"?

[Michael Albinus]

Ted Zlatanov <tzz@lifelogs.com> writes:

> This morning I noticed that while seahorse told me the login collection
> was "login", the Secrets API listed it as "Login".  I'm 100% sure that
> it used to be "login".
>
> I've adjusted auth-source.el and auth.texi accordingly.  If that's
> wrong, please let me know.

The Secret Service API does not speak about the "login" collection. The
only promise it gives is the "default" alias:

"Client applications without special requirements should store in the
 default collection. The default collection is always accessible through
 a specific object path."

> Ted

Best regards, Michael.

Re: Secrets API "login" session is now "Login"?

[Ted Zlatanov]

On Mon, 14 Feb 2011 16:39:49 +0100 Michael Albinus <michael.albinus@gmx.de> wrote: 

MA> Ted Zlatanov <tzz@lifelogs.com> writes:
>> This morning I noticed that while seahorse told me the login collection
>> was "login", the Secrets API listed it as "Login".  I'm 100% sure that
>> it used to be "login".
>> 
>> I've adjusted auth-source.el and auth.texi accordingly.  If that's
>> wrong, please let me know.

MA> The Secret Service API does not speak about the "login" collection. The
MA> only promise it gives is the "default" alias:

MA> "Client applications without special requirements should store in the
MA>  default collection. The default collection is always accessible through
MA>  a specific object path."

OK, but I see "login" in Seahorse and "Login" from secrets.el.  There's
some disagreement happening.  Do you see that or is it just me (recent
Ubuntu system, dist-upgraded 2 weeks ago and updated regularly)?

Ted

Re: Secrets API "login" session is now "Login"?

[Michael Albinus]

Ted Zlatanov <tzz@lifelogs.com> writes:

> On Mon, 14 Feb 2011 16:39:49 +0100 Michael Albinus
> <michael.albinus@gmx.de> wrote:
>
> MA> Ted Zlatanov <tzz@lifelogs.com> writes:
>>> This morning I noticed that while seahorse told me the login collection
>>> was "login", the Secrets API listed it as "Login".  I'm 100% sure that
>>> it used to be "login".
>>> 
>>> I've adjusted auth-source.el and auth.texi accordingly.  If that's
>>> wrong, please let me know.
>
> MA> The Secret Service API does not speak about the "login" collection. The
> MA> only promise it gives is the "default" alias:
>
> MA> "Client applications without special requirements should store in the
> MA>  default collection. The default collection is always accessible through
> MA>  a specific object path."
>
> OK, but I see "login" in Seahorse and "Login" from secrets.el.  There's
> some disagreement happening.  Do you see that or is it just me (recent
> Ubuntu system, dist-upgraded 2 weeks ago and updated regularly)?

I'm running an up-to-date Ubuntu 10.10. In secrets.el, I see

   (secrets-get-alias "default")
    => "login"

Maybe you have changed the default alias via `secrets-set-alias'?

Anyway, I recommend to use the collection returned by (secrets-get-alias
"default"). There's is no need to hardwire it as "login".

> Ted

Best regards, Michael.

Re: Secrets API "login" session is now "Login"?

[Ted Zlatanov]

On Mon, 14 Feb 2011 21:36:55 +0100 Michael Albinus <michael.albinus@gmx.de> wrote: 

MA> Ted Zlatanov <tzz@lifelogs.com> writes:
>> On Mon, 14 Feb 2011 16:39:49 +0100 Michael Albinus
>> <michael.albinus@gmx.de> wrote:
>> 
MA> Ted Zlatanov <tzz@lifelogs.com> writes:
>>>> This morning I noticed that while seahorse told me the login collection
>>>> was "login", the Secrets API listed it as "Login".  I'm 100% sure that
>>>> it used to be "login".
>>>> 
>>>> I've adjusted auth-source.el and auth.texi accordingly.  If that's
>>>> wrong, please let me know.
>> 
MA> The Secret Service API does not speak about the "login" collection. The
MA> only promise it gives is the "default" alias:
>> 
MA> "Client applications without special requirements should store in the
MA> default collection. The default collection is always accessible through
MA> a specific object path."
>> 
>> OK, but I see "login" in Seahorse and "Login" from secrets.el.  There's
>> some disagreement happening.  Do you see that or is it just me (recent
>> Ubuntu system, dist-upgraded 2 weeks ago and updated regularly)?

MA> I'm running an up-to-date Ubuntu 10.10. In secrets.el, I see

MA>    (secrets-get-alias "default")
MA>     => "login"

MA> Maybe you have changed the default alias via `secrets-set-alias'?

No, I'm sure.

(secrets-get-alias "default")
=> nil

(secrets-list-collections)
=> ("session" "Login")

MA> Anyway, I recommend to use the collection returned by (secrets-get-alias
MA> "default"). There's is no need to hardwire it as "login".

We use "Login" in many of the examples.  I wanted a collection that may
actually have entries from other programs.  It's just puzzling that
"login" worked until recently and seahorse still says "login".

Ted

Re: Secrets API "login" session is now "Login"?

[Michael Albinus]

Ted Zlatanov <tzz@lifelogs.com> writes:

> MA> I'm running an up-to-date Ubuntu 10.10. In secrets.el, I see
>
> MA>    (secrets-get-alias "default")
> MA>     => "login"
>
> MA> Maybe you have changed the default alias via `secrets-set-alias'?
>
> No, I'm sure.
>
> (secrets-get-alias "default")
> => nil
>
> (secrets-list-collections)
> => ("session" "Login")

What do you get with (secrets-get-collections) ?

> MA> Anyway, I recommend to use the collection returned by (secrets-get-alias
> MA> "default"). There's is no need to hardwire it as "login".
>
> We use "Login" in many of the examples.  I wanted a collection that may
> actually have entries from other programs.  It's just puzzling that
> "login" worked until recently and seahorse still says "login".

Do you have another gnome-keyring incarnation running? Is there another
ofd.secrets service running, like kwallet? Are seahorse and Emacs using
the same D-Bus session bus?

Maybe you trace D-Bus messages with dbus-monitor, in both cases (opening
seahorse, using secrets.el).

> Ted

Best regards, Michael.

Re: Secrets API "login" session is now "Login"?

[Ted Zlatanov]

On Mon, 14 Feb 2011 22:11:13 +0100 Michael Albinus <michael.albinus@gmx.de> wrote: 

MA> Ted Zlatanov <tzz@lifelogs.com> writes:
MA> I'm running an up-to-date Ubuntu 10.10. In secrets.el, I see
>> 
MA> (secrets-get-alias "default")
MA> => "login"
>> 
MA> Maybe you have changed the default alias via `secrets-set-alias'?
>> 
>> No, I'm sure.
>> 
>> (secrets-get-alias "default")
>> => nil
>> 
>> (secrets-list-collections)
>> => ("session" "Login")

MA> What do you get with (secrets-get-collections) ?

=> ("/org/freedesktop/secrets/collection/session" "/org/freedesktop/secrets/collection/login")

>> We use "Login" in many of the examples.  I wanted a collection that may
>> actually have entries from other programs.  It's just puzzling that
>> "login" worked until recently and seahorse still says "login".

MA> Do you have another gnome-keyring incarnation running? Is there another
MA> ofd.secrets service running, like kwallet? Are seahorse and Emacs using
MA> the same D-Bus session bus?

MA> Maybe you trace D-Bus messages with dbus-monitor, in both cases (opening
MA> seahorse, using secrets.el).

dbus-monitor says that for seahorse, the paths are like 
"path=/org/freedesktop/secrets/collection/login/5"

For secrets.el, (secrets-get-collections) produces:

signal sender=org.freedesktop.DBus -> dest=:1.196 serial=2 path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=NameAcquired
   string ":1.196"
method call sender=:1.196 -> dest=org.freedesktop.DBus serial=3 path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=AddMatch
   string "type='method_call'"
method call sender=:1.196 -> dest=org.freedesktop.DBus serial=4 path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=AddMatch
   string "type='method_return'"
method call sender=:1.196 -> dest=org.freedesktop.DBus serial=5 path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=AddMatch
   string "type='error'"

but then (secrets-list-collections) produces:

method call sender=:1.191 -> dest=org.freedesktop.secrets serial=17 path=/org/freedesktop/secrets/collection/login; interface=org.freedesktop.DBus.Properties; member=Get
   string "org.freedesktop.Secret.Collection"
   string "Label"
method return sender=:1.5 -> dest=:1.191 reply_serial=17
   variant       string "Login"

so the label for that collection is "Login"?  I guess seahorse doesn't
show the collection label, only the basename.

Ted

Re: Secrets API "login" session is now "Login"?

[Michael Albinus]

Michael Albinus <michael.albinus@gmx.de> writes:

>> No, I'm sure.
>>
>> (secrets-get-alias "default")
>> => nil
>>
>> (secrets-list-collections)
>> => ("session" "Login")
>
> What do you get with (secrets-get-collections) ?

And what's the contents of "~/.gnome2/keyrings"? I have

  -rw-r--r--  1 albinus albinus    5 2010-03-13 19:47 default
  -rw-------  1 albinus albinus 2809 2011-01-09 09:47 login.keyring
  -rw-------  1 albinus albinus  113 2010-10-06 19:53 my_collection.keyring
  -rw-------  1 albinus albinus  207 2010-04-11 21:10 user.keystore

>> Ted

Best regards, Michael.

Re: Secrets API "login" session is now "Login"?

[Ted Zlatanov]

On Mon, 14 Feb 2011 22:46:33 +0100 Michael Albinus <michael.albinus@gmx.de> wrote: 

MA> Michael Albinus <michael.albinus@gmx.de> writes:
>>> No, I'm sure.
>>> 
>>> (secrets-get-alias "default")
>>> => nil
>>> 
>>> (secrets-list-collections)
>>> => ("session" "Login")
>> 
>> What do you get with (secrets-get-collections) ?

MA> And what's the contents of "~/.gnome2/keyrings"? I have

MA>   -rw-r--r--  1 albinus albinus    5 2010-03-13 19:47 default
MA>   -rw-------  1 albinus albinus 2809 2011-01-09 09:47 login.keyring
MA>   -rw-------  1 albinus albinus  113 2010-10-06 19:53 my_collection.keyring
MA>   -rw-------  1 albinus albinus  207 2010-04-11 21:10 user.keystore

It shows login.keyring (I don't have a default):

total 48
-rw------- 1 tzz tzz 42875 2011-02-08 11:51 login.keyring
-rw------- 1 tzz tzz   207 2010-06-03 16:13 user.keystore
-rw------- 1 tzz tzz     0 2010-06-04 08:32 user.keystore.B9GXDV
-rw------- 1 tzz tzz     0 2010-06-03 16:26 user.keystore.ZRNHDV

So it seems that "Login" is a purely decorative label.

Ted

Re: Secrets API "login" session is now "Login"?

[Michael Albinus]

Ted Zlatanov <tzz@lifelogs.com> writes:

> method call sender=:1.191 -> dest=org.freedesktop.secrets serial=17
> path=/org/freedesktop/secrets/collection/login;
> interface=org.freedesktop.DBus.Properties; member=Get
>    string "org.freedesktop.Secret.Collection"
>    string "Label"
> method return sender=:1.5 -> dest=:1.191 reply_serial=17
>    variant       string "Login"
>
> so the label for that collection is "Login"?  I guess seahorse doesn't
> show the collection label, only the basename.

Maybe. secrets.el shows always the collection label. This can change,
that's why I insist on the "default" alias :-)

> Ted

Best regards, Michael.

Re: Secrets API "login" session is now "Login"?

[Michael Albinus]

Michael Albinus <michael.albinus@gmx.de> writes:

> Ted Zlatanov <tzz@lifelogs.com> writes:
>
>> method call sender=:1.191 -> dest=org.freedesktop.secrets serial=17
>> path=/org/freedesktop/secrets/collection/login;
>> interface=org.freedesktop.DBus.Properties; member=Get
>>    string "org.freedesktop.Secret.Collection"
>>    string "Label"
>> method return sender=:1.5 -> dest=:1.191 reply_serial=17
>>    variant       string "Login"
>>
>> so the label for that collection is "Login"?  I guess seahorse doesn't
>> show the collection label, only the basename.
>
> Maybe. secrets.el shows always the collection label. This can change,
> that's why I insist on the "default" alias :-)

I just did an experiment:

  (secrets-create-collection "ABC")
  => "/org/freedesktop/secrets/collection/abc"

gnome-keyring seems to normalize the object path, using small letters
only. And seahorse shows it as "abc".

Hmm. Shall I do something similar in secrets.el?

>> Ted

Best regards, Michael.

Re: Secrets API "login" session is now "Login"?

[Michael Albinus]

Ted Zlatanov <tzz@lifelogs.com> writes:

> It shows login.keyring (I don't have a default):
>
> total 48
> -rw------- 1 tzz tzz 42875 2011-02-08 11:51 login.keyring
> -rw------- 1 tzz tzz   207 2010-06-03 16:13 user.keystore
> -rw------- 1 tzz tzz     0 2010-06-04 08:32 user.keystore.B9GXDV
> -rw------- 1 tzz tzz     0 2010-06-03 16:26 user.keystore.ZRNHDV
>
> So it seems that "Login" is a purely decorative label.

Yes, secrets.el uses the "Label" attribute for showing collection names.

And you should have a default alias (you can set it in seahorse, for
example).

> Ted

Best regards, Michael.

Re: Secrets API "login" session is now "Login"?

[Ted Zlatanov]

On Mon, 14 Feb 2011 22:58:21 +0100 Michael Albinus <michael.albinus@gmx.de> wrote: 

MA> Michael Albinus <michael.albinus@gmx.de> writes:
MA> I just did an experiment:

MA>   (secrets-create-collection "ABC")
MA>   => "/org/freedesktop/secrets/collection/abc"

MA> gnome-keyring seems to normalize the object path, using small letters
MA> only. And seahorse shows it as "abc".

MA> Hmm. Shall I do something similar in secrets.el?
...
MA> Yes, secrets.el uses the "Label" attribute for showing collection names.

Nah.  I think it's fine as it is now, using the "Label" attribute.

MA> And you should have a default alias (you can set it in seahorse, for
MA> example).

No!  I'm a rebel! :)

Ted

Re: Secrets API "login" session is now "Login"?

[Michael Albinus]

Ted Zlatanov <tzz@lifelogs.com> writes:

> MA> Hmm. Shall I do something similar in secrets.el?
> ...
> MA> Yes, secrets.el uses the "Label" attribute for showing collection names.
>
> Nah.  I think it's fine as it is now, using the "Label" attribute.

Btw, "M-x secrets-show-secrets" shows the collections with their
"Label". And it let you explore the collections interactively.

> MA> And you should have a default alias (you can set it in seahorse, for
> MA> example).
>
> No!  I'm a rebel! :)

:-)

> Ted

Best regards, Michael.

Re: Secrets API "login" session is now "Login"?

[Ted Zlatanov]

On Mon, 14 Feb 2011 23:20:04 +0100 Michael Albinus <michael.albinus@gmx.de> wrote: 

MA> Ted Zlatanov <tzz@lifelogs.com> writes:
MA> Hmm. Shall I do something similar in secrets.el?
>> ...
MA> Yes, secrets.el uses the "Label" attribute for showing collection names.
>> 
>> Nah.  I think it's fine as it is now, using the "Label" attribute.

MA> Btw, "M-x secrets-show-secrets" shows the collections with their
MA> "Label". And it let you explore the collections interactively.

That's a nice interface, but according to the docstring I should be able
to expand the items' attributes.  That part doesn't work (I tried RET on
the widget and the text).  Otherwise it's very useful.

Ted

Re: Secrets API "login" session is now "Login"?

[Michael Albinus]

Ted Zlatanov <tzz@lifelogs.com> writes:

> That's a nice interface, but according to the docstring I should be able
> to expand the items' attributes.  That part doesn't work (I tried RET on
> the widget and the text).  Otherwise it's very useful.

The docstring says "... they can be expanded to the corresponding secret
items, which could also be expanded to their attributes."

Obviously my English is too bad, but "to their attributes" should say
that also the attributes are shown. It does not mean that the attributes
do expand themselves (there is nothing to expand but the password).

Do you have a better wording?

> Ted

Best regards, Michael.

Re: Secrets API "login" session is now "Login"?

[Ted Zlatanov]

On Tue, 15 Feb 2011 15:09:03 +0100 Michael Albinus <michael.albinus@gmx.de> wrote: 

MA> Ted Zlatanov <tzz@lifelogs.com> writes:
>> That's a nice interface, but according to the docstring I should be able
>> to expand the items' attributes.  That part doesn't work (I tried RET on
>> the widget and the text).  Otherwise it's very useful.

MA> The docstring says "... they can be expanded to the corresponding secret
MA> items, which could also be expanded to their attributes."

MA> Obviously my English is too bad, but "to their attributes" should say
MA> that also the attributes are shown. It does not mean that the attributes
MA> do expand themselves (there is nothing to expand but the password).

I mean I can't see the attributes.  For example I see the Login collection:

[-] Login
 |-[+] Desktop Couch user authentication

but if I hit RET on the second line (Desktop Couch user authentication)
I get an error that the line is read-only.  Seahorse shows the
attributes.  Maybe it's connected to the Login/login issue.

Ted

Re: Secrets API "login" session is now "Login"?

[Michael Albinus]

Ted Zlatanov <tzz@lifelogs.com> writes:

> I mean I can't see the attributes.  For example I see the Login collection:
>
> [-] Login
>  |-[+] Desktop Couch user authentication
>
> but if I hit RET on the second line (Desktop Couch user authentication)
> I get an error that the line is read-only.  Seahorse shows the
> attributes.  Maybe it's connected to the Login/login issue.

Works for me. However, sometimes in the past I have had the same effect
(don't know how to trigger it). It helped to log out / log in; a fresh
Gnome Keyring did cooperate then.

Maybe it's a bug to be hunted in secrets.el.

> Ted

Best regards, Michael.