* [ding-cvslog-owner@lists.math.uh.edu] Stalled post to ding-cvslog
@ 2010-11-09 10:55 Sven Joachim
2010-11-09 17:53 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 11+ messages in thread
From: Sven Joachim @ 2010-11-09 10:55 UTC (permalink / raw)
To: ding
[-- Attachment #1: Type: text/plain, Size: 234 bytes --]
Hi,
would it be possible to modify the post-receive hook script so that it
uses the committer rather than the author in the "From:" header? That
would have prevented the following annoying moderation message.
Cheers,
Sven
[-- Attachment #2: Type: message/rfc822, Size: 4857 bytes --]
[-- Attachment #2.1.1: Type: text/plain, Size: 382 bytes --]
Your message to ding-cvslog has been delayed, and requires the approval
of the moderators, for the following reason(s):
New posters must be approved once.
This list is restricted to CVS commit messages.
If you do not wish the message to be posted, or have other concerns,
please send a message to the list owners at the following address:
ding-cvslog-owner@lists.math.uh.edu
[-- Attachment #2.1.2: Original message --]
[-- Type: message/rfc822, Size: 3349 bytes --]
From: Sven Joachim <svenjoac@gmx.de>
To: cvslog@quimby.gnus.org,ding-commits@quimby.gnus.org,tzz@lifelogs.com
Subject: [gnus git] branch master updated: =1= message.el (message-subject-trailing-was-ask-regexp, message-subject-trailing-was-regexp): Match was: in addition to was.
Date: Tue, 09 Nov 2010 11:27:57 +0100
Message-ID: <E1PFlQj-0005qP-00@quimby.gnus.org>
via 00cd64463c5cf16d6aa0611c7957cfe94e6d5b0d (commit)
from 40002f6b5bd2ef9c98754ebaed9e05a41c5829fc (commit)
- Log -----------------------------------------------------------------
commit 00cd64463c5cf16d6aa0611c7957cfe94e6d5b0d
Author: Sven Joachim <svenjoac@gmx.de>
Date: Tue Nov 9 10:27:47 2010 +0000
message.el (message-subject-trailing-was-ask-regexp, message-subject-trailing-was-regexp): Match was: in addition to was.
diff --git a/lisp/message.el b/lisp/message.el
index 035ba1c..3dd4464 100644
--- a/lisp/message.el
+++ b/lisp/message.el
@@ -326,7 +326,7 @@ used."
:group 'message-various)
(defcustom message-subject-trailing-was-ask-regexp
- "[ \t]*\\([[(]+[Ww][Aa][Ss][ \t]*.*[\])]+\\)"
+ "[ \t]*\\([[(]+[Ww][Aa][Ss]:?[ \t]*.*[\])]+\\)"
"*Regexp matching \"(was: <old subject>)\" in the subject line.
The function `message-strip-subject-trailing-was' uses this regexp if
@@ -335,13 +335,13 @@ the variable is t instead of `ask', use
`message-subject-trailing-was-regexp' instead.
It is okay to create some false positives here, as the user is asked."
- :version "22.1"
+ :version "24.1"
:group 'message-various
:link '(custom-manual "(message)Message Headers")
:type 'regexp)
(defcustom message-subject-trailing-was-regexp
- "[ \t]*\\((*[Ww][Aa][Ss][ \t]*.*)\\)"
+ "[ \t]*\\((*[Ww][Aa][Ss]:?[ \t]*.*)\\)"
"*Regexp matching \"(was: <old subject>)\" in the subject line.
If `message-subject-trailing-was-query' is set to t, the subject is
-----------------------------------------------------------------------
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we listed those
revisions in full, above.
Summary of changes:
lisp/message.el | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnus Project".
The branch, master has been updated
hooks/post-receive
--
Gnus Project
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [ding-cvslog-owner@lists.math.uh.edu] Stalled post to ding-cvslog
2010-11-09 10:55 [ding-cvslog-owner@lists.math.uh.edu] Stalled post to ding-cvslog Sven Joachim
@ 2010-11-09 17:53 ` Lars Magne Ingebrigtsen
2010-11-09 18:54 ` Julien Danjou
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Lars Magne Ingebrigtsen @ 2010-11-09 17:53 UTC (permalink / raw)
To: ding
Sven Joachim <svenjoac@gmx.de> writes:
> would it be possible to modify the post-receive hook script so that it
> uses the committer rather than the author in the "From:" header? That
> would have prevented the following annoying moderation message.
[...]
> From: Sven Joachim <svenjoac@gmx.de>
[...]
> Author: Sven Joachim <svenjoac@gmx.de>
If there's a difference here, it must be subtle...
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [ding-cvslog-owner@lists.math.uh.edu] Stalled post to ding-cvslog
2010-11-09 17:53 ` Lars Magne Ingebrigtsen
@ 2010-11-09 18:54 ` Julien Danjou
2010-11-09 19:08 ` Lars Magne Ingebrigtsen
2010-11-09 19:01 ` Adam Sjøgren
2010-11-09 19:09 ` Sven Joachim
2 siblings, 1 reply; 11+ messages in thread
From: Julien Danjou @ 2010-11-09 18:54 UTC (permalink / raw)
To: ding
On Tue, Nov 09 2010, Lars Magne Ingebrigtsen wrote:
> If there's a difference here, it must be subtle...
There's one:
% git show --pretty=full 00cd64463c5cf16d6aa0611c7957cfe94e6d5b0d | head -3
commit 00cd64463c5cf16d6aa0611c7957cfe94e6d5b0d
Author: Sven Joachim <svenjoac@gmx.de>
Commit: Katsumi Yamaoka <yamaoka@jpl.org>
--
Julien Danjou
// ᐰ <julien@danjou.info> http://julien.danjou.info
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [ding-cvslog-owner@lists.math.uh.edu] Stalled post to ding-cvslog
2010-11-09 18:54 ` Julien Danjou
@ 2010-11-09 19:08 ` Lars Magne Ingebrigtsen
2010-11-09 19:28 ` Sven Joachim
0 siblings, 1 reply; 11+ messages in thread
From: Lars Magne Ingebrigtsen @ 2010-11-09 19:08 UTC (permalink / raw)
To: ding
Julien Danjou <julien@danjou.info> writes:
> There's one:
>
> % git show --pretty=full 00cd64463c5cf16d6aa0611c7957cfe94e6d5b0d | head -3
> commit 00cd64463c5cf16d6aa0611c7957cfe94e6d5b0d
> Author: Sven Joachim <svenjoac@gmx.de>
> Commit: Katsumi Yamaoka <yamaoka@jpl.org>
Right. But the Commit line wasn't even in the mail, which makes it
rather difficult for the mailing list software to use that. :-)
--
(domestic pets only, the antidote for overdose, milk.)
larsi@gnus.org * Lars Magne Ingebrigtsen
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [ding-cvslog-owner@lists.math.uh.edu] Stalled post to ding-cvslog
2010-11-09 19:08 ` Lars Magne Ingebrigtsen
@ 2010-11-09 19:28 ` Sven Joachim
2010-11-09 21:34 ` James Cloos
2010-11-09 21:52 ` Ted Zlatanov
0 siblings, 2 replies; 11+ messages in thread
From: Sven Joachim @ 2010-11-09 19:28 UTC (permalink / raw)
To: ding
On 2010-11-09 20:08 +0100, Lars Magne Ingebrigtsen wrote:
> Julien Danjou <julien@danjou.info> writes:
>
>> There's one:
>>
>> % git show --pretty=full 00cd64463c5cf16d6aa0611c7957cfe94e6d5b0d | head -3
>> commit 00cd64463c5cf16d6aa0611c7957cfe94e6d5b0d
>> Author: Sven Joachim <svenjoac@gmx.de>
>> Commit: Katsumi Yamaoka <yamaoka@jpl.org>
>
> Right. But the Commit line wasn't even in the mail, which makes it
> rather difficult for the mailing list software to use that. :-)
Correct, that's why I proposed to change the post-receive script (which
writes and sends the mail) so that it uses the "Commit:" address for
constructing the "From:" field in the mail. Sorry if that was unclear.
Sven
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [ding-cvslog-owner@lists.math.uh.edu] Stalled post to ding-cvslog
2010-11-09 19:28 ` Sven Joachim
@ 2010-11-09 21:34 ` James Cloos
2010-11-09 21:52 ` Ted Zlatanov
1 sibling, 0 replies; 11+ messages in thread
From: James Cloos @ 2010-11-09 21:34 UTC (permalink / raw)
To: ding
>>>>> "SJ" == Sven Joachim <svenjoac@gmx.de> writes:
SJ> I proposed to change the post-receive script (which writes and sends
SJ> the mail) so that it uses the "Commit:" address for constructing the
SJ> "From:" field in the mail.
Which (what he proposes, that is) is the typical practice, FWIW.
-JimC
--
James Cloos <cloos@jhcloos.com> OpenPGP: 1024D/ED7DAEA6
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [ding-cvslog-owner@lists.math.uh.edu] Stalled post to ding-cvslog
2010-11-09 19:28 ` Sven Joachim
2010-11-09 21:34 ` James Cloos
@ 2010-11-09 21:52 ` Ted Zlatanov
2010-11-10 7:46 ` Sven Joachim
1 sibling, 1 reply; 11+ messages in thread
From: Ted Zlatanov @ 2010-11-09 21:52 UTC (permalink / raw)
To: ding
On Tue, 09 Nov 2010 20:28:49 +0100 Sven Joachim <svenjoac@gmx.de> wrote:
SJ> On 2010-11-09 20:08 +0100, Lars Magne Ingebrigtsen wrote:
>> Julien Danjou <julien@danjou.info> writes:
>>
>>> There's one:
>>>
>>> % git show --pretty=full 00cd64463c5cf16d6aa0611c7957cfe94e6d5b0d | head -3
>>> commit 00cd64463c5cf16d6aa0611c7957cfe94e6d5b0d
>>> Author: Sven Joachim <svenjoac@gmx.de>
>>> Commit: Katsumi Yamaoka <yamaoka@jpl.org>
>>
>> Right. But the Commit line wasn't even in the mail, which makes it
>> rather difficult for the mailing list software to use that. :-)
SJ> Correct, that's why I proposed to change the post-receive script (which
SJ> writes and sends the mail) so that it uses the "Commit:" address for
SJ> constructing the "From:" field in the mail. Sorry if that was unclear.
The script is in the Git repo under etc/post-receive. Can you suggest a patch?
Thanks
Ted
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [ding-cvslog-owner@lists.math.uh.edu] Stalled post to ding-cvslog
2010-11-09 21:52 ` Ted Zlatanov
@ 2010-11-10 7:46 ` Sven Joachim
2010-11-23 11:14 ` Ted Zlatanov
0 siblings, 1 reply; 11+ messages in thread
From: Sven Joachim @ 2010-11-10 7:46 UTC (permalink / raw)
To: ding
On 2010-11-09 22:52 +0100, Ted Zlatanov wrote:
> On Tue, 09 Nov 2010 20:28:49 +0100 Sven Joachim <svenjoac@gmx.de> wrote:
>
> SJ> On 2010-11-09 20:08 +0100, Lars Magne Ingebrigtsen wrote:
>>> Julien Danjou <julien@danjou.info> writes:
>>>
>>>> There's one:
>>>>
>>>> % git show --pretty=full 00cd64463c5cf16d6aa0611c7957cfe94e6d5b0d | head -3
>>>> commit 00cd64463c5cf16d6aa0611c7957cfe94e6d5b0d
>>>> Author: Sven Joachim <svenjoac@gmx.de>
>>>> Commit: Katsumi Yamaoka <yamaoka@jpl.org>
>>>
>>> Right. But the Commit line wasn't even in the mail, which makes it
>>> rather difficult for the mailing list software to use that. :-)
>
> SJ> Correct, that's why I proposed to change the post-receive script (which
> SJ> writes and sends the mail) so that it uses the "Commit:" address for
> SJ> constructing the "From:" field in the mail. Sorry if that was unclear.
>
> The script is in the Git repo under etc/post-receive. Can you suggest a patch?
The following should work (untested, though):
--8<---------------cut here---------------start------------->8---
diff --git a/etc/post-receive b/etc/post-receive
index 421db3e..c77d6df 100755
--- a/etc/post-receive
+++ b/etc/post-receive
@@ -2,9 +2,9 @@
# modified: 2010-09-01 and on by tzz@lifelogs.com
-# Use the email address of the author of the last commit.
-export USER_EMAIL=$(git log -1 --format=format:%ae HEAD)
-export USER_NAME=$(git log -1 --format=format:%an HEAD)
+# Use the email address of the committer of the last commit.
+export USER_EMAIL=$(git log -1 --format=format:%ce HEAD)
+export USER_NAME=$(git log -1 --format=format:%cn HEAD)
# the remainder is the standard git-core post-receive-email with some changes:
--8<---------------cut here---------------end--------------->8---
Cheers,
Sven
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [ding-cvslog-owner@lists.math.uh.edu] Stalled post to ding-cvslog
2010-11-10 7:46 ` Sven Joachim
@ 2010-11-23 11:14 ` Ted Zlatanov
0 siblings, 0 replies; 11+ messages in thread
From: Ted Zlatanov @ 2010-11-23 11:14 UTC (permalink / raw)
To: ding
On Wed, 10 Nov 2010 08:46:32 +0100 Sven Joachim <svenjoac@gmx.de> wrote:
SJ> On 2010-11-09 22:52 +0100, Ted Zlatanov wrote:
>> On Tue, 09 Nov 2010 20:28:49 +0100 Sven Joachim <svenjoac@gmx.de> wrote:
>>
SJ> On 2010-11-09 20:08 +0100, Lars Magne Ingebrigtsen wrote:
>>>> Julien Danjou <julien@danjou.info> writes:
>>>>
>>>>> There's one:
>>>>>
>>>>> % git show --pretty=full 00cd64463c5cf16d6aa0611c7957cfe94e6d5b0d | head -3
>>>>> commit 00cd64463c5cf16d6aa0611c7957cfe94e6d5b0d
>>>>> Author: Sven Joachim <svenjoac@gmx.de>
>>>>> Commit: Katsumi Yamaoka <yamaoka@jpl.org>
>>>>
>>>> Right. But the Commit line wasn't even in the mail, which makes it
>>>> rather difficult for the mailing list software to use that. :-)
>>
SJ> Correct, that's why I proposed to change the post-receive script (which
SJ> writes and sends the mail) so that it uses the "Commit:" address for
SJ> constructing the "From:" field in the mail. Sorry if that was unclear.
>>
>> The script is in the Git repo under etc/post-receive. Can you suggest a patch?
SJ> The following should work (untested, though):
SJ> diff --git a/etc/post-receive b/etc/post-receive
SJ> index 421db3e..c77d6df 100755
SJ> --- a/etc/post-receive
SJ> +++ b/etc/post-receive
SJ> @@ -2,9 +2,9 @@
SJ> # modified: 2010-09-01 and on by tzz@lifelogs.com
SJ> -# Use the email address of the author of the last commit.
SJ> -export USER_EMAIL=$(git log -1 --format=format:%ae HEAD)
SJ> -export USER_NAME=$(git log -1 --format=format:%an HEAD)
SJ> +# Use the email address of the committer of the last commit.
SJ> +export USER_EMAIL=$(git log -1 --format=format:%ce HEAD)
SJ> +export USER_NAME=$(git log -1 --format=format:%cn HEAD)
SJ> # the remainder is the standard git-core post-receive-email with some changes:
Sorry it took so long. I installed your change (which Julien comitted
yesterday) on the Git server.
Ted
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [ding-cvslog-owner@lists.math.uh.edu] Stalled post to ding-cvslog
2010-11-09 17:53 ` Lars Magne Ingebrigtsen
2010-11-09 18:54 ` Julien Danjou
@ 2010-11-09 19:01 ` Adam Sjøgren
2010-11-09 19:09 ` Sven Joachim
2 siblings, 0 replies; 11+ messages in thread
From: Adam Sjøgren @ 2010-11-09 19:01 UTC (permalink / raw)
To: ding
On Tue, 09 Nov 2010 18:53:45 +0100, Lars wrote:
> Sven Joachim <svenjoac@gmx.de> writes:
>> would it be possible to modify the post-receive hook script so that it
>> uses the committer rather than the author in the "From:" header?
[...]
>> From: Sven Joachim <svenjoac@gmx.de>
> [...]
>> Author: Sven Joachim <svenjoac@gmx.de>
> If there's a difference here, it must be subtle...
Author != Committer?
Best regards,
Adam
--
"Angels can fly because they take themselves lightly." Adam Sjøgren
asjo@koldfront.dk
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [ding-cvslog-owner@lists.math.uh.edu] Stalled post to ding-cvslog
2010-11-09 17:53 ` Lars Magne Ingebrigtsen
2010-11-09 18:54 ` Julien Danjou
2010-11-09 19:01 ` Adam Sjøgren
@ 2010-11-09 19:09 ` Sven Joachim
2 siblings, 0 replies; 11+ messages in thread
From: Sven Joachim @ 2010-11-09 19:09 UTC (permalink / raw)
To: ding
On 2010-11-09 18:53 +0100, Lars Magne Ingebrigtsen wrote:
> Sven Joachim <svenjoac@gmx.de> writes:
>
>> would it be possible to modify the post-receive hook script so that it
>> uses the committer rather than the author in the "From:" header? That
>> would have prevented the following annoying moderation message.
>
> [...]
>
>> From: Sven Joachim <svenjoac@gmx.de>
>
> [...]
>
>> Author: Sven Joachim <svenjoac@gmx.de>
>
> If there's a difference here, it must be subtle...
The committer was Katsumi, as can be seen here:
$ git log --format="%cn <%ce>" -n1 00cd6446
Sven
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2010-11-23 11:14 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-09 10:55 [ding-cvslog-owner@lists.math.uh.edu] Stalled post to ding-cvslog Sven Joachim
2010-11-09 17:53 ` Lars Magne Ingebrigtsen
2010-11-09 18:54 ` Julien Danjou
2010-11-09 19:08 ` Lars Magne Ingebrigtsen
2010-11-09 19:28 ` Sven Joachim
2010-11-09 21:34 ` James Cloos
2010-11-09 21:52 ` Ted Zlatanov
2010-11-10 7:46 ` Sven Joachim
2010-11-23 11:14 ` Ted Zlatanov
2010-11-09 19:01 ` Adam Sjøgren
2010-11-09 19:09 ` Sven Joachim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).