From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/63488 Path: news.gmane.org!not-for-mail From: Andreas Seltenreich Newsgroups: gmane.emacs.gnus.general Subject: Re: backporting bugfixes to the v5-10 branch Date: Thu, 20 Jul 2006 19:12:40 +0200 Message-ID: <87wta86vzr.fsf@gate450.dyndns.org> References: <87wtajwzjk.fsf@gate450.dyndns.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1153415959 8972 80.91.229.2 (20 Jul 2006 17:19:19 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 20 Jul 2006 17:19:19 +0000 (UTC) Cc: Kevin Greiner Original-X-From: ding-owner+m12015@lists.math.uh.edu Thu Jul 20 19:19:19 2006 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by ciao.gmane.org with esmtp (Exim 4.43) id 1G3cAv-0006po-S8 for ding-account@gmane.org; Thu, 20 Jul 2006 19:19:02 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1G3cAS-0001JJ-00; Thu, 20 Jul 2006 12:18:32 -0500 Original-Received: from nas01.math.uh.edu ([129.7.128.39]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1G3c54-0001JD-00 for ding@lists.math.uh.edu; Thu, 20 Jul 2006 12:12:58 -0500 Original-Received: from quimby.gnus.org ([80.91.224.244]) by nas01.math.uh.edu with esmtp (Exim 4.52) id 1G3c50-0006Jl-Vl for ding@lists.math.uh.edu; Thu, 20 Jul 2006 12:12:58 -0500 Original-Received: from smtp1.rz.uni-karlsruhe.de ([129.13.185.217]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1G3c4r-0005kD-00 for ; Thu, 20 Jul 2006 19:12:45 +0200 Original-Received: from rzstud2.stud.uni-karlsruhe.de (exim@rzstud2.stud.uni-karlsruhe.de [193.196.41.38]) by smtp1.rz.uni-karlsruhe.de with esmtp (Exim 4.50 #1) id 1G3c4o-0000nq-3G; Thu, 20 Jul 2006 19:12:42 +0200 Original-Received: from uwi7 by rzstud2.stud.uni-karlsruhe.de with local (Exim 4.43) id 1G3c4n-0003ix-P1; Thu, 20 Jul 2006 19:12:41 +0200 Original-To: ding@gnus.org X-Face: $:F<87a[gD1?#R6S3j21cr1&C&7bd63GHC.tSdskUb}hhwG(ci*=D5kJ<_N+p9q(7-,PnG. Et.Yh Reiner Steib writes: > On Wed, Jul 12 2006, Andreas Seltenreich wrote: > >> I'm not sure what to do with the change to gnus-find-method-for-group: >> >> * gnus.el (gnus-find-method-for-group): On killed/unknown groups, try >> looking up the method using GROUP's prefix before inventing a new one. >> It is used on killed/unknown groups in various places where returning >> an all-new method isn't expected by the caller. >> >> While I can reproduce all of the bugs listed in >> on a stable Gnus, > > ... and the fix as well, I guess? Ack, I was unable to trigger the bugs anymore on v5-10 with the fix merged in. >> the fix depends on the macro gnus-group-server, which doesn't exists >> on the v5-10 branch. Maybe just inling its code is more appropriate >> than adding the macro to v5-10? > > I'd suggest to add the macro to v5-10 as well. It makes the code more > readable and simplifies comparing the different branches. Good point. >> I'm afraid the alternative to changing gnus-find-method-for-group >> would be to locate all places where it could be called on killed >> groups, and possibly fixing those. Btw, testing with the agent enabled revealed two places where g-f-m-f-g is called on groups after their prefix has been stripped, causing the native method to be returned. I don't think this is intentional, is it? Debugger entered: ("g-f-m-f-g called on unknown group") [...] gnus-find-method-for-group("mailings.pgsql.general") gnus-agent-get-local("mailings.pgsql.general") gnus-agent-possibly-alter-active("mailings.pgsql.general" (1 . 6325)) gnus-agent-regenerate-group("nnpg+lists:mailings.pgsql.general" nil) gnus-agent-regenerate(nil) call-interactively(gnus-agent-regenerate) execute-extended-command(nil) call-interactively(execute-extended-command) Debugger entered: ("g-f-m-f-g called on unknown group") [...] gnus-find-method-for-group("mailings.pgsql.general") gnus-group-name-charset(nil "mailings.pgsql.general") gnus-group-decoded-name("mailings.pgsql.general") gnus-agent-group-pathname("mailings.pgsql.general") gnus-agent-article-name(".overview" "mailings.pgsql.general") nnagent-retrieve-headers((1113 1114) "mailings.pgsql.general" "lists" nil) gnus-retrieve-headers((1113 1114) "nnpg+lists:mailings.pgsql.general" nil) gnus-cache-retrieve-headers((1113 1114) "nnpg+lists:mailings.pgsql.general" nil) gnus-retrieve-headers((1113 1114) "nnpg+lists:mailings.pgsql.general" nil) gnus-fetch-headers((1113 1114)) gnus-select-newsgroup("nnpg+lists:mailings.pgsql.general" nil nil) gnus-summary-read-group-1("nnpg+lists:mailings.pgsql.general" nil t nil nil nil) gnus-summary-read-group("nnpg+lists:mailings.pgsql.general" nil t nil nil nil nil) gnus-group-read-group(nil t) gnus-group-select-group(nil) gnus-topic-select-group(nil) call-interactively(gnus-topic-select-group) regards, andreas