Re: 'g' in the group buffer still very slow

[Martin Rohde <martin.rohde@gmx.de>]

On Day 50 of The Aftermath 3168, Kai Großjohann wrote:

> krause@my.gnus.org (Sebastian D.B. Krause) writes:
>
>> Okay, as we don't need this code when Gnus has a direct NNTP
>> connection to the server (when nntp-open-connection-function is set
>> to nntp-open-network-stream), I suggest -- as a workaround -- to
>> enable this code only when nntp-open-connection-function is *not*
>> nntp-open-network-stream. I've tested my small patch (see below) and
>> it makes fetching the active file much faster without the problems I
>> had with telnet and local echo when I removed the code with the old
>> patch quoted below.
>
> There is a bug.  You write (unless nntp-open-connection-function
> 'nntp-open-network-stream statements...).  The condition here is the
> variable nntp-open-connection-function, it is tested whether the
> variable is nil.  The quoted symbol is an expression which is
> evaluated by has no effect.
>
> I've committed something similar to your patch.

Like Sebastian mentioned before,

,----
| 
|  (unless (and wait-for
| 	     (equal nntp-open-connection-function
| 		    'nntp-open-network-stream))
`----

doesn't work. It has to be "or" instead of "and"...

> I think what should be done is to look, after the connection has been
> established, whether the commands are echoed.  If so, set a
> variable.  Then change the condition to look at that variable.

If I get it right, you can almost take the code for that from
nntp-send-command* and put it into nntp-open-connection. I will send
a patch, if it works.


Martin