Re: expiry problems?

[Josh Huber <huber@alum.wpi.edu>]

"Matt Armstrong" <matt+dated+1007925443.50f781@lickey.com> writes:

> This is usually when I start making use of edebug-defun.  ;-)

indeed.  after my first use of edebug, I've decided that it rocks :)

I did manage to make xemacs segfault with it though :P

What I realized, after tracing functions about 5 levels deep, is that
the nnmail-expired-article-p function was returning nil for some
articles that are older than 7 days.

I noticed that it sorts the articles by number, then looks for the
is-old parameter to turn false, at which point it doesn't check
anymore.

This is fine, except for the fact that the nnmail-expired-article-p
function returns nil for VERY old articles.

because of this piece of code:

(time-less-p days (time-since time))

time-since returns a negative number for articles before 1970...

touch -d "Jan 1 1940" <first article in nnml directory>

and your articles will never be expired in that group.

My clock must have been set wrong while those messages were created,
and they're in each group I have keeping everything from being
expired.

anyway, here is my fix, should I commit?  I'm asking since it really
seems like a hack.  The real fix is probably to time-since...

Index: ChangeLog
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/ChangeLog,v
retrieving revision 6.844
diff -u -r6.844 ChangeLog
--- ChangeLog	2001/11/09 21:58:45	6.844
+++ ChangeLog	2001/11/09 22:59:04
@@ -1,3 +1,8 @@
+2001-11-09  Josh Huber  <huber@alum.wpi.edu>
+
+	* nnmail.el (nnmail-expired-article-p): Add case for files older
+	than 1970.
+
 2001-11-09  Simon Josefsson  <jas@extundo.com>
 
 	* gnus.el (gnus-local-domain): Fix doc.  From Pavel Janík
Index: nnmail.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/nnmail.el,v
retrieving revision 6.27
diff -u -r6.27 nnmail.el
--- nnmail.el	2001/09/26 17:55:05	6.27
+++ nnmail.el	2001/11/09 22:59:04
@@ -1687,7 +1687,12 @@
 	    ((numberp days)
 	     (setq days (days-to-time days))
 	     ;; Compare the time with the current time.
-	     (ignore-errors (time-less-p days (time-since time))))))))
+	     (let ((since (time-since time)))
+	       (ignore-errors
+		 ;; if time-since returns a negative value the date is
+		 ;; before 1970, and is obviouly ready to expire.
+		 (or (> 0 (car since))
+		     (time-less-p days since)))))))))
 
 (defun nnmail-expiry-target-group (target group)
   ;; Do not invoke this from nntp-server-buffer!  At least nnfolder clears


-- 
Josh Huber