Bug in 5.8.5 (copying articles)

Bug in 5.8.5 (copying articles)

[Arcady Genkin]

I think I discovered another bug in the latest CVS gnus. I tried to
copy an article from an nntp group into an nnimap one, or from an
nnimap into nnimap. I use "B c" from summary buffer. Here's the trace:

Signaling: (wrong-type-argument listp "archive")
  car("archive")
  (gnus-check-backend-function (quote request-accept-article) (car to-method))
)
  (if (gnus-check-backend-function (quote request-accept-article) (car to-method)) nil (error "%s does not support article copying" (car to-method)))
)
  (unless (gnus-check-backend-function (quote request-accept-article) (car to-method)) (error "%s does not support article copying" (car to-method)))
)
  (let ((articles ...) (prefix ...) (names ...) (copy-buf ...) art-group to-method new-xref article to-groups) (unless (assq action names) (error "Unknown action %s" action)) (when (and ... ...) (setq to-newsgroup ...) (set ... to-newsgroup)) (setq to-method (or select-method ...)) (unless (gnus-check-backend-function ... ...) (error "%s does not support article copying" ...)) (unless (gnus-check-server to-method) (error "Can't open server %s" ...)) (gnus-message 6 "%s to %s: %s..." (caddr ...) (or ... to-newsgroup) articles) (while articles (setq article ...) (setq art-group ...) (cond ... ... ...) (gnus-summary-remove-process-mark article)) (while to-groups (save-excursion ... ... ...)) (gnus-kill-buffer copy-buf) (gnus-summary-position-point) (gnus-set-mode-line (quote summary)))
)
  gnus-summary-move-article(nil nil nil copy)
  gnus-summary-copy-article(nil)
  call-interactively(gnus-summary-copy-article)
-- 
Arcady Genkin                                 http://www.thpoon.com
Nostalgia isn't what it used to be.

Re: Bug in 5.8.5 (copying articles)

[Simon Josefsson]

Arcady Genkin <a.genkin@utoronto.ca> writes:

> I think I discovered another bug in the latest CVS gnus. I tried to
> copy an article from an nntp group into an nnimap one, or from an
> nnimap into nnimap. I use "B c" from summary buffer. Here's the trace:
> 
> Signaling: (wrong-type-argument listp "archive")
>   car("archive")

This patch might solve that problem, could you see if it does?

This is the same patch as Chris Brierley re-sent earlier, only without
byte-compile warnings.

2000-03-01  Simon Josefsson  <jas@pdc.kth.se>

	* gnus-sum.el (gnus-read-move-group-name): 
	(gnus-summary-move-article): Use `gnus-group-method' to find out
	what method the manually entered group belong to.
	`gnus-group-name-to-method' doesn't return any method parameters
	and `gnus-find-method-for-group' uses `gnus-group-name-to-method'
	for new groups so they wouldn't work.

Index: gnus-sum.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-sum.el,v
retrieving revision 5.104
diff -w -u -u -w -r5.104 gnus-sum.el
--- gnus-sum.el	2000/04/21 20:18:21	5.104
+++ gnus-sum.el	2000/04/21 21:27:23
@@ -7333,7 +7333,8 @@
 	     articles prefix))
       (set (intern (format "gnus-current-%s-group" action)) to-newsgroup))
     (setq to-method (or select-method
-			(gnus-group-method to-newsgroup)))
+			(gnus-server-to-method
+			 (gnus-group-method to-newsgroup))))
     ;; Check the method we are to move this article to...
     (unless (gnus-check-backend-function
 	     'request-accept-article (car to-method))
@@ -9030,7 +9031,8 @@
 				  (mapcar (lambda (el) (list el))
 					  (nreverse split-name))
 				  nil nil nil
-				  'gnus-group-history)))))
+				  'gnus-group-history))))
+         (to-method (gnus-server-to-method (gnus-group-method to-newsgroup))))
     (when to-newsgroup
       (if (or (string= to-newsgroup "")
 	      (string= to-newsgroup prefix))
@@ -9038,15 +9040,12 @@
       (unless to-newsgroup
 	(error "No group name entered"))
       (or (gnus-active to-newsgroup)
-	  (gnus-activate-group to-newsgroup nil nil
-			       (gnus-group-method to-newsgroup))
+	  (gnus-activate-group to-newsgroup nil nil to-method)
 	  (if (gnus-y-or-n-p (format "No such group: %s.  Create it? "
 				     to-newsgroup))
-	      (or (and (gnus-request-create-group
-			to-newsgroup (gnus-group-method to-newsgroup))
+	      (or (and (gnus-request-create-group to-newsgroup to-method)
 		       (gnus-activate-group
-			to-newsgroup nil nil
-			(gnus-group-method to-newsgroup))
+			to-newsgroup nil nil to-method)
 		       (gnus-subscribe-group to-newsgroup))
 		  (error "Couldn't create group %s" to-newsgroup)))
 	  (error "No such group: %s" to-newsgroup)))

Re: Bug in 5.8.5 (copying articles)

[Arcady Genkin]

Simon Josefsson <jas@pdc.kth.se> writes:

> This patch might solve that problem, could you see if it does?

Hi, Simon, this seems to have fixed it. Thanks!
-- 
Arcady Genkin                                 http://www.thpoon.com
Nostalgia isn't what it used to be.

Re: Bug in 5.8.5 (copying articles)

[Simon Josefsson]

Arcady Genkin <a.genkin@utoronto.ca> writes:

> > This patch might solve that problem, could you see if it does?
> 
> Hi, Simon, this seems to have fixed it. Thanks!

I've commited it.