orphan scoring broken?

orphan scoring broken?

[Dan Christensen]

Is orphan scoring working properly for anyone else?  I have (orphan
-1) in a score file, and am finding that lots of follow-ups are
getting scored down by -1, even when all of their ancestors are in the
summary buffer.  I've noticed that children whose summary lines
contain < > instead of [ ] (I guess these are adopted children) don't
have this problem.  I'm using pgnus 0.97.1.  I don't think this was
happening in previous versions, although I may just not have noticed.

For example, it happens for the following two articles, when the
score file for the group contains just:  ((orphan -1))

-----------
 From jdc@chow.mat.jhu.edu Wed Oct 06 16:29:27 1999
Received: from jdc by scratchy with local (Exim 2.05 #1 (Debian))
	id 11Yxgl-0006Fd-00; Wed, 6 Oct 1999 16:29:27 -0400
To: jdc@scratchy
Subject: Re: test of orphan scoring
References: <874sg48c9c.fsf@chow.mat.jhu.edu>
From: Dan Christensen <jdc@chow.mat.jhu.edu>
Date: 06 Oct 1999 16:29:26 -0400
In-Reply-To: Dan Christensen's message of "06 Oct 1999 16:28:31 -0400"
X-Gnus-Mail-Source: file:/var/mail/jdc
Message-ID: <87puys6xnd.fsf@chow.mat.jhu.edu>
User-Agent: Gnus/5.07009701 (Pterodactyl Gnus v0.97.1) Emacs/20.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Xref: scratchy test6:1
Lines: 3
X-Gnus-Article-Number: 1   Wed Oct  6 16:36:52 1999

this is the followup to jdc

 From jdc@chow.mat.jhu.edu Wed Oct 06 16:28:32 1999
Received: from jdc by scratchy with local (Exim 2.05 #1 (Debian))
	id 11Yxfr-0006FN-00; Wed, 6 Oct 1999 16:28:31 -0400
To: jdc@scratchy
Subject: test of orphan scoring
From: Dan Christensen <jdc@chow.mat.jhu.edu>
Date: 06 Oct 1999 16:28:31 -0400
X-Gnus-Mail-Source: file:/var/mail/jdc
Message-ID: <874sg48c9c.fsf@chow.mat.jhu.edu>
User-Agent: Gnus/5.07009701 (Pterodactyl Gnus v0.97.1) Emacs/20.3
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Lines: 1
Xref: scratchy test6:2
X-Gnus-Article-Number: 2   Wed Oct  6 16:28:37 1999

-----------

Dan

-- 
Dan Christensen
jdc@math.jhu.edu

Re: orphan scoring broken?

[Dan Christensen]

[-- Attachment #1: Type: text/plain, Size: 1535 bytes --]

[Cc'd to Peter Mutsaers, whose name is in the source code as the
author of the orphan scoring functions.]

I found two independent problems with orphan scoring in pgnus 0.97.1.
The first is that articles which have no references have this indicated 
internally in gnus sometimes with "" and sometimes with nil.  The code
only checked for "", and so many articles that were actually roots 
were thought to be orphans (along with all of their descendents).
The fix for this is a simple change to one line.  I don't know where
the discrepancy between "" and nil originates, but it might be worth
tracking this down.

The second problem I noticed with orphan scoring is the following.
Suppose we have three articles, A, B and C, with B a followup to
A and C a followup to B.  If C has no references header, but does
have valid In-Reply-To header pointing to B, the current code will
conclude that it is an orphan, because the current code tries to
find the message-id of a root article in the headers of C.  

To fix the second problem, I completely rewrote the orphan scoring
code.  It turns out that there was already a function written which
handles collecting related articles together, and so the new code
is in fact shorter and cleaner than the old code.  

I have tested this in a variety of circumstances, but it would be good
for other people to test it and to examine the code, as my lisp is a
little rusty.  

The patch is attached below.  It replaces two functions in gnus-score.el.

Dan

-- 
Dan Christensen
jdc@math.jhu.edu


[-- Attachment #2: patch to fix orphan scoring --]
[-- Type: application/emacs-lisp, Size: 101539 bytes --]