From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 18919 invoked from network); 15 May 2020 14:15:44 -0000 Received: from lists1.math.uh.edu (129.7.128.208) by inbox.vuxu.org with ESMTPUTF8; 15 May 2020 14:15:44 -0000 Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by lists1.math.uh.edu with smtp (Exim 4.92.3) (envelope-from ) id 1jZb6s-0008HV-L9; Fri, 15 May 2020 09:14:46 -0500 Received: from mx1.math.uh.edu ([129.7.128.32]) by lists1.math.uh.edu with esmtps (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1jZb6n-0008Eh-W1 for ding@lists.math.uh.edu; Fri, 15 May 2020 09:14:42 -0500 Received: from quimby.gnus.org ([95.216.78.240]) by mx1.math.uh.edu with esmtps (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1jZb6k-00084Z-1K for ding@lists.math.uh.edu; Fri, 15 May 2020 09:14:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=uYfLllTJYuL8sw66sEc1oaBeoVt8eGQ9EanPTOQ8MBw=; b=taErJrWA5BMPJvJ4M0Ndvx+AHp HnjFZkY77bQ4mcwWUWiDk9Srsbo3N1xkSkyCURflnRHg7Nmc4d3zbb4Hyz6MyjVsRD65yMZsgt0Jg ZHO6zgqb1XCbYTxDGV9gAL/GGzLhnAXyeoB5/f2sAAX3AJrcOTXJdYEYHK2kNtHJuoKc=; Received: from eggs.gnu.org ([2001:470:142:3::10]) by quimby.gnus.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jZb6Z-0005VC-Qk for ding@gnus.org; Fri, 15 May 2020 16:14:33 +0200 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41989) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZb6W-000257-Bb; Fri, 15 May 2020 10:14:24 -0400 Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:41859) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1jZb6S-0005ld-UW; Fri, 15 May 2020 10:14:24 -0400 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id C1B6927C005A; Fri, 15 May 2020 10:14:19 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Fri, 15 May 2020 10:14:19 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrleekgdejvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufhffjgfkfgggtgfgsehtqhertddtreejnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqnecuggftrfgrthhtvghrnhepvd eufeekueelkeehfffftdeiuddvhffftdfgkefhjeeujeduhedukeevfeevvdfhnecukfhp peelfedrvdefiedrudegtddrieefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepthhhohhrnhdomhgvshhmthhprghuthhhphgvrhhsohhnrghl ihhthidqkeeijeefkeejkeegqdeifeehvdelkedqthhsughhpeepghhnuhdrohhrghesfh grshhtmhgrihhlrdhfmh X-ME-Proxy: Received: from thinkpad-t440p (p5dec8c3f.dip0.t-ipconnect.de [93.236.140.63]) by mail.messagingengine.com (Postfix) with ESMTPA id 562CE3280064; Fri, 15 May 2020 10:14:18 -0400 (EDT) From: Tassilo Horn To: Robert Pluim Cc: Andreas Schwab , ding@gnus.org Subject: Re: Attachments broken since some time References: <87zha9abpa.fsf@gnu.org> <87pnb5tveg.fsf@igel.home> <873681cysp.fsf@gnu.org> Date: Fri, 15 May 2020 16:14:16 +0200 In-Reply-To: (Robert Pluim's message of "Fri, 15 May 2020 12:11:46 +0200") Message-ID: <87y2ptxp3b.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-ID: Precedence: bulk Robert Pluim writes: >>>>>> On Fri, 15 May 2020 11:50:14 +0200, Tassilo Horn said: > > Tassilo> Ah, now I have it! Some time back I added > > Tassilo> (nnimap-fetch-partial-articles "text/") > > Tassilo> to all my nnimap select methods. I've thought that would do= what is > Tassilo> documented but also fetch those missing parts as soon as I a= ctually read > Tassilo> such a mail. Seems that's not the case. :-) > > Tassilo> I think that's a bit unfortunate. If at least the button wo= uld have > Tassilo> some indicator (undownloaded) or something alike... > > =E2=80=98A C=E2=80=99 > If =E2=80=98-fetch-partial-articles=E2=80=99 is non-=E2=80= =98nil=E2=80=99, Gnus will fetch > partial articles, if the backend it fetches them from supports it. > Currently only =E2=80=98nnimap=E2=80=99 does. If you=E2=80=99re loo= king at a partial > article, and want to see the complete article instead, then the =E2= =80=98A > C=E2=80=99 command (=E2=80=98gnus-summary-show-complete-article=E2= =80=99) will do so. > > although it would be nice if there was a visual indication. The below does the job for me. The button then reads [2. image/png (undownloaded, A C to fetch.)] and the help-echo also mentions the A C command. --8<---------------cut here---------------start------------->8--- modified lisp/gnus/gnus-art.el @@ -5833,6 +5833,7 @@ gnus-insert-mime-button "" "...")) (gnus-tmp-length (with-current-buffer (mm-handle-buffer handle) (buffer-size))) + (help-echo "mouse-2: toggle the MIME part; down-mouse-3: more opti= ons") gnus-tmp-type-long b e) (when (string-match ".*/" gnus-tmp-name) (setq gnus-tmp-name (replace-match "" t t gnus-tmp-name))) @@ -5841,6 +5842,16 @@ gnus-insert-mime-button (concat "; " gnus-tmp-name)))) (unless (equal gnus-tmp-description "") (setq gnus-tmp-type-long (concat " --- " gnus-tmp-type-long))) + (when (=3D 0 gnus-tmp-length) + (setq gnus-tmp-type-long + (concat + gnus-tmp-type-long + (substitute-command-keys + (concat "\\ (undownloaded, " + "\\[gnus-summary-show-complete-article] to fetch.)")= ))) + (setq help-echo + (concat "Type \\[gnus-summary-show-complete-article] " + "to download complete article. " help-echo))) (setq b (point)) (gnus-eval-format gnus-mime-button-line-format gnus-mime-button-line-format-alist @@ -5859,8 +5870,7 @@ gnus-insert-mime-button 'keymap gnus-mime-button-map 'face gnus-article-button-face 'follow-link t - 'help-echo - "mouse-2: toggle the MIME part; down-mouse-3: more options"))) + 'help-echo help-echo))) =20 (defvar gnus-displaying-mime nil) --8<---------------cut here---------------end--------------->8--- Any objections to pushing that change? Honestly, I didn't find a way to distinguish between "intentionally not downloaded" and "broken zero-byte attachment", so A C with a mail with the latter will result in the same button again, I guess. Bye, Tassilo