Gnus development mailing list
 help / color / mirror / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: ding@gnus.org
Subject: Re: bug#20956: [PATCH] Fix imap message size parsing
Date: Sat, 11 Jul 2015 13:50:06 +0800	[thread overview]
Message-ID: <87y4in8cq9.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87h9pf5lxk.fsf@vostro.rath.org>

Nikolaus Rath <Nikolaus@rath.org> writes:

> On Jul 06 2015, Eric Abrahamsen <eric@ericabrahamsen.net> wrote:
>> Nikolaus Rath <Nikolaus@rath.org> writes:
>>
>>> Package: gnus
>>> Tags: patch
>>>
>>> IMAP servers may sent the data items in a FETCH response in arbitrary
>>> order. However, currently Gnus assumes that the UID item is sent before
>>> the RFC822.SIZE item. If this assumption is wrong, Gnus is unable to
>>> determine the message size.
>>>
>>> The attached patch fixes this issue.
>>>
>>> Best,
>>> -Nikolaus
>>
>> Hi Nikolaus,
>>
>> Would you please resend the patch using git format-patch, and I'll apply
>> it? With just this patch file, I'd have to manually re-create the
>> commit, which would lose your metadata as author. Same for your other
>> two patches, if you don't mind.
>
> I just did so. Please let me know if this worked correctly, this is the
> first time I've used git.

Okay, I've pushed the size parsing fix as 1f1d39c. The other three
patches are quite a bit more complicated, and I'd like to run them
locally for just a few days just to see if anything explodes. Thanks for
your patience with working on the commits.

Katsumi Yamaoka, thanks for fixing up my commit messages, and sorry to
create extra work! I'll keep trying to get these things formatted
correctly...

Eric




      reply	other threads:[~2015-07-11  5:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-02  2:45 Nikolaus Rath
2015-07-07  2:53 ` Eric Abrahamsen
2015-07-08  4:10   ` Nikolaus Rath
2015-07-11  5:50     ` Eric Abrahamsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y4in8cq9.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).