Gnus development mailing list
 help / color / mirror / Atom feed
From: Sven Joachim <svenjoac@gmx.de>
To: ding@gnus.org
Subject: Re: Garbled display of UTF-8 encoded mails
Date: Wed, 24 Nov 2010 13:54:35 +0100	[thread overview]
Message-ID: <87y68iubjo.fsf@turtle.gmx.de> (raw)
In-Reply-To: <87aakzvxb4.fsf@turtle.gmx.de> (Sven Joachim's message of "Wed, 24 Nov 2010 11:19:11 +0100")

On 2010-11-24 11:19 +0100, Sven Joachim wrote:

> However, this contains a change in semantics that is not mentioned and
> might have been unintended.  The old version of mm-enable-multibyte for
> Emacs was (set-buffer-multibyte 'to), whereas the new one is
> (set-buffer-multibyte t), and this seems to be what causes all my
> problems.  Reverting the change in master:
>
> diff --git a/lisp/mm-util.el b/lisp/mm-util.el
> index 67b41e0..700c1a6 100644
> --- a/lisp/mm-util.el
> +++ b/lisp/mm-util.el
> @@ -903,7 +903,7 @@ mail with multiple parts is preferred to sending a Unicode one.")
>        "Set the multibyte flag of the current buffer.
>  Only do this if the default value of `enable-multibyte-characters' is
>  non-nil.  This is a no-op in XEmacs."
> -      (set-buffer-multibyte t)))
> +      (set-buffer-multibyte 'to)))
>  
>    (if (featurep 'xemacs)
>        (defalias 'mm-disable-multibyte 'ignore)
>
> solves the issue for me.

BTW, I found an old commit which did the same change, but the ChangeLog
entry is not especially informative what exactly the problems were:

,----
| $ git show 302ab06a28aec7e405145417bdcbf324246ea192
| commit 302ab06a28aec7e405145417bdcbf324246ea192
| Author: Simon Josefsson <jas@extundo.com>
| Date:   Sun Nov 30 16:59:35 2003 +0000
| 
|     (mm-enable-multibyte): Call set-buffer-multibyte with
|     'to argument.  Fixes something or other in Emacs 22, and is
|     backwards compatible.  From Kenichi Handa <handa@m17n.org>.
| 
| diff --git a/lisp/ChangeLog b/lisp/ChangeLog
| index 6e37dbe..8d55cf2 100644
| --- a/lisp/ChangeLog
| +++ b/lisp/ChangeLog
| @@ -1,5 +1,9 @@
|  2003-11-30  Simon Josefsson  <jas@extundo.com>
|  
| +	* mm-util.el (mm-enable-multibyte): Call set-buffer-multibyte with
| +	'to argument.  Fixes something or other in Emacs 22, and is
| +	backwards compatible.  From Kenichi Handa <handa@m17n.org>.
| +
|  	* gnus-agent.el (gnus-agent-expire-unagentized-dirs): Custom fix.
|  
|  2003-11-30  Lars Magne Ingebrigtsen  <larsi@gnus.org>
| diff --git a/lisp/mm-util.el b/lisp/mm-util.el
| index eef5c04..cbd85b1 100644
| --- a/lisp/mm-util.el
| +++ b/lisp/mm-util.el
| @@ -413,7 +413,7 @@ used as the line break code type of the coding system."
|  	"Set the multibyte flag of the current buffer.
|  Only do this if the default value of `enable-multibyte-characters' is
|  non-nil.  This is a no-op in XEmacs."
| -	(set-buffer-multibyte t))
| +	(set-buffer-multibyte 'to))
|      (defalias 'mm-enable-multibyte 'ignore))
|  
|    (if mm-emacs-mule
| 
`----

I haven't been able to find a mailinglist thread which describes this in
greater detail.

Sven



  reply	other threads:[~2010-11-24 12:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-23 20:11 Sven Joachim
2010-11-23 21:03 ` Sven Joachim
2010-11-24  4:39   ` Katsumi Yamaoka
2010-11-24  6:27     ` Sven Joachim
2010-11-24  7:03       ` Sven Joachim
2010-11-24  7:15         ` Katsumi Yamaoka
2010-11-24  7:17         ` Sven Joachim
2010-11-24  7:28           ` Katsumi Yamaoka
2010-11-24  7:58             ` Sven Joachim
2010-11-24 10:19   ` Sven Joachim
2010-11-24 12:54     ` Sven Joachim [this message]
2010-11-24 21:07       ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y68iubjo.fsf@turtle.gmx.de \
    --to=svenjoac@gmx.de \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).