size of gnus-undo-actions

size of gnus-undo-actions

[Ami Fischman]

What is considered a reasonable size for gnus-undo-actions
(buffer-local variable in *Group*)?
For a session with uptime 6d18h I've got a 237-element
gnus-undo-actions value that takes 12MB to prin1, or almost 50KB per
recorded action.  Quitting gnus frees up over 1.3MB of lisp heap
(according to memory-usage.el).  Does gnus-undo-actions really need to
be so large?

FWIW, I used this to get the above numbers:

(save-excursion
  (set-buffer "*Group*")
  (let ((len (length gnus-undo-actions))
        (size (length (prin1-to-string gnus-undo-actions)))
        (limit gnus-undo-limit))
    (message "Length:%d, size:%d, limit:%d"
             len size limit)))

Which printed:
Length:237, size:12037804, limit:2000

Cheers,
-a

Re: size of gnus-undo-actions

[Lars Magne Ingebrigtsen]

"Ami Fischman" <ami@fischman.org> writes:

> Does gnus-undo-actions really need to be so large?

I've now limited it to 100 elements.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: size of gnus-undo-actions

[Leo]

On 2010-08-30 19:18 +0100, Lars Magne Ingebrigtsen wrote:
> "Ami Fischman" <ami@fischman.org> writes:
>
>> Does gnus-undo-actions really need to be so large?
>
> I've now limited it to 100 elements.

Isn't changing the default value of gnus-undo-limit enough?

Leo

Re: size of gnus-undo-actions

[Lars Magne Ingebrigtsen]

Leo <sdl.web@gmail.com> writes:

> Isn't changing the default value of gnus-undo-limit enough?

I didn't notice that one.  Then the user can just lower it themselves if
they have too little RAM.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: size of gnus-undo-actions

[Leo]

On 2010-08-30 19:39 +0100, Lars Magne Ingebrigtsen wrote:
>> Isn't changing the default value of gnus-undo-limit enough?
>
> I didn't notice that one.  Then the user can just lower it themselves if
> they have too little RAM.

Maybe it should default to 100 and if users have more RAM they can
increase it. BTW, I just noticed gnus-undo today.

Leo

Re: size of gnus-undo-actions

[Štěpán Němec]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> "Ami Fischman" <ami@fischman.org> writes:
>
>> Does gnus-undo-actions really need to be so large?
>
> I've now limited it to 100 elements.

Hey, this is Gnus, there should be an option for that!