Gnus development mailing list
 help / color / mirror / Atom feed
From: David Engster <deng@randomsample.de>
To: ding@gnus.org
Subject: Accepting x-pkcs7-signature
Date: Thu, 22 Jul 2010 23:11:59 +0200	[thread overview]
Message-ID: <87y6d3z0f4.fsf@randomsample.de> (raw)

I still have this old patch lying around, which lets Gnus accept
signatures with a x-pkcs7-signature MIME type, instead of just
"pkcs7-signature". Though RFC 2311 declares this as

C.1 Early MIME Types

   Some early implementations of S/MIME agents used the following MIME
   types: [...] application/x-pkcs7-signature [...] 
   In each case, the "x-" subtypes correspond to the subtypes described
   in this document without the "x-".

a quick look through my inbox actually shows more messages with those
"x-pkcs" types than plain "pkcs"; seems to be some kind of Exchange
thingy, so this will likely not change soon...

Does anyone see a problem with this patch?

--- mml-smime.el.~7.23.~	2008-05-19 10:47:42.000000000 +0200
+++ mml-smime.el	2008-09-17 11:56:12.000000000 +0200
@@ -520,10 +520,14 @@
 					   ctl 'protocol)
 					  "application/pkcs7-signature")
 				  t)))
-		(null (setq signature (mm-find-part-by-type
-				       (cdr handle)
-				       "application/pkcs7-signature"
-				       nil t))))
+		(null (setq signature (or (mm-find-part-by-type
+					   (cdr handle)
+					   "application/pkcs7-signature"
+					   nil t)
+					  (mm-find-part-by-type
+					   (cdr handle)
+					   "application/x-pkcs7-signature"
+					   nil t)))))
 	(mm-set-handle-multipart-parameter
 	 mm-security-handle 'gnus-info "Corrupted")
 	(throw 'error handle))


Regards,
David



             reply	other threads:[~2010-07-22 21:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-22 21:11 David Engster [this message]
2010-07-23  8:53 ` Daiki Ueno
2010-07-23 10:32   ` David Engster
2010-07-23 14:57     ` Daiki Ueno
2010-07-23 18:13       ` David Engster
2010-07-24  1:21         ` Daiki Ueno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y6d3z0f4.fsf@randomsample.de \
    --to=deng@randomsample.de \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).