From: Christoph Conrad <christoph.conrad@gmx.de>
To: Justus@piater.name
Cc: ding@gnus.org
Subject: Re: nnir.el cleanup
Date: Thu, 24 Apr 2008 20:34:02 +0200 [thread overview]
Message-ID: <87y773krvf.fsf@ID-24456.user.uni-berlin.de> (raw)
In-Reply-To: <v9fxtbcel5.fsf@marauder.physik.uni-ulm.de> (Reiner Steib's message of "Thu, 24 Apr 2008 20:06:30 +0200")
Hi Reiner,
> Thanks. I've committed it with a more verbose ChangeLog entry.
Ok, now i understand what you mean by "verbose" :-) Next time my
changelog proposal will be better.
>> I also see some suspicious and potentially dangerous code: the
> I see that it is unnecessary, but could you elaborate why it could be
> dangerous and/or provide a patch?
I exaggerated a little bit. But generally it's not good style to do
that. If you overlook the local re-binding and make changes supporting
groups, they will have no effect. I am too lazy for supplying a patch.
If you are patching the next time, change it if you are in the mood for.
> Or is this sufficient?
It does not catch all places. Also some of the other nnir-run* have the
same shadowing of the group parameter by a local let binding, but emit
an error before the let binding when group is not nil.
With kind regards,
Christoph
next prev parent reply other threads:[~2008-04-24 18:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87y77fiszu.fsf@ID-24456.user.uni-berlin.de>
[not found] ` <87lk3fvw4l.fsf@ID-24456.user.uni-berlin.de>
[not found] ` <873apmapq9.fsf_-_@ID-24456.user.uni-berlin.de>
[not found] ` <x8tfxtm2mqc.fsf@tool.montefiore.ulg.ac.be>
2008-04-16 10:50 ` FIX Christoph Conrad
2008-04-16 18:22 ` nnir.el swish++ interface broken (was: FIX) Reiner Steib
2008-04-17 7:20 ` nnir.el swish++ interface broken Justus-bulk
2008-04-17 7:37 ` Christoph Conrad
2008-04-17 18:01 ` Christoph Conrad
2008-04-19 17:36 ` Reiner Steib
2008-04-20 7:48 ` nnir.el cleanup (was Re: nnir.el swish++ interface broken) Justus
2008-04-20 10:09 ` nnir.el cleanup Reiner Steib
2008-04-20 15:39 ` Christoph Conrad
2008-04-20 20:02 ` Reiner Steib
2008-04-22 17:52 ` Christoph Conrad
2008-04-24 18:06 ` Reiner Steib
2008-04-24 18:34 ` Christoph Conrad [this message]
2008-04-24 18:17 ` Compiler warnings in nnir.el (was: nnir.el cleanup) Reiner Steib
2008-04-25 2:27 ` Compiler warnings in nnir.el Stefan Monnier
2008-04-20 11:03 ` nnir.el cleanup (was Re: nnir.el swish++ interface broken) Christoph Conrad
2008-04-21 13:40 ` Christoph Conrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y773krvf.fsf@ID-24456.user.uni-berlin.de \
--to=christoph.conrad@gmx.de \
--cc=Justus@piater.name \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).