From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/66869 Path: news.gmane.org!not-for-mail From: Christoph Conrad Newsgroups: gmane.emacs.gnus.general Subject: Re: nnir.el cleanup Date: Thu, 24 Apr 2008 20:34:02 +0200 Message-ID: <87y773krvf.fsf@ID-24456.user.uni-berlin.de> References: <87y77fiszu.fsf@ID-24456.user.uni-berlin.de> <87lk3fvw4l.fsf@ID-24456.user.uni-berlin.de> <873apmapq9.fsf_-_@ID-24456.user.uni-berlin.de> <87k5isa5vc.fsf@ID-24456.user.uni-berlin.de> <87hcdtep8k.fsf@ID-24456.user.uni-berlin.de> Reply-To: Christoph Conrad NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1209063206 3798 80.91.229.12 (24 Apr 2008 18:53:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 24 Apr 2008 18:53:26 +0000 (UTC) Cc: ding@gnus.org To: Justus@piater.name Original-X-From: ding-owner+M15351@lists.math.uh.edu Thu Apr 24 20:54:00 2008 connect(): Connection refused Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1Jp6Zy-0006b4-Gn for ding-account@gmane.org; Thu, 24 Apr 2008 20:53:58 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1Jp6Z5-0003eN-Sl; Thu, 24 Apr 2008 13:53:03 -0500 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1Jp6Z4-0003e7-Mk for ding@lists.math.uh.edu; Thu, 24 Apr 2008 13:53:02 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtp (Exim 4.67) (envelope-from ) id 1Jp6Yy-0007kY-8Z for ding@lists.math.uh.edu; Thu, 24 Apr 2008 13:53:02 -0500 Original-Received: from mail.gmx.net ([213.165.64.20]) by quimby.gnus.org with smtp (Exim 3.35 #1 (Debian)) id 1Jp6Z9-0001sg-00 for ; Thu, 24 Apr 2008 20:53:07 +0200 Original-Received: (qmail invoked by alias); 24 Apr 2008 18:52:24 -0000 Original-Received: from p5089199D.dip0.t-ipconnect.de (EHLO brabbelbox) [80.137.25.157] by mail.gmx.net (mp041) with SMTP; 24 Apr 2008 20:52:24 +0200 X-Authenticated: #4523881 X-Provags-ID: V01U2FsdGVkX18GbGsB53kG6M8iwZEl4AcKANzmp1Fh1v+8NA4Las t+wl2vCzb5sfa8 Original-Received: by brabbelbox (Postfix, from userid 1000) id 5392FAC0AD; Thu, 24 Apr 2008 20:52:20 +0200 (CEST) X-Public-Key: http://wwwkeys.de.pgp.net:11371/pks/lookup?op=get&search=0x1B488DEA X-Hashcash: 1:20:080424:ding@gnus.org::BwLi1kTdHW+OiQ1e:00000cow X-Hashcash: 1:20:080424:justus@piater.name::BG6mPzg9mXvBUqN9:00000000000000000000000000000000000000000007tKV In-Reply-To: (Reiner Steib's message of "Thu, 24 Apr 2008 20:06:30 +0200") User-Agent: Gnus/5.110009 (No Gnus v0.9) Emacs/23.0.60 X-Y-GMX-Trusted: 0 X-Spam-Score: -2.6 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:66869 Archived-At: Hi Reiner, > Thanks. I've committed it with a more verbose ChangeLog entry. Ok, now i understand what you mean by "verbose" :-) Next time my changelog proposal will be better. >> I also see some suspicious and potentially dangerous code: the > I see that it is unnecessary, but could you elaborate why it could be > dangerous and/or provide a patch? I exaggerated a little bit. But generally it's not good style to do that. If you overlook the local re-binding and make changes supporting groups, they will have no effect. I am too lazy for supplying a patch. If you are patching the next time, change it if you are in the mood for. > Or is this sufficient? It does not catch all places. Also some of the other nnir-run* have the same shadowing of the group parameter by a local let binding, but emit an error before the let binding when group is not nil. With kind regards, Christoph