[patch] mailcap.el: Error in parsing mailcap entries

[Elias Oltmanns <oltmanns@uni-bonn.de>]

[-- Attachment #1: Type: text/plain, Size: 755 bytes --]

Hi all,

in current cvs trunk, gnus' mailcap parsing has been corrupted. The
problem is that mailcap-viewer-passes-test caches its results even if
the symbol test is nil. This makes (nil nil) appear in
mailcap-viewer-test-cache and all subsequent tests for viewers that do
have a test clause of any kind will fail in consequence. The little
patch attached fixes this problem.

Additionally, I'd like to have the tests performed in
mailcap-mailcap-entry-passes-test incorporated into the caching
system. That way, you would just have to flush the cache whenever
something changes in the environment; just consider the case when you
connect to a screen session on a remote machine with emacs already
running. What do you think about that?

Regards,

Elias


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: mailcap.el-1.patch --]
[-- Type: text/x-patch, Size: 538 bytes --]

--- gnus/lisp/mailcap.el.orig	2006-01-31 02:11:48.000000000 +0100
+++ gnus/lisp/mailcap.el	2006-07-28 17:54:39.000000000 +0200
@@ -647,11 +647,11 @@
     (cond ((setq cache (assoc test mailcap-viewer-test-cache))
 	   (cadr cache))
 	  ((not test-info) t)		; No test clause
+	  ((not test) nil)		; Already failed test
 	  (t
 	   (setq
 	    result
 	    (cond
-	     ((not test) nil)		; Already failed test
 	     ((eq test t) t)		; Already passed test
 	     ((functionp test)		; Lisp function as test
 	      (funcall test type-info))