From: Romain Francoise <romain@orebokech.com>
Subject: Re: bug in message.el, message-forward-make-body-plain
Date: Wed, 01 Dec 2004 20:48:42 +0100 [thread overview]
Message-ID: <87y8ghyf39.fsf@orebokech.com> (raw)
In-Reply-To: <b9ysm6qv39v.fsf@jpl.org> (Katsumi Yamaoka's message of "Wed, 01 Dec 2004 17:19:56 +0900")
The fix looks simple enough; the problem appears to be in this change:
<URL: http://quimby.gnus.org/cgi-bin/cvsweb.cgi/gnus/lisp/message.el.diff?r1=6.377&r2=6.378>
With the following ChangeLog entry:
2003-10-29 Simon Josefsson <jas@extundo.com>
* message.el (message-forward-make-body-plain): Remove ignored
headers. Tiny patch from Andre Srinivasan <andre@e2open.com>.
(message-forward-make-body-plain): Fix ARG=1.
The test is weird:
(when (and (not current-prefix-arg)
message-forward-ignored-headers)
how can current-prefix-arg be nil since you call this function from C-u
C-c C-f? Its value is '(4) here... unless I'm missing something.
Index: message.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/message.el,v
retrieving revision 7.63
diff -u -r7.63 message.el
--- message.el 26 Nov 2004 03:07:29 -0000 7.63
+++ message.el 1 Dec 2004 19:46:41 -0000
@@ -6257,8 +6263,7 @@
(buffer-string)))
(setq e (point))
(insert
- (when (and (not current-prefix-arg)
- message-forward-ignored-headers)
+ (when message-forward-ignored-headers
(save-restriction
(narrow-to-region b e)
(goto-char b)
--
Romain Francoise <romain@orebokech.com> | Shine the headlight, straight
it's a miracle -- http://orebokech.com/ | into my eyes.
next prev parent reply other threads:[~2004-12-01 19:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-30 20:08 Ted Stern
2004-12-01 8:19 ` Katsumi Yamaoka
2004-12-01 19:15 ` Ted Stern
2004-12-01 19:48 ` Romain Francoise [this message]
2004-12-01 21:39 ` Ted Stern
2004-12-01 21:56 ` Romain Francoise
2004-12-02 8:25 ` Katsumi Yamaoka
2004-12-02 9:09 ` Romain Francoise
2004-12-19 22:26 ` Kai Grossjohann
2004-12-20 18:06 ` Ted Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y8ghyf39.fsf@orebokech.com \
--to=romain@orebokech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).