From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 14383 invoked from network); 6 May 2022 00:49:40 -0000 Received: from mx1.math.uh.edu (129.7.128.32) by inbox.vuxu.org with ESMTPUTF8; 6 May 2022 00:49:40 -0000 Received: from lists1.math.uh.edu ([129.7.128.208]) by mx1.math.uh.edu with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nmmA5-003Zvq-R7 for ml@inbox.vuxu.org; Thu, 05 May 2022 19:49:37 -0500 Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by lists1.math.uh.edu with smtp (Exim 4.94.2) (envelope-from ) id 1nmmA5-008JaN-9E for ml@inbox.vuxu.org; Thu, 05 May 2022 19:49:37 -0500 Received: from mx1.math.uh.edu ([129.7.128.32]) by lists1.math.uh.edu with esmtp (Exim 4.94.2) (envelope-from ) id 1nmmA3-008JaE-3f for ding@lists.math.uh.edu; Thu, 05 May 2022 19:49:35 -0500 Received: from quimby.gnus.org ([95.216.78.240]) by mx1.math.uh.edu with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nmm9z-003ZvW-AA for ding@lists.math.uh.edu; Thu, 05 May 2022 19:49:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:Mime-Version:References:Message-ID:Date:Subject: From:To:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Q4mUjlhx8U/H/hps2xJ1jCORGJCcgY0+k7ZLO8o84Yg=; b=Pj8rXxDdqLuzHsyvBZyuGBEh1j 4wz1ExZ4bG6lvS4pDfoltdp9gKOvT6sWQxFEzXw6DUNfBeVelOAHfOLIy3QbQnPy/4P20QSwOQzDU XayYN2O74DVIQM9ESh9rlDMHcQjDqJgEs8j8UFaFbz0kg90ryR5/4HsnbEAMN71CyzQg=; Received: from ciao.gmane.io ([116.202.254.214]) by quimby.gnus.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmm9p-0000D1-0y for ding@gnus.org; Fri, 06 May 2022 02:49:24 +0200 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1nmm9n-0005XV-El for ding@gnus.org; Fri, 06 May 2022 02:49:19 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: ding@gnus.org From: Andrew Cohen Subject: Re: expiring in nnselect groups not saved Date: Fri, 06 May 2022 08:49:11 +0800 Message-ID: <87zgjvzdrs.fsf@ust.hk> References: <87ee1bbaw6.fsf@dataswamp.org> <87mtfx4iuv.fsf_-_@ecocode.net> <87o80dqlk1.fsf@ericabrahamsen.net> <8735hp0y2b.fsf@ecocode.net> <87o80c6ceq.fsf@ust.hk> <87mtfwwarb.fsf@ecocode.net> <87h764tfty.fsf@ecocode.net> <87pmksqlqb.fsf@ecocode.net> <87wnf0p6n0.fsf@ecocode.net> <87fsloyxvy.fsf@ecocode.net> <87zgjvzoeu.fsf@ecocode.net> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cancel-Lock: sha1:n6jRh0V+0Pz9zcB72tvEoOK7Ubc= List-ID: Precedence: bulk >>>>> "EC" == Erik Colson writes: EC> Hi, I think I got something ... When I create an "permanent" EC> nnselect group with Gg, all expiry flags get saved in all EC> groups. When I create an ephemeral search group with GG they EC> only get saved in one group, which I cannot seem to figure why. OK, I think I found the bug. There is ancient code (from 10 years ago when nnir groups weren't supposed to do any expiry) which special cases expirable marks to prevent unexpected expiry. This code is obsolete and should be removed, I think. But it's from so long ago I hardly remember why I added it. Erik, can you test this? Replace the current function 'nnselect-request-update-mark with the one below: (deffoo nnselect-request-update-mark (_group article mark) (let* ((artgroup (nnselect-article-group article)) (artnumber (nnselect-article-number article)) (gmark (gnus-request-update-mark artgroup artnumber mark))) gmark)) -- Andrew Cohen