Re: saving registry is fixed, but gnorb still can't gnorb-org-view

[Eric Abrahamsen <eric@ericabrahamsen.net>]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> hobbes@poukram.net (Rémi Letot) writes:
>
>> hobbes@poukram.net writes:
>>
>>> Hello,
>>>
>>> this is what happens when I push s while in the group buffer:
>>
>> I quit gnus without saving newsrc, then restarted, and that problem is
>> gone. I probably lost some registry entries, some recent links between
>> org headings and gnus messages, but that's not a big problem.
>>
>> However this one is still there:
>>
>>> Also, might be related, gnorb-org-view (C-c v) on most (if not all) org
>>> entries linked to mails produces the following:
>>>
>>> Debugger entered--Lisp error: (wrong-type-argument arrayp nil)
>>>   replace-regexp-in-string("\\(\\\\+\\)\\(?:\\'\\|[][]\\)" (closure
>>> ((link) org-ts-regexp org-time-stamp-formats org-src-source-file-name
>>> org-outline-regexp-bol org-inhibit-startup org-id-link-to-org-use-id
>>> org-highlight-links org-comment-string org-agenda-buffer-name
>>> clean-buffer-list-kill-buffer-names t) (_) (concat (make-string (/ (-
>>> (match-end 1) (match-beginning 1)) 2) 92))) nil nil t 1)
>>>   org-link-unescape(nil)
>>>   nnir-run-gnorb(((query .
>>> "id+6d3a4ef0-2748-409f-8607-a26112ea4353")) "nngnorb:Org tracking"
>
> What should be happening in this situation is that the code visits
> whatever subtree has ID "6d3a4ef0-2748-409f-8607-a26112ea4353", then
> collects all links of type "gnus:". Those links should look like:
>
> gnus:gmane.emacs.gnus.general#87y2rec48a.fsf@sphax
>
> Then each link is split on "#", and the second section (a message ID) is
> run through `org-link-unescape'.
>
> In your case, there's a link that has no message ID part. You could take
> a look at the Org tree in question and see which it is, and if you know
> how that link might have been created (or mangled).

Ooh, I might be wrong -- I got bitten by Org's changing link-related
regular expressions, and fixed some code for the new regexps, and
apparently wasn't careful enough with the fix. I'm assuming in your
subtree there's a "plain" link to a Gnus message, ie one that isn't
wrapped in brackets. Would you eval the function below and see if it
fixes the problem?

(defun gnorb-scan-links (bound &rest types)
  (unless (= (point) bound)
    (let ((alist (mapcar #'list (copy-sequence types))))
      (while (re-search-forward org-link-any-re bound t)
	(pcase-let* ((`(,type ,link) (split-string
				      (or
				       (match-string-no-properties 2)
				       (match-string-no-properties 0))
				      ":"))
		     (sym (intern-soft type)))
	  (when (and sym (memq sym types))
	    (push link (alist-get sym alist)))))
      alist)))