From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/83046 Path: news.gmane.org!not-for-mail From: David Engster Newsgroups: gmane.emacs.gnus.general Subject: Re: iCalendar support: reply to invitations, sync to org Date: Thu, 04 Apr 2013 00:01:50 +0200 Message-ID: <87zjxf46k1.fsf@randomsample.de> References: <5n5x2r38v8y3nk.fsf@nb-jtatarik2.xing.hh> <87d2ub63e0.fsf@randomsample.de> <5n5x2rppyb5mom.fsf@nb-jtatarik2.xing.hh> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1365026535 31257 80.91.229.3 (3 Apr 2013 22:02:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 3 Apr 2013 22:02:15 +0000 (UTC) Cc: ding@gnus.org To: Jan Tatarik Original-X-From: ding-owner+M31312@lists.math.uh.edu Thu Apr 04 00:02:40 2013 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UNVlL-00058D-4G for ding-account@gmane.org; Thu, 04 Apr 2013 00:02:35 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1UNVkj-00079j-KZ; Wed, 03 Apr 2013 17:01:57 -0500 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1UNVkg-00079T-Rw for ding@lists.math.uh.edu; Wed, 03 Apr 2013 17:01:54 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) (envelope-from ) id 1UNVkf-0005iU-8S for ding@lists.math.uh.edu; Wed, 03 Apr 2013 17:01:54 -0500 Original-Received: from randomsample.de ([83.169.19.17]) by quimby.gnus.org with esmtp (Exim 4.72) (envelope-from ) id 1UNVkd-0005Ig-No for ding@gnus.org; Thu, 04 Apr 2013 00:01:51 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=randomsample.de; s=a; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=gnjZ3YZKvlGATZSRs2Z1cJd4ilRQ7vimtvSzXdiuMr8=; b=f0oSFBDrUqI98DFeQ9Nk3t3j0q4x+KZkjnEAKQokngJACrtAYvfZo9RhAB8qGV4atbru0mla1na64YjBf23JAG9MzL5HC4Vci6qxH/3mS8ORsl1Ice0Of/GJmt2FM4KN; Original-Received: from dslc-082-083-051-055.pools.arcor-ip.net ([82.83.51.55] helo=spaten) by randomsample.de with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1UNVkd-0008UH-7G; Thu, 04 Apr 2013 00:01:51 +0200 In-Reply-To: <5n5x2rppyb5mom.fsf@nb-jtatarik2.xing.hh> (Jan Tatarik's message of "Wed, 03 Apr 2013 23:28:09 +0200") User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3 (gnu/linux) Mail-Copies-To: never Mail-Followup-To: Jan Tatarik , ding@gnus.org X-Spam-Score: -4.3 (----) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:83046 Archived-At: Jan Tatarik writes: > On Wed, Apr 03 2013, David Engster wrote: >> Jan, would you be interested in that? As you probably know, this would >> require that you assign copyright of your code to the FSF and to sign >> papers. Also, your code would need some changes to be compatible with >> older Emacsen. > > My papers for emacs and gnus are already on file. That's great. > As far as making the code compatible, I would appreciate some guidance > there. Not just wrt older Emacsen, but also regarding coding > conventions, namespace, etc. A good first read is the Appendix D.1 (Emacs Lisp Coding Conventions) in the Emacs Lisp reference manual. I haven't looked at your code in detail yet. But a first few comments: The first and for you probably most frustrating problem is the dependence on cl-lib, which is only available since 24.3. On older Emacsen you only have 'cl', from which you're only allowed to use macros, though (see the mentioned coding conventions for further details). So I'm afraid you have to forgo the functions (but not macros) you use from cl-lib. EIEIO is OK, though; Gnus provides a fallback library for that on older Emacsen. Your package is a bit complicated since it involves three things: icalendar, Gnus and Org. Still, I think it would be preferable to have everything in a single file with a single namespace 'gnus-calendar'. Everything should be prefixed with that; this includes methods and macros (like your currently used `with-decoded-handle'). If you think that some of your stuff would better fit in the icalendar package, Org, or somewhere else in Gnus, then we should try to get this in there. Also, M-x checkdoc is very helpful. :-) -David