Gnus development mailing list
 help / color / mirror / Atom feed
From: Ted Zlatanov <tzz@lifelogs.com>
To: Martin Stjernholm <mast@lysator.liu.se>
Cc: ding@gnus.org
Subject: Re: Patch: Support for non-ascii characters in imap group names
Date: Sat, 20 Mar 2010 10:45:57 -0500	[thread overview]
Message-ID: <87zl23dmiy.fsf@lifelogs.com> (raw)
In-Reply-To: <7m635qutf5.fsf@kolon.stjernholm.org> (Martin Stjernholm's message of "Sun, 21 Feb 2010 23:15:42 +0100")

On Sun, 21 Feb 2010 23:15:42 +0100 Martin Stjernholm <mast@lysator.liu.se> wrote: 

MS> [Sent this some time ago but I suspect it got caught in a spam queue, so
MS> I'm trying again. I apologize if it's a duplicate.]

Thank you, it was my fault for ignoring it.

MS> Hello, this patch should fix the long-standing problem with non-ascii
MS> characters in imap group names (see e.g.
MS> http://thread.gmane.org/gmane.emacs.gnus.general/67087 and
MS> http://thread.gmane.org/gmane.emacs.gnus.general/67209).

I know you have Emacs papers.  I don't know if you need Gnus papers as
well (since you can contribute to Gnus through Emacs).  So I'm comitting
the patch but Reiner should comment; I hope it doesn't need to be
reverted.  You can always sign the Gnus papers as well to be certain.

MS> It is done by making the nnimap back end support
MS> `gnus-group-name-charset-group-alist' and
MS> `gnus-group-name-charset-method-alist'. To allow non-ascii groups it's
MS> therefore necessary to configure them to use a sufficiently expressive
MS> coding system, e.g. UTF-8. The default value for
MS> `gnus-group-name-charset-group-alist' accomplishes that.

I agree this is a clumsy fix but don't want to reengineer the groups and
the agent for this.  I do think, however, that this could be a target
for a more ambitious Gnus rewrite that uses the newer Emacs features
added since version 20 or so :)

I'm not sure why you need

	(nnimap-close-group): Call `imap-current-mailbox' instead of using the
	variable `imap-current-mailbox'.

but left it in, assuming it was sensible.

Gnus folk, please test this if you can.  It may break other Gnus pieces
that assume an unencoded group name, but the way it's done seems to be
clean to me.

Thanks
Ted



       reply	other threads:[~2010-03-20 15:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <7mljev50dc.fsf@kolon.stjernholm.org>
     [not found] ` <7m635qutf5.fsf@kolon.stjernholm.org>
2010-03-20 15:45   ` Ted Zlatanov [this message]
2010-03-21 17:00     ` Martin Stjernholm
2010-03-21 18:49       ` Ted Zlatanov
2010-03-21 20:26         ` Martin Stjernholm
2010-03-22 10:16           ` Ted Zlatanov
2010-03-22  7:49       ` Reiner Steib

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zl23dmiy.fsf@lifelogs.com \
    --to=tzz@lifelogs.com \
    --cc=ding@gnus.org \
    --cc=mast@lysator.liu.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).