From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/63582 Path: news.gmane.org!not-for-mail From: Andreas Seltenreich Newsgroups: gmane.emacs.gnus.general Subject: Re: backporting bugfixes to the v5-10 branch Date: Wed, 23 Aug 2006 06:20:11 +0200 Message-ID: <87zmdwrslg.fsf@gate450.dyndns.org> References: <87wtajwzjk.fsf@gate450.dyndns.org> <87wta86vzr.fsf@gate450.dyndns.org> <878xlh6xmm.fsf@gate450.dyndns.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1156307118 18260 80.91.229.2 (23 Aug 2006 04:25:18 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 23 Aug 2006 04:25:18 +0000 (UTC) Original-X-From: ding-owner+m12109@lists.math.uh.edu Wed Aug 23 06:25:17 2006 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GFkIg-0003nw-RY for ding-account@gmane.org; Wed, 23 Aug 2006 06:25:11 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1GFkIb-0003TB-00; Tue, 22 Aug 2006 23:25:05 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1GFkDx-0003T6-00 for ding@lists.math.uh.edu; Tue, 22 Aug 2006 23:20:17 -0500 Original-Received: from quimby.gnus.org ([80.91.227.211]) by mx1.math.uh.edu with esmtp (Exim 4.52) id 1GFkDu-0002ZP-Dw for ding@lists.math.uh.edu; Tue, 22 Aug 2006 23:20:17 -0500 Original-Received: from smtp1.rz.uni-karlsruhe.de ([129.13.185.217] ident=Debian-exim) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1GFkDt-0007z7-00 for ; Wed, 23 Aug 2006 06:20:13 +0200 Original-Received: from rzstud2.stud.uni-karlsruhe.de (exim@rzstud2.stud.uni-karlsruhe.de [193.196.41.38]) by smtp1.rz.uni-karlsruhe.de with esmtp (Exim 4.50 #1) id 1GFkDt-00022V-AB; Wed, 23 Aug 2006 06:20:13 +0200 Original-Received: from uwi7 by rzstud2.stud.uni-karlsruhe.de with local (Exim 4.43) id 1GFkDs-0004e4-OG for ding@gnus.org; Wed, 23 Aug 2006 06:20:12 +0200 Original-To: ding@gnus.org X-Face: $:F<87a[gD1?#R6S3j21cr1&C&7bd63GHC.tSdskUb}hhwG(ci*=D5kJ<_N+p9q(7-,PnG. Et.Yh Reiner Steib writes: > On Tue, Aug 22 2006, Andreas Seltenreich wrote: > >> Andreas Seltenreich writes: >>> Reiner Steib writes: >>>> On Wed, Jul 12 2006, Andreas Seltenreich wrote: >>>> >>>>> I'm not sure what to do with the change to gnus-find-method-for-group: >>>>> >>>>> * gnus.el (gnus-find-method-for-group): On killed/unknown groups, try >>>>> looking up the method using GROUP's prefix before inventing a new one. >>>>> It is used on killed/unknown groups in various places where returning >>>>> an all-new method isn't expected by the caller. >>>>> >>>>> While I can reproduce all of the bugs listed in >>>>> on a stable Gnus, >>>> >>>> ... and the fix as well, I guess? >>> >>> Ack, I was unable to trigger the bugs anymore on v5-10 with the fix >>> merged in. >> [...] >>> Btw, testing with the agent enabled revealed two places where >>> g-f-m-f-g is called on groups after their prefix has been stripped, >>> causing the native method to be returned. I don't think this is >>> intentional, is it? >>> >>> [backtraces] > > Is this problem related to your change or not? Negative, the new g-f-m-f-g doesn't change semantics in this case (no prefix & no newsrc entry => primary method). > Could you please summarize this problem again, Cc-ing Kevin Greiner > and ask for his advise/opinion. Will do so in a separate mail. >> While I'm very confident that the change to g-f-m-f-g won't cause any >> regressions, I do not /know/ that it won't. Especially with respect >> to the agent. > > I don't have time to look at the code, but as the code is installed > the trunk since 2006-06-25, it probably is sufficient testing (as the > agent is enabled by default) by now to be installed in the trunk as > well. > >> With Emacs pretest approaching, I'm still reluctant to commit it to >> v5-10, and unless someone raises a more knowledgeable opinion, I'll >> leave it on the trunk. > > After all, your changes fixed some problems still present in > v5-10/Emacs CVS, so I'd say install it in v5-10 now. Ok, I'll install it after some more testing. regards, andreas