Re: PATCH: Make nnrss fail gracefully when it can't fetch a feed

[Mark Plaksin <happy@usg.edu>]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

>>>>>> In <87r785nsu6.fsf@stone.tss.usg.edu>
>>>>>>	Mark Plaksin <happy@usg.edu> wrote:
>
>> Katsumi Yamaoka <yamaoka@jpl.org> writes:
>
>>>> -	  (mm-url-insert url)))
>>>> +          (condition-case nil
>>>> +              (mm-url-insert url)
>>>> +            (error (nnheader-message 3 "nnrss: Failed to fetch %s" url)))))
>>>
>>> Isn't it better to use just `message' since it is obviously an
>>> error?  And also (sit-for N) might be required.
>
> I meant we can use `message' instead of `nnheader-message' there
> as the following:
>
> (condition-case nil
>     (mm-url-insert url)
>   (error (message "nnrss: Failed to fetch %s" url)))
>
> I never said that we should use `error' instead of
> `nnheader-message'.

OK, I misread or misunderstood.  `message' sounds good to me!

mm-url-insert is also called in nnrss-insert-w3.  I guess there should be a
condition-case there too but I don't understand what nnrss-insert-w3 is for.