From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/61616 Path: news.gmane.org!not-for-mail From: Mark Plaksin Newsgroups: gmane.emacs.gnus.general Subject: Re: PATCH: Make nnrss fail gracefully when it can't fetch a feed Date: Sat, 31 Dec 2005 10:49:47 -0500 Message-ID: <87zmmhfeqs.fsf@stone.tss.usg.edu> References: <87y82e1gg2.fsf@stone.tss.usg.edu> <87r785nsu6.fsf@stone.tss.usg.edu> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1136045137 17904 80.91.229.2 (31 Dec 2005 16:05:37 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 31 Dec 2005 16:05:37 +0000 (UTC) Original-X-From: ding-owner+m10148@lists.math.uh.edu Sat Dec 31 17:05:35 2005 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EsjEd-0002un-0H for ding-account@gmane.org; Sat, 31 Dec 2005 17:05:35 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1EsjEZ-0003Hd-00; Sat, 31 Dec 2005 10:05:31 -0600 Original-Received: from nas02.math.uh.edu ([129.7.128.40]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1Esiza-0003Gx-00 for ding@lists.math.uh.edu; Sat, 31 Dec 2005 09:50:02 -0600 Original-Received: from quimby.gnus.org ([80.91.224.244]) by nas02.math.uh.edu with esmtp (Exim 4.52) id 1EsizV-00008X-S8 for ding@lists.math.uh.edu; Sat, 31 Dec 2005 09:50:02 -0600 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1EsizU-0003Jv-00 for ; Sat, 31 Dec 2005 16:49:56 +0100 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1EsizS-0000Ig-Cg for ding@gnus.org; Sat, 31 Dec 2005 16:49:54 +0100 Original-Received: from stone.tss.usg.edu ([168.24.82.77]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 31 Dec 2005 16:49:54 +0100 Original-Received: from happy by stone.tss.usg.edu with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 31 Dec 2005 16:49:54 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-To: ding@gnus.org Original-Lines: 29 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: stone.tss.usg.edu User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0 (gnu/linux) Cancel-Lock: sha1:n3B9/hhCnbfhqxpDkJGnv0kuvbo= X-Spam-Score: -2.5 (--) Precedence: bulk Original-Sender: ding-owner@lists.math.uh.edu Xref: news.gmane.org gmane.emacs.gnus.general:61616 Archived-At: Katsumi Yamaoka writes: >>>>>> In <87r785nsu6.fsf@stone.tss.usg.edu> >>>>>> Mark Plaksin wrote: > >> Katsumi Yamaoka writes: > >>>> - (mm-url-insert url))) >>>> + (condition-case nil >>>> + (mm-url-insert url) >>>> + (error (nnheader-message 3 "nnrss: Failed to fetch %s" url))))) >>> >>> Isn't it better to use just `message' since it is obviously an >>> error? And also (sit-for N) might be required. > > I meant we can use `message' instead of `nnheader-message' there > as the following: > > (condition-case nil > (mm-url-insert url) > (error (message "nnrss: Failed to fetch %s" url))) > > I never said that we should use `error' instead of > `nnheader-message'. OK, I misread or misunderstood. `message' sounds good to me! mm-url-insert is also called in nnrss-insert-w3. I guess there should be a condition-case there too but I don't understand what nnrss-insert-w3 is for.