Wrong type argument: stringp when Generating cus-load.el

Wrong type argument: stringp when Generating cus-load.el

[Andi Hechtbauer]

Hi,

from time to time I do a clean compile of CVS gnus, as I usually just
"make some".  But this morning (and up til now, using the freshest CVS
gnus) the procedure "make distclean; ./configure; make" broke at
making gnus-load.el:

 $ make
 cd lisp && make EMACS="emacs" lispdir="/usr/share/emacs/site-lisp" all
 make[1]: Entering directory `/home/anti/lib/emacs/pgnus/lisp'
 rm -f *.elc gnus-load.el
 URLDIR=no W3DIR=no lispdir=/usr/share/emacs/site-lisp srcdir=. emacs -batch -q -no-site-file -l ./dgnushack.el -f dgnushack-make-cus-load .
 Loading cus-dep...
 Directory .
 Generating cus-load.el...
 Wrong type argument: stringp, (mm-inline-text-html-with-w3m-keymap custom-variable)
 make[1]: *** [gnus-load.el] Error 255
 make[1]: Leaving directory `/home/anti/lib/emacs/pgnus/lisp'
 make: *** [lick] Error 2

This is after I configured away url and w3, having them activated
makes no difference.

Is this obvious to one of you?  Has anyone seen the same thing and can
shed some light on a lisp-dummy?

Thanks for looking,

Andi

Re: Wrong type argument: stringp when Generating cus-load.el

[Katsumi Yamaoka]

>>>>> In <m3n0omi0tt.fsf@hic.hq.spin.de>
>>>>>	Andi Hechtbauer <anti@spin.de> wrote:

> from time to time I do a clean compile of CVS gnus, as I usually just
> "make some".  But this morning (and up til now, using the freshest CVS
> gnus) the procedure "make distclean; ./configure; make" broke at
> making gnus-load.el:

>  $ make
>  cd lisp && make EMACS="emacs" lispdir="/usr/share/emacs/site-lisp" all
>  make[1]: Entering directory `/home/anti/lib/emacs/pgnus/lisp'
>  rm -f *.elc gnus-load.el
>  URLDIR=no W3DIR=no lispdir=/usr/share/emacs/site-lisp srcdir=. emacs -batch -q -no-site-file -l ./dgnushack.el -f dgnushack-make-cus-load .
>  Loading cus-dep...
>  Directory .
>  Generating cus-load.el...
>  Wrong type argument: stringp, (mm-inline-text-html-with-w3m-keymap custom-variable)

Well, I have surely seen that somewhere, however it has slipped
my memory.  It is all that I remembered emacs-w3m is unrelated
to such a problem.  Didn't you use the alpha version of Emacs?
-- 
Katsumi Yamaoka <yamaoka@jpl.org>

Re: Wrong type argument: stringp when Generating cus-load.el

[Manoj Srivastava]

Hi,
>>"Katsumi" == Katsumi Yamaoka <yamaoka@jpl.org> writes:

 Katsumi> Well, I have surely seen that somewhere, however it has slipped
 Katsumi> my memory.  It is all that I remembered emacs-w3m is unrelated
 Katsumi> to such a problem.  Didn't you use the alpha version of Emacs?

	I submitted a bug report about it a couple of weeks ago. And
 no, I was not using the alpha version of emacs either.

	I have been using a non-byte-compiled version for some time
 now.

	manoj
-- 
 Sometimes I simply feel that the whole world is a cigarette and I'm
 the only ashtray.
Manoj Srivastava   <srivasta@acm.org>  <http://www.datasync.com/%7Esrivasta/>
1024R/C7261095 print CB D9 F4 12 68 07 E4 05  CC 2D 27 12 1D F5 E8 6E
1024D/BF24424C print 4966 F272 D093 B493 410B  924B 21BA DABB BF24 424C

Re: Wrong type argument: stringp when Generating cus-load.el

[Katsumi Yamaoka]

[-- Attachment #1: Type: text/plain, Size: 869 bytes --]

>>>>> In <873cqdbxts.fsf@glaurung.green-gryphon.com>
>>>>>	Manoj Srivastava <srivasta@acm.org> wrote:

Katsumi> Well, I have surely seen that somewhere, however it has slipped
Katsumi> my memory.  It is all that I remembered emacs-w3m is unrelated
Katsumi> to such a problem.  Didn't you use the alpha version of Emacs?

>      I submitted a bug report about it a couple of weeks ago. And
> no, I was not using the alpha version of emacs either.

>      I have been using a non-byte-compiled version for some time
> now.

Oh, that's too bad.  Possibly it was your report which I looked
at.  Could you try the following work?  And please show us the
Lisp backtrace if it appears.

Run Emacs in the Gnus source directory.

% cd Gnus-source/lisp
% emacs-21.2 -q -no-site-file&

Copy the following lines into the *scratch* buffer and type C-j
at the end of the last line.


[-- Attachment #2: Type: application/emacs-lisp, Size: 250 bytes --]

[-- Attachment #3: Type: text/plain, Size: 81 bytes --]


;; It may not finish only with this work.
-- 
Katsumi Yamaoka <yamaoka@jpl.org>

Re: Wrong type argument: stringp when Generating cus-load.el

[Andi Hechtbauer]

>>>>> On Thu, 07 Nov 2002 18:07:46 +0900, Katsumi Yamaoka <yamaoka@jpl.org> said:

    Katsumi> Run Emacs in the Gnus source directory.

$ emacs --version
GNU Emacs 21.2.2
[...]

    Katsumi> % cd Gnus-source/lisp % emacs-21.2 -q -no-site-file&

    Katsumi> Copy the following lines into the *scratch* buffer and
    Katsumi> type C-j at the end of the last line.

,----
| (progn
|   (setq debug-on-error t
|         command-line-args-left '("."))
|   (load "cus-dep.el" nil nil t)
|   (let ((ke (symbol-function 'kill-emacs)))
|     (fset 'kill-emacs 'ignore)
|     (unwind-protect
|         (custom-make-dependencies)
|       (fset 'kill-emacs ke))))
`----

Gives me this *Backtrace*:

Debugger entered--Lisp error: (file-error "Cannot open load file" "cus-dep.el")
  load("cus-dep.el" nil nil t)
  (progn (setq debug-on-error t command-line-args-left (quote ...)) (load "cus-dep.el" nil nil t) (let (...) (fset ... ...) (unwind-protect ... ...)))
  eval((progn (setq debug-on-error t command-line-args-left (quote ...)) (load "cus-dep.el" nil nil t) (let (...) (fset ... ...) (unwind-protect ... ...))))
  eval-last-sexp-1(t)
  eval-last-sexp(t)
  eval-print-last-sexp()
  call-interactively(eval-print-last-sexp)

Well - there is no such file, so that seems clear to me.

Thanks for your help,

Andi

Re: Wrong type argument: stringp when Generating cus-load.el

[Katsumi Yamaoka]

>>>>> In <m3of91lhdx.fsf@hic.hq.spin.de>
>>>>>	Andi Hechtbauer <anti@spin.de> wrote:

> Debugger entered--Lisp error: (file-error "Cannot open load file" "cus-dep.el")
>   load("cus-dep.el" nil nil t)

Eh?  But you wrote in the last article as follows:

> $ make
> cd lisp && make EMACS="emacs" lispdir="/usr/share/emacs/site-lisp" all
> make[1]: Entering directory `/home/anti/lib/emacs/pgnus/lisp'
> rm -f *.elc gnus-load.el
> URLDIR=no W3DIR=no lispdir=/usr/share/emacs/site-lisp srcdir=. emacs -batch -q -no-site-file -l ./dgnushack.el -f dgnushack-make-cus-load .
> Loading cus-dep...
> Directory .
> Generating cus-load.el...
> Wrong type argument: stringp, (mm-inline-text-html-with-w3m-keymap custom-variable)

Isn't there the file /usr/share/emacs/21.2/lisp/cus-dep.el?  If
there's only cus-dep.elc, it makes debugging difficult.  And
your problem is not solved yet.  I will send you the real
cus-dep.el for Emacs 21.2 if necessary.
-- 
Katsumi Yamaoka <yamaoka@jpl.org>

Re: Wrong type argument: stringp when Generating cus-load.el

[Andi Hechtbauer]

Ok,

    Katsumi> Isn't there the file
    Katsumi> /usr/share/emacs/21.2/lisp/cus-dep.el?  If there's only
    Katsumi> cus-dep.elc, it makes debugging difficult.

I just installed the .el files.  Hopefully this is a more interessting
Backtrace now:

Debugger entered--Lisp error: (wrong-type-argument stringp (mm-inline-text-html-with-w3m-keymap custom-variable))
  string<((mm-inline-text-html-with-w3m-keymap custom-variable) (mm-inline-text-html-with-images custom-variable))
  sort(((mm-text-html-renderer custom-variable)) string<)
  (setq members (sort members (quote string<)))
  (progn (setq members (sort members ...)) (while members (setq item ... members ... where ...) (unless ... ... ... ...)) (when found (insert "))\n")))
  (if members (progn (setq members ...) (while members ... ...) (when found ...)))
  (when members (setq members (sort members ...)) (while members (setq item ... members ... where ...) (unless ... ... ... ...)) (when found (insert "))\n")))
  (let ((members ...) item where found) (when members (setq members ...) (while members ... ...) (when found ...)))
  (lambda (symbol) (let (... item where found) (when members ... ... ...)))(mime-display)
  mapatoms((lambda (symbol) (let (... item where found) (when members ... ... ...))))
  custom-make-dependencies()
  (unwind-protect (custom-make-dependencies) (fset (quote kill-emacs) ke))
  (let ((ke ...)) (fset (quote kill-emacs) (quote ignore)) (unwind-protect (custom-make-dependencies) (fset ... ke)))
  (progn (setq debug-on-error t command-line-args-left (quote ...)) (load "cus-dep.el" nil nil t) (let (...) (fset ... ...) (unwind-protect ... ...)))
  eval((progn (setq debug-on-error t command-line-args-left (quote ...)) (load "cus-dep.el" nil nil t) (let (...) (fset ... ...) (unwind-protect ... ...))))
  eval-last-sexp-1(t)
  eval-last-sexp(t)
  eval-print-last-sexp()
  call-interactively(eval-print-last-sexp)

Thanks again,

Andi

Re: Wrong type argument: stringp when Generating cus-load.el

[Katsumi Yamaoka]

>>>>> In <87ptth35la.fsf@pod.hq.spin.de> 
>>>>>	Andi Hechtbauer <anti@spin.de> wrote:

> I just installed the .el files.  Hopefully this is a more interessting
> Backtrace now:

I see.  That file is the thing of Emacs 21.3.50, and, moreover,
there is a bug.

> Debugger entered--Lisp error: (wrong-type-argument stringp (mm-inline-text-html-with-w3m-keymap custom-variable))
[...]
>   (setq members (sort members (quote string<)))

It has been fixed by RMS as follows:

2002-09-19  Richard M. Stallman  <rms@gnu.org>

	* cus-dep.el (custom-make-dependencies): Fix previous change.

2002-09-18  Richard M. Stallman  <rms@gnu.org>
[...]
	* cus-dep.el (custom-make-dependencies): Sort MEMBERS before use.
-- 
Katsumi Yamaoka <yamaoka@jpl.org>

Re: Wrong type argument: stringp when Generating cus-load.el

[Andi Hechtbauer]

Hi,

[CVS gnus wouldn't compile with cus-dep.el(c) in emacs21(-el) 21.2-5]

    Andi> I just installed the .el files.  Hopefully this is a more
    Andi> interessting Backtrace now: [...]

    Katsumi> I see.  That file is the thing of Emacs 21.3.50, and,
    Katsumi> moreover, there is a bug.

Hm, if that is true, debian is to blame.  Or me, living on the
unstable edge ;-)

Rob Browning <rlb@defaultvalue.org> (Cc set) packaged this file with
emacs21-el Version 21.2-5 -- the file itself has no hint about
version.  And changelog.Debian.gz isn't suggesting this, either.

M-x version tells me I'd be running 21.2.2.

Checking with a freshly downloaded 21.2 tarball shows this:

.../emacs-21.2/lisp$ diff cus-dep.el ~/tmp/cus-dep.el-debian 
38c38
<       (all-subdirs command-line-args-left)
---
>       (all-subdirs (sort command-line-args-left 'string<))
88a89,90
>                   ;; So x and no-x builds won't differ.
>                   (setq members (sort members 'string<))

so obviously the debian maintainer applied a patch.

    Andi> Debugger entered--Lisp error: (wrong-type-argument stringp
    Andi> (mm-inline-text-html-with-w3m-keymap custom-variable))

    Andi> (setq members (sort members (quote string<)))

    Katsumi> It has been fixed by RMS as follows:

,----
| 2002-09-19  Richard M. Stallman  <rms@gnu.org>
| 
| 	* cus-dep.el (custom-make-dependencies): Fix previous change.
| 
| 2002-09-18  Richard M. Stallman  <rms@gnu.org>
| [...]
| 	* cus-dep.el (custom-make-dependencies): Sort MEMBERS before use.
`----

After replacing the debian cus-dep.el with the tarball one, and byte
compiling cus-dep.el, cvs gnus compiles as expected.

Thank you so much for looking into this!

Andi

Re: Wrong type argument: stringp when Generating cus-load.el

[Rob Browning]

Andi Hechtbauer <anti@spin.de> writes:

> Hi,
>
> [CVS gnus wouldn't compile with cus-dep.el(c) in emacs21(-el) 21.2-5]
>
>     Andi> I just installed the .el files.  Hopefully this is a more
>     Andi> interessting Backtrace now: [...]
>
>     Katsumi> I see.  That file is the thing of Emacs 21.3.50, and,
>     Katsumi> moreover, there is a bug.
>
> Hm, if that is true, debian is to blame.  Or me, living on the
> unstable edge ;-)

Well it's actually debian including a patch that's also been included
upstream.  It was a patch to fix things so that emacs built
--with-x=yes and emacs --with-x=no wouldn't have spurious differences
in some of its files.

I wrote the patch initially and RMS included it upstream, but I had
the same build problem here when I tried to compile the latest gnus.
I haven't have time to fully investigate, but what I did find out was
that the problem can be fixed by removing the "members sort".  The
all-subdirs sort doesn't seem to cause trouble.

> Rob Browning <rlb@defaultvalue.org> (Cc set) packaged this file with
> emacs21-el Version 21.2-5 -- the file itself has no hint about
> version.  And changelog.Debian.gz isn't suggesting this, either.

If you look in /usr/share/doc/emacsen21-common/README.Debian.gz, it
mentions the relevant patch near the end.  You can "apt-get source
emacs21" and look in debian/patch to see the actual diff, or just grab
the debian diff file.

> ,----
> | 2002-09-19  Richard M. Stallman  <rms@gnu.org>
> | 
> | 	* cus-dep.el (custom-make-dependencies): Fix previous change.
> | 
> | 2002-09-18  Richard M. Stallman  <rms@gnu.org>
> | [...]
> | 	* cus-dep.el (custom-make-dependencies): Sort MEMBERS before use.
> `----

I'll need to see what RMS changed back and fix that here too.

-- 
Rob Browning
rlb @defaultvalue.org, @linuxdevel.com, and @debian.org
Previously @cs.utexas.edu

Re: Wrong type argument: stringp when Generating cus-load.el

[Katsumi Yamaoka]

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

Hi,

>>>>> In <87adklurpa.fsf@raven.i.defaultvalue.org>
>>>>>	Rob Browning <rlb@defaultvalue.org> wrote:

> I'll need to see what RMS changed back and fix that here too.

Here are the past record of cus-dep.el in Emacs CVS.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 400 bytes --]

--- cus-dep.el-20020917	2001-07-16 12:22:58 +0000
+++ cus-dep.el-20020918	2002-09-18 16:01:21 +0000
@@ -86,6 +86,8 @@
 	      (let ((members (get symbol 'custom-group))
 		    item where found)
 		(when members
+		  ;; So x and no-x builds won't differ.
+		  (setq members (sort (copy-sequence members) 'string<))
 		  (while members
 		    (setq item (car (car members))
 			  members (cdr members)

[-- Attachment #3: Type: text/plain, Size: 1 bytes --]



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #4: Type: text/x-patch, Size: 739 bytes --]

--- cus-dep.el-20020918	2002-09-18 16:01:21 +0000
+++ cus-dep.el-20020919	2002-09-19 18:57:48 +0000
@@ -87,7 +87,17 @@
 		    item where found)
 		(when members
 		  ;; So x and no-x builds won't differ.
-		  (setq members (sort (copy-sequence members) 'string<))
+		  (setq members
+			(sort (copy-sequence members) 
+			      (lambda (x y)
+				(cond ((and (stringp x) (stringp y))
+				       (string< x y))
+				      ;; Put all non-strings before strings.
+				      ((stringp y) t)
+				      ((stringp x) nil)
+				      ;; For two non-strings,
+				      ;; use the order they appear in MEMBERS.
+				      (t (member y (member x members)))))))
 		  (while members
 		    (setq item (car (car members))
 			  members (cdr members)

[-- Attachment #5: Type: text/plain, Size: 1 bytes --]



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #6: Type: text/x-patch, Size: 3865 bytes --]

--- cus-dep.el-20020919	2002-09-19 18:57:48 +0000
+++ cus-dep.el-current	2002-11-07 01:05:06 +0000
@@ -34,30 +34,38 @@
 (defun custom-make-dependencies ()
   "Batch function to extract custom dependencies from .el files.
 Usage: emacs -batch -l ./cus-dep.el -f custom-make-dependencies DIRS"
-  (let ((enable-local-eval nil)
-	(all-subdirs command-line-args-left)
-	(start-directory default-directory))
-    (get-buffer-create " cus-dep temp")
-    (set-buffer " cus-dep temp")
-    (while all-subdirs
-      (message "Directory %s" (car all-subdirs))
-      (let ((files (directory-files (car all-subdirs) nil "\\`[^=].*\\.el\\'"))
-	    (default-directory default-directory)
-	    file
+  (let ((enable-local-eval nil))
+    (set-buffer (get-buffer-create " cus-dep temp"))
+    (dolist (subdir command-line-args-left)
+      (message "Directory %s" subdir)
+      (let ((files (directory-files subdir nil "\\`[^=].*\\.el\\'"))
+	    (default-directory (expand-file-name subdir))
+	    (preloaded (concat "\\`"
+			       (regexp-opt (mapcar
+					    (lambda (f)
+					      (file-name-sans-extension
+					       (file-name-nondirectory f)))
+					    preloaded-file-list) t)
+			       "\\.el\\'"))
 	    is-autoloaded)
-	(cd (car all-subdirs))
-	(while files
-	  (setq file (car files)
-		files (cdr files))
-	  (when (file-exists-p file)
+	(dolist (file files)
+	  (when (and (file-exists-p file)
+		     ;; Ignore files that are preloaded.
+		     (not (string-match preloaded file)))
 	    (erase-buffer)
 	    (insert-file-contents file)
 	    (goto-char (point-min))
 	    (string-match "\\`\\(.*\\)\\.el\\'" file)
 	    (let ((name (file-name-nondirectory (match-string 1 file))))
+	      (if (save-excursion
+		    (re-search-forward
+		     (concat "(provide[ \t\n]+\\('\\|(quote[ \t\n]\\)[ \t\n]*"
+			     (regexp-quote name) "[ \t\n)]")
+		     nil t))
+		  (setq name (intern name)))
 	      (condition-case nil
-		  (while (re-search-forward "^(defcustom\\|^(defface\\|^(defgroup"
-					    nil t)
+		  (while (re-search-forward
+			  "^(def\\(custom\\|face\\|group\\)" nil t)
 		    (setq is-autoloaded nil)
 		    (beginning-of-line)
 		    (save-excursion
@@ -66,15 +74,14 @@
 			  (setq is-autoloaded t)))
 		    (let ((expr (read (current-buffer))))
 		      (condition-case nil
-			  (progn
+			  (let ((custom-dont-initialize t))
 			    (eval expr)
 			    (put (nth 1 expr) 'custom-autoloaded is-autoloaded)
 			    (put (nth 1 expr) 'custom-where name))
 			(error nil))))
-		(error nil)))))
-	(setq all-subdirs (cdr all-subdirs)))))
+		(error nil))))))))
   (message "Generating cus-load.el...")
-  (find-file "cus-load.el")
+  (set-buffer (find-file-noselect "cus-load.el"))
   (erase-buffer)
   (insert "\
 ;;; cus-load.el --- automatically extracted custom dependencies
@@ -89,15 +96,7 @@
 		  ;; So x and no-x builds won't differ.
 		  (setq members
 			(sort (copy-sequence members) 
-			      (lambda (x y)
-				(cond ((and (stringp x) (stringp y))
-				       (string< x y))
-				      ;; Put all non-strings before strings.
-				      ((stringp y) t)
-				      ((stringp x) nil)
-				      ;; For two non-strings,
-				      ;; use the order they appear in MEMBERS.
-				      (t (member y (member x members)))))))
+			      (lambda (x y) (string< (car x) (car y)))))
 		  (while members
 		    (setq item (car (car members))
 			  members (cdr members)
@@ -114,7 +113,7 @@
 		    (insert "))\n"))))))
   (insert "\
 ;;; These are for handling :version.  We need to have a minimum of
-;;; information so `custom-changed-variables' could do its job.  
+;;; information so `customize-changed-options' could do its job.  
 ;;; For both groups and variables we have to set `custom-version'.
 ;;; For variables we also set the `standard-value' and for groups
 ;;; `group-documentation' (which is shown in the customize buffer), so

[-- Attachment #7: Type: text/plain, Size: 38 bytes --]

-- 
Katsumi Yamaoka <yamaoka@jpl.org>

Re: Wrong type argument: stringp when Generating cus-load.el

[Katsumi Yamaoka]

>>>>> In <yotlk7jpm3jz.fsf@jpl.org>
>>>>>	Katsumi Yamaoka <yamaoka@jpl.org> wrote:

> Here are the past record of cus-dep.el in Emacs CVS.

> --- cus-dep.el-20020917	2001-07-16 12:22:58 +0000
> +++ cus-dep.el-20020918	2002-09-18 16:01:21 +0000
> @@ -86,6 +86,8 @@
>  	      (let ((members (get symbol 'custom-group))
>  		    item where found)
>  		(when members
> +		  ;; So x and no-x builds won't differ.
> +		  (setq members (sort (copy-sequence members) 'string<))
>  		  (while members
>  		    (setq item (car (car members))
>  			  members (cdr members)

If Debian contains the 20020918 version of cus-dep.el, it seems
to be fixed by simply applying the above patch reverse.
-- 
Katsumi Yamaoka <yamaoka@jpl.org>

Re: Wrong type argument: stringp when Generating cus-load.el

[Manoj Srivastava]

>>"Katsumi" == Katsumi Yamaoka <yamaoka@jpl.org> writes:

>>>>> In <yotlk7jpm3jz.fsf@jpl.org>
>>>>>	Katsumi Yamaoka <yamaoka@jpl.org> wrote:

 >> --- cus-dep.el-20020917	2001-07-16 12:22:58 +0000
 >> +++ cus-dep.el-20020918	2002-09-18 16:01:21 +0000
 >> @@ -86,6 +86,8 @@
 >> (let ((members (get symbol 'custom-group))
 >> item where found)
 >> (when members
 >> +		  ;; So x and no-x builds won't differ.
 >> +		  (setq members (sort (copy-sequence members) 'string<))
 >> (while members
 >> (setq item (car (car members))
 >> members (cdr members)

 Katsumi> If Debian contains the 20020918 version of cus-dep.el, it seems
 Katsumi> to be fixed by simply applying the above patch reverse.

	I can confirm that that patch does indeed allow Gnus to be
 compiled on a Debian system.

	manoj
-- 
 "Don't drop acid, take it pass-fail!" Bryan Michael Wendt
Manoj Srivastava   <srivasta@acm.org>  <http://www.datasync.com/%7Esrivasta/>
1024R/C7261095 print CB D9 F4 12 68 07 E4 05  CC 2D 27 12 1D F5 E8 6E
1024D/BF24424C print 4966 F272 D093 B493 410B  924B 21BA DABB BF24 424C