Re: [PATCH] mml2015-epg-sign does not use from header.

[Daiki Ueno <ueno@unixuser.org>]

>>>>> In <87wscf3al8.fsf@hati.baby-gnu.org> 
>>>>>	Daniel Dehennin <daniel.dehennin@baby-gnu.org> wrote:
>   * lisp/mml2015.el (mml2015-epg-sign): New variable 'sender'
>     is (message-options-get 'message-sender). Use it in place of
>     mml2015-signers.

Sorry for late response, and thanks for splitting your patch.

> --- lisp/mml2015.el	2009-01-22 07:02:15 +0000
> +++ lisp/mml2015.el	2009-01-27 18:44:28 +0000
> @@ -1182,6 +1182,7 @@
>    (let* ((inhibit-redisplay t)
>  	 (context (epg-make-context))
>  	 (boundary (mml-compute-boundary cont))
> +	 (sender (message-options-get 'message-sender))
>  	 signer-key
>  	 (signers
>  	  (or (message-options-get 'mml2015-epg-signers)
> @@ -1191,8 +1192,8 @@
>  		   (epa-select-keys context "\
>  Select keys for signing.
>  If no one is selected, default secret key is used.  "
> -				    mml2015-signers t)
> -		 (if mml2015-signers
> +				    sender t)
> +		 (if sender
>  		     (delq nil
>  			   (mapcar
>  			    (lambda (signer)
> @@ -1206,7 +1207,7 @@
>  					    signer)))
>  				(error "No secret key for %s" signer))
>  			      signer-key)
> -			    mml2015-signers)))))))
> +			    (list sender))))))))
>  	 signature micalg)
>      (epg-context-set-armor context t)
>      (epg-context-set-textmode context t)

Unfortunatelly, this patch looks unacceptable since it breaks the
compatibility of the user setting.  Although I agree with that the
typical user would expect his From: line be used as the keygrip of the
signing key, existing users (including I) may have a setting of
mml2015-signers.

Why not adjust mml2015-signers to include the From: address instead of
entirely overwriting it?  Like this:

(defun mml2015-epg-uniquify-keys (keys)
  (let (key-id key-ids)
    (delq nil (mapcar
	       (lambda (key)
		 (setq key-id (car (epg-key-sub-key-list key)))
		 (unless (member key-id key-ids)
		   (setq key-ids (cons key-id key-ids))
		   key))
	       keys))))

In mml2015-epg-sign:

- mml2015-signers)))))))
+ (append mml2015-signers (list sender)))))))))

...

+ (setq signers (mml2015-epg-uniquify-keys signers))

Regards,
-- 
Daiki Ueno