Gnus development mailing list
 help / color / mirror / Atom feed
* sgnus 0.27, gnus-summary-move-article (nnml)
@ 1996-01-17 14:20 Ulrich Pfeifer
  0 siblings, 0 replies; 2+ messages in thread
From: Ulrich Pfeifer @ 1996-01-17 14:20 UTC (permalink / raw)


This kinof avoids the problem. Not shure if it is solved - but I can
move articles now (from nnml to nnml).

*** ./gnus.el~	Wed Jan 17 09:55:45 1996
--- ./gnus.el	Wed Jan 17 15:13:56 1996
***************
*** 10746,10757 ****
    (gnus-set-global-variables)
    ;; Check whether the source group supports the required functions.
    (cond ((and (eq action 'move)
! 	      (gnus-check-backend-function
! 	       'request-move-article gnus-newsgroup-name))
  	 (error "The current group does not support article moving"))
  	((and (eq action 'crosspost)
! 	      (gnus-check-backend-function
! 	       'request-replace-article gnus-newsgroup-name))
  	 (error "The current group does not support article editing")))
    (let ((articles (gnus-summary-work-articles n))
  	(prefix (gnus-group-real-prefix gnus-newsgroup-name))
--- 10747,10758 ----
    (gnus-set-global-variables)
    ;; Check whether the source group supports the required functions.
    (cond ((and (eq action 'move)
! 	      (not (gnus-check-backend-function
!                     'request-move-article gnus-newsgroup-name)))
  	 (error "The current group does not support article moving"))
  	((and (eq action 'crosspost)
! 	      (not (gnus-check-backend-function
!                     'request-replace-article gnus-newsgroup-name)))
  	 (error "The current group does not support article editing")))
    (let ((articles (gnus-summary-work-articles n))
  	(prefix (gnus-group-real-prefix gnus-newsgroup-name))
***************
*** 10885,10891 ****
  
  	(gnus-summary-goto-subject article)
  	(gnus-summary-mark-article article gnus-canceled-mark))
!       (gnus-summary-remove-process-mark (car articles)))
      (gnus-kill-buffer copy-buf)
      (gnus-set-mode-line 'summary)))
  
--- 10886,10892 ----
  
  	(gnus-summary-goto-subject article)
  	(gnus-summary-mark-article article gnus-canceled-mark))
!       (and (car articles) (gnus-summary-remove-process-mark (car articles))))
      (gnus-kill-buffer copy-buf)
      (gnus-set-mode-line 'summary)))
  

Ulrich Pfeifer
--
@J = split //,"J!k Phau^eHeens%rarrot&\ncl t ";
for(0..24){print $J[$_*7%($#J+1)]}


^ permalink raw reply	[flat|nested] 2+ messages in thread

* sgnus 0.27, gnus-summary-move-article (nnml)
@ 1996-01-17 14:00 Ulrich Pfeifer
  0 siblings, 0 replies; 2+ messages in thread
From: Ulrich Pfeifer @ 1996-01-17 14:00 UTC (permalink / raw)


To me, gnus-summary-move-article seems broken.

First,   
   (cond ((and (eq action 'move)
	      (gnus-check-backend-function
                    'request-move-article gnus-newsgroup-name))
	 (error "The current group does not support article moving"))
	((and (eq action 'crosspost)
	      (gnus-check-backend-function
                    'request-replace-article gnus-newsgroup-name))
	 (error "The current group does not support article editing")))

probably should be:

   (cond ((and (eq action 'move)
	      (not (gnus-check-backend-function
                    'request-move-article gnus-newsgroup-name)))
	 (error "The current group does not support article moving"))
	((and (eq action 'crosspost)
	      (not (gnus-check-backend-function
                    'request-replace-article gnus-newsgroup-name)))
	 (error "The current group does not support article editing")))

Since gnus-check-backend-function returns t on success.

This seems only the first problem:

Signalling: (error "format specifier doesn't match argument type")
  message("Can't find article %d" "nil")
  apply(message ("Can't find article %d" nil))
  gnus-message(3 "Can't find article %d" nil)
  gnus-summary-goto-subject(nil)
  gnus-summary-remove-process-mark(nil)
  (while articles (setq article (pop articles)) (setq art-group (cond ... ... ...)) (if (not art-group) (gnus-message 1 "Couldn't %s article %s" ... article) (let* ... ... ...) (gnus-summary-goto-subject article) (gnus-summary-mark-article article gnus-canceled-mark)) (gnus-summary-remove-process-mark (car articles)))
  (let ((articles ...) (prefix ...) (names ...) (copy-buf ...) art-group to-method new-xref article) (unless (assq action names) (error "Unknown action %s" action)) (when (and ... ...) (setq to-newsgroup ...) (set ... to-newsgroup)) (setq to-method (if select-method ... ...)) (or (gnus-check-backend-function ... ...) (error "%s does not support article copying" ...)) (or (gnus-check-server to-method) (error "Can't open server %s" ...)) (gnus-message 6 "%s to %s: %s..." (caddr ...) (or select-method to-newsgroup) articles) (while articles (setq article ...) (setq art-group ...) (if ... ... ... ... ...) (gnus-summary-remove-process-mark ...)) (gnus-kill-buffer copy-buf) (gnus-set-mode-line (quote summary)))
  gnus-summary-move-article(nil nil nil move)
  call-interactively(gnus-summary-move-article)

Ulrich Pfeifer
--
@J = split //,"J!k Phau^eHeens%rarrot&\ncl t ";
for(0..24){print $J[$_*7%($#J+1)]}


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~1996-01-17 14:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1996-01-17 14:20 sgnus 0.27, gnus-summary-move-article (nnml) Ulrich Pfeifer
  -- strict thread matches above, loose matches on Subject: below --
1996-01-17 14:00 Ulrich Pfeifer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).