From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/60818 Path: news.gmane.org!not-for-mail From: Ramkumar R Newsgroups: gmane.emacs.gnus.general Subject: Re: Fwd: Patch for a bug in imap-open Date: Sat, 27 Aug 2005 19:35:47 +0530 Message-ID: <9a9bfc170508270705c0af282@mail.gmail.com> References: <9a9bfc1705082505035774a0e0@mail.gmail.com> <9a9bfc1705082613105b0a87f1@mail.gmail.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1125151615 11245 80.91.229.2 (27 Aug 2005 14:06:55 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 27 Aug 2005 14:06:55 +0000 (UTC) Cc: ding@gnus.org Original-X-From: ding-owner+M9350=ding+2Daccount=gmane.org@lists.math.uh.edu Sat Aug 27 16:06:48 2005 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by ciao.gmane.org with esmtp (Exim 4.43) id 1E91Jw-0003pN-H5 for ding-account@gmane.org; Sat, 27 Aug 2005 16:06:08 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1E91Jv-0005vi-01 for ding-account@gmane.org; Sat, 27 Aug 2005 09:06:07 -0500 Original-Received: from util2.math.uh.edu ([129.7.128.23]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1E91Jn-0005vZ-00 for ding@lists.math.uh.edu; Sat, 27 Aug 2005 09:05:59 -0500 Original-Received: from quimby.gnus.org ([80.91.224.244]) by util2.math.uh.edu with esmtp (Exim 4.30) id 1E91Jd-0006q6-8s for ding@lists.math.uh.edu; Sat, 27 Aug 2005 09:05:49 -0500 Original-Received: from zproxy.gmail.com ([64.233.162.200]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1E91Jc-0000Cp-00 for ; Sat, 27 Aug 2005 16:05:48 +0200 Original-Received: by zproxy.gmail.com with SMTP id x3so428958nzd for ; Sat, 27 Aug 2005 07:05:47 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=I0LMgmaFnknr5Fn81D2KNqPdi16QRd5sxAJF8pSdmC8RPawGiI3TlfAIL3HNi4obVI0m5dzyRbDQvC2k/X+lsDqqzEUi/mWu7DZ5/bXZcv7SIGl/7wXrefPP+k/5Z03qeVrlFDwwOlU7jcIzpV9FY/QkjCikeo65XyF8rbTrokQ= Original-Received: by 10.37.15.27 with SMTP id s27mr452629nzi; Sat, 27 Aug 2005 07:05:47 -0700 (PDT) Original-Received: by 10.36.71.3 with HTTP; Sat, 27 Aug 2005 07:05:47 -0700 (PDT) Original-To: Simon Josefsson In-Reply-To: Content-Disposition: inline X-Spam-Score: -4.9 (----) Precedence: bulk Original-Sender: ding-owner@lists.math.uh.edu Xref: news.gmane.org gmane.emacs.gnus.general:60818 Archived-At: > There is something wrong with this patch; imap-open should make sure > the returned process is inside the buffer provided in the BUFFER > argument. Your patch changes this interface, causing all callers of > imap-open to be updated as follows: yeah....i realised that. from what i could gather from the function, the function tries to create a new buffer when tls is supported and fills in the contents. If we have to use the same buffer, we would need to reinitialize the buffer to a clean state, and use it instead of a new buffer. as i said, i am not familiar with the gnus source...so i didn't know if copying buffer contents after possibly a kill-all-local-variables would be safe...(the older buffer also has a process) or is it required that we selectively tweak some variables....this seemed the easiest way out...if u can figure that out, then perhaps we can manage with the same buffer.. > Exactly what problem did you see? Use (setq debug-on-signal t) to > find errors that are swallowed by condition-case. well...debug-on-signal springs up a lot of other spurious errors in other packages in my setup. For that matter, there are many cases where condition-case's are genuine, unlike in the case i described, where it was an error which was covered up for the user's convenience. Regards, Ramkumar. --=20 The day Microsoft makes something that doesn't suck is probably the day they start making vacuum cleaners. -Ernst Jan Plugge