From: Sylvain Chouleur <sylvain.chouleur@gmail.com>
To: ding@gnus.org
Subject: Re: [PATCH] Support vcal format timezones
Date: Wed, 15 Oct 2014 21:50:51 +0200 [thread overview]
Message-ID: <CAD_mUW35DUiw_YkzBaTwrPtaQu8Dyjk9cvhpNgpJkprLsAPKKg@mail.gmail.com> (raw)
In-Reply-To: <m2wq82mo2n.fsf@lifelogs.com>
[-- Attachment #1: Type: text/plain, Size: 670 bytes --]
Hi, my FSF assignment is in process.
here is the updated patch with Changelog entry
--
Sylvain
2014-10-14 21:46 GMT+02:00 Ted Zlatanov <tzz@lifelogs.com>:
> On Sun, 12 Oct 2014 01:56:00 +0200 Sylvain Chouleur <sylvain.chouleur@gmail.com> wrote:
>
> SC> here is a patch proposal in order to support icalendar timezones using
> SC> the RFC 5545 definition.
> SC> The code just reuse the icalendar.el functions
>
> Cool. It's just above the tiny change threshold of 10 lines! I can try
> to squeeze it into 10 lines if you don't have the copyright assignment
> papers?
>
> Also if you could provide a proper ChangeLog entry, it would be helpful.
>
> Thanks
> Ted
>
>
[-- Attachment #2: 0001-Support-vcal-format-timezones.patch --]
[-- Type: text/x-patch, Size: 3218 bytes --]
From 9a697b41cb2ad5dc7bf39553274638b346cdb894 Mon Sep 17 00:00:00 2001
From: Sylvain Chouleur <sylvain.chouleur@gmail.com>
Date: Thu, 9 Oct 2014 19:08:04 +0200
Subject: [PATCH] Support vcal format timezones
Old version only supported emacs known timezone.
Here we reuse icalendar code to extract timezone definition from
vcalendar format
Signed-off-by: Sylvain Chouleur <sylvain.chouleur@gmail.com>
---
lisp/ChangeLog | 7 +++++++
lisp/gnus-icalendar.el | 18 ++++++++++--------
2 files changed, 17 insertions(+), 8 deletions(-)
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 214a8bf3eb4c..b872ca665595 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,10 @@
+2014-10-15 Sylvain Chouleur <sylvain.chouleur@gmail.com>
+
+ * gnus-icalendar.el: Support vcal format timezones
+ (gnus-icalendar-event--decode-datefield): use icalendar functions to
+ compute dates with associated timezone
+ (gnus-icalendar-event-from-ical): compute all timezones
+
2014-10-14 Teodor Zlatanov <tzz@lifelogs.com>
* gnus-start.el (gnus-save-newsrc-file-check-timestamp): New option to
diff --git a/lisp/gnus-icalendar.el b/lisp/gnus-icalendar.el
index 3362cc878110..a9e4a24c93b0 100644
--- a/lisp/gnus-icalendar.el
+++ b/lisp/gnus-icalendar.el
@@ -141,12 +141,13 @@
(defmethod gnus-icalendar-event:start ((event gnus-icalendar-event))
(format-time-string "%Y-%m-%d %H:%M" (gnus-icalendar-event:start-time event)))
-(defun gnus-icalendar-event--decode-datefield (ical field)
- (let* ((date (icalendar--get-event-property ical field))
- (date-props (icalendar--get-event-property-attributes ical field))
- (tz (plist-get date-props 'TZID)))
-
- (date-to-time (timezone-make-date-arpa-standard date nil tz))))
+(defun gnus-icalendar-event--decode-datefield (event field zone-map)
+ (let* ((dtdate (icalendar--get-event-property event field))
+ (dtdate-zone (icalendar--find-time-zone
+ (icalendar--get-event-property-attributes
+ event field) zone-map))
+ (dtdate-dec (icalendar--decode-isodatetime dtdate nil dtdate-zone)))
+ (apply 'encode-time dtdate-dec)))
(defun gnus-icalendar-event--find-attendee (ical name-or-email)
(let* ((event (car (icalendar--all-events ical)))
@@ -204,10 +205,11 @@
("REQ-PARTICIPANT" 'required)
("OPT-PARTICIPANT" 'optional)
(_ 'non-participant)))
+ (zone-map (icalendar--convert-all-timezones ical))
(args (list :method method
:organizer organizer
- :start-time (gnus-icalendar-event--decode-datefield event 'DTSTART)
- :end-time (gnus-icalendar-event--decode-datefield event 'DTEND)
+ :start-time (gnus-icalendar-event--decode-datefield event 'DTSTART zone-map)
+ :end-time (gnus-icalendar-event--decode-datefield event 'DTEND zone-map)
:rsvp (string= (plist-get (cadr attendee) 'RSVP) "TRUE")
:participation-type participation-type
:req-participants (car attendee-names)
--
2.1.1
next prev parent reply other threads:[~2014-10-15 19:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-11 23:56 Sylvain Chouleur
2014-10-13 11:14 ` Magnus Henoch
2014-10-14 19:46 ` Ted Zlatanov
2014-10-15 19:50 ` Sylvain Chouleur [this message]
2014-10-16 12:42 ` Ted Zlatanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAD_mUW35DUiw_YkzBaTwrPtaQu8Dyjk9cvhpNgpJkprLsAPKKg@mail.gmail.com \
--to=sylvain.chouleur@gmail.com \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).