Gnus development mailing list
 help / color / mirror / Atom feed
From: Sylvain Chouleur <sylvain.chouleur@gmail.com>
To: ding@gnus.org
Subject: [PATCH] Support vcal format timezones
Date: Sun, 12 Oct 2014 01:56:00 +0200	[thread overview]
Message-ID: <CAD_mUW3dJ1fwpLjuczO+EJ--GW8vpASg-ZGQg-ojAMRknKJcuA@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

Hi all,

here is a patch proposal in order to support icalendar timezones using
the RFC 5545 definition.
The code just reuse the icalendar.el functions

Cheers,
-- 
Sylvain

[-- Attachment #2: 0001-Support-vcal-format-timezones.patch --]
[-- Type: text/x-patch, Size: 2625 bytes --]

From c6a28512523defaad43e7a6367c5dc86255e3d8b Mon Sep 17 00:00:00 2001
From: Sylvain Chouleur <sylvain.chouleur@gmail.com>
Date: Thu, 9 Oct 2014 19:08:04 +0200
Subject: [PATCH] Support vcal format timezones

Old version only supported emacs known timezone.
Here we reuse icalendar code to extract timezone definition from
vcalendar format

Signed-off-by: Sylvain Chouleur <sylvain.chouleur@gmail.com>
---
 lisp/gnus-icalendar.el | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/lisp/gnus-icalendar.el b/lisp/gnus-icalendar.el
index 3362cc878110..a9e4a24c93b0 100644
--- a/lisp/gnus-icalendar.el
+++ b/lisp/gnus-icalendar.el
@@ -141,12 +141,13 @@
 (defmethod gnus-icalendar-event:start ((event gnus-icalendar-event))
   (format-time-string "%Y-%m-%d %H:%M" (gnus-icalendar-event:start-time event)))
 
-(defun gnus-icalendar-event--decode-datefield (ical field)
-  (let* ((date (icalendar--get-event-property ical field))
-         (date-props (icalendar--get-event-property-attributes ical field))
-         (tz (plist-get date-props 'TZID)))
-
-    (date-to-time (timezone-make-date-arpa-standard date nil tz))))
+(defun gnus-icalendar-event--decode-datefield (event field zone-map)
+  (let* ((dtdate (icalendar--get-event-property event field))
+         (dtdate-zone (icalendar--find-time-zone
+                       (icalendar--get-event-property-attributes
+                        event field) zone-map))
+         (dtdate-dec (icalendar--decode-isodatetime dtdate nil dtdate-zone)))
+    (apply 'encode-time dtdate-dec)))
 
 (defun gnus-icalendar-event--find-attendee (ical name-or-email)
   (let* ((event (car (icalendar--all-events ical)))
@@ -204,10 +205,11 @@
                               ("REQ-PARTICIPANT" 'required)
                               ("OPT-PARTICIPANT" 'optional)
                               (_                 'non-participant)))
+         (zone-map (icalendar--convert-all-timezones ical))
          (args (list :method method
                      :organizer organizer
-                     :start-time (gnus-icalendar-event--decode-datefield event 'DTSTART)
-                     :end-time (gnus-icalendar-event--decode-datefield event 'DTEND)
+                     :start-time (gnus-icalendar-event--decode-datefield event 'DTSTART zone-map)
+                     :end-time (gnus-icalendar-event--decode-datefield event 'DTEND zone-map)
                      :rsvp (string= (plist-get (cadr attendee) 'RSVP) "TRUE")
                      :participation-type participation-type
                      :req-participants (car attendee-names)
-- 
2.1.1


             reply	other threads:[~2014-10-11 23:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-11 23:56 Sylvain Chouleur [this message]
2014-10-13 11:14 ` Magnus Henoch
2014-10-14 19:46 ` Ted Zlatanov
2014-10-15 19:50   ` Sylvain Chouleur
2014-10-16 12:42     ` Ted Zlatanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAD_mUW3dJ1fwpLjuczO+EJ--GW8vpASg-ZGQg-ojAMRknKJcuA@mail.gmail.com \
    --to=sylvain.chouleur@gmail.com \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).