[patch] CVS gnus-sum.el::gnus-list-of-unread-articles error checking

[patch] CVS gnus-sum.el::gnus-list-of-unread-articles error checking

[Jari+mail.emacs]

Please consider this change.

2005-01-29  Jari Aalto  <jari aalto A T cante net>

	        * gnus-sum.el (gnus-list-of-unread-articles): Improve
                active groups error checking and notify user.

root@host:/usr/share/site-lisp/net/cvs-packages/misc/gnus$ cvs diff -ubw lisp/gnus-sum.el
Index: lisp/gnus-sum.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-sum.el,v
retrieving revision 7.79
diff -u -IId: -u -b -w -r7.79 gnus-sum.el
--- lisp/gnus-sum.el    17 Jan 2005 00:11:34 -0000      7.79
+++ lisp/gnus-sum.el    30 Jan 2005 11:50:17 -0000
@@ -6429,7 +6429,8 @@
 (defun gnus-list-of-unread-articles (group)
   (let* ((read (gnus-info-read (gnus-get-info group)))
         (active (or (gnus-active group) (gnus-activate-group group)))
-        (last (cdr active))
+        (last   (or (cdr active)
+                    (error "Gnus: Group %s couldn't be activated " group)))
         first nlast unread)
     ;; If none are read, then all are unread.
     (if (not read)

Re: [patch] CVS gnus-sum.el::gnus-list-of-unread-articles error checking

[Katsumi Yamaoka]

>>>>> In <zmyrxhfe.fsf@blue.sea.net> Jari+mail.emacs wrote:

> 2005-01-29  Jari Aalto  <jari aalto A T cante net>

> 	        * gnus-sum.el (gnus-list-of-unread-articles): Improve
>                 active groups error checking and notify user.

> +                    (error "Gnus: Group %s couldn't be activated " group)))

I think to identify that it is issued by Gnus is not necessary,
removed it.  Am I right?

> 2004-09-02  Jari Aalto  <jari aalto A T poboxes com>

> 	        * message.el (message-send-mail-function): Check existence of
> 	        sendmail-program first before using
> 	        default value `message-send-mail-with-sendmail'. Oterwise
> 	        use more generic `smtpmail-send-it'.

Those changes seem to be useful.  I've committed them in the
Gnus trunk.  Thanks.

Re: [patch] CVS gnus-sum.el::gnus-list-of-unread-articles error checking

[Jari Aalto]

| >>>>> In <zmyrxhfe.fsf@blue.sea.net> Jari+mail.emacs wrote:
| 
| > 2005-01-29  Jari Aalto  <jari aalto A T cante net>
| 
| > 	        * gnus-sum.el (gnus-list-of-unread-articles): Improve
| >                 active groups error checking and notify user.
| 
| > +                    (error "Gnus: Group %s couldn't be activated " group)))
| 
| I think to identify that it is issued by Gnus is not necessary,
| removed it.  Am I right?

No problem. I just hope that all lisp program used prefix to announce that
"they" wrote the message. Message log would b easier to read in some cases.

| > 2004-09-02  Jari Aalto  <jari aalto A T poboxes com>
| 
| > 	        * message.el (message-send-mail-function): Check existence of
| > 	        sendmail-program first before using
| > 	        default value `message-send-mail-with-sendmail'. Oterwise
| > 	        use more generic `smtpmail-send-it'.
| 
| Those changes seem to be useful.  I've committed them in the
| Gnus trunk.  Thanks.

Especially the change are for for NTEmacs/Cygwin version.

Thank you,
Jari