Gnus development mailing list
 help / color / mirror / Atom feed
From: Richard Stallman <rms@gnu.org>
Cc: Lute.Kamstra.lists@xs4all.nl, reiner.steib@gmx.de, ding@gnus.org,
	emacs-devel@gnu.org, snogglethorpe@gmail.com, miles@gnu.org
Subject: Re: require inside functions. (was: Changes in
Date: Fri, 08 Apr 2005 23:38:33 -0400	[thread overview]
Message-ID: <E1DK6np-0007T4-9p@fencepost.gnu.org> (raw)
In-Reply-To: <m3y8btg01b.fsf@kfs-l.imdomain.dk> (storm@cua.dk)

    It is not _file_ foo, but _function_ foo that did (require 'bar).

    Why is it useful to record that?  For what purpose?

It isn't particularly useful, but it is hard to avoid.
Frequire does the same things, whether `require' was called
from a Lisp function or from code at top level in a file.

However, my change turns off recording in the case where
no file is being loaded.

Does this give good results?

*** fns.c	18 Jan 2005 19:52:01 -0500	1.382
--- fns.c	08 Apr 2005 22:22:22 -0400	
***************
*** 66,71 ****
--- 66,72 ----
  extern int minibuffer_auto_raise;
  extern Lisp_Object minibuf_window;
  extern Lisp_Object Vlocale_coding_system;
+ extern Lisp_Object Vloads_in_progress;
  
  Lisp_Object Qstring_lessp, Qprovide, Qrequire;
  Lisp_Object Qyes_or_no_p_history;
***************
*** 3444,3452 ****
    CHECK_SYMBOL (feature);
  
    /* Record the presence of `require' in this file
!      even if the feature specified is already loaded.  */
!   LOADHIST_ATTACH (Fcons (Qrequire, feature));
! 
    tem = Fmemq (feature, Vfeatures);
  
    if (NILP (tem))
--- 3445,3459 ----
    CHECK_SYMBOL (feature);
  
    /* Record the presence of `require' in this file
!      even if the feature specified is already loaded.
!      But not more than once in any file,
!      and not when we aren't loading a file.  */
!   if (! NILP (Vloads_in_progress))
!     {
!       tem = Fcons (Qrequire, feature);
!       if (NILP (Fmember (tem, Vcurrent_load_list)))
! 	LOADHIST_ATTACH (tem);
!     }
    tem = Fmemq (feature, Vfeatures);
  
    if (NILP (tem))



  reply	other threads:[~2005-04-09  3:38 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1DGYNu-00038g-00@quimby.gnus.org>
2005-03-30 12:18 ` CVS update of gnus/lisp (4 files) Katsumi Yamaoka
2005-03-31 11:27   ` Changes in calendar/time-date.el (was: CVS update of gnus/lisp (4 files)) Reiner Steib
2005-03-31 12:20     ` Miles Bader
2005-03-31 12:58     ` Changes in calendar/time-date.el Lute Kamstra
2005-03-31 22:52       ` Miles Bader
2005-04-01  4:10       ` Richard Stallman
2005-04-04 10:25       ` Reiner Steib
2005-04-04 10:57         ` Lute Kamstra
2005-04-04 12:09           ` Reiner Steib
2005-04-04 12:52             ` Lute Kamstra
2005-04-04 17:20               ` Reiner Steib
2005-04-04 19:50                 ` Stefan Monnier
2005-04-05  7:14                 ` Kim F. Storm
2005-04-05  9:33                   ` Miles Bader
2005-04-05 10:06                     ` Kim F. Storm
2005-04-07 12:47                       ` require inside functions. (was: Changes in calendar/time-date.el) Lute Kamstra
2005-04-07 21:45                         ` Kim F. Storm
2005-04-08  0:12                           ` require inside functions Miles Bader
2005-04-08  0:45                             ` Stefan Monnier
2005-04-08  2:09                               ` Miles Bader
2005-04-08  0:21                           ` Stefan Monnier
2005-04-08  3:22                         ` require inside functions. (was: Changes in calendar/time-date.el) Richard Stallman
2005-04-08  8:12                           ` Kim F. Storm
2005-04-09  3:38                             ` Richard Stallman [this message]
2005-04-09  9:30                               ` require inside functions Lute Kamstra
2005-04-10  1:55                                 ` Richard Stallman
2005-04-13  9:11                               ` Lute Kamstra
2005-04-15  2:44                                 ` Richard Stallman
2005-04-15  9:23                                   ` Lute Kamstra
2005-04-08  8:16                           ` David Kastrup
2005-04-05 13:54                 ` Changes in calendar/time-date.el Lute Kamstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1DK6np-0007T4-9p@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=Lute.Kamstra.lists@xs4all.nl \
    --cc=ding@gnus.org \
    --cc=emacs-devel@gnu.org \
    --cc=miles@gnu.org \
    --cc=reiner.steib@gmx.de \
    --cc=snogglethorpe@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).